From: Lucas Stach <l.stach@pengutronix.de>
To: Abel Vesa <abel.vesa@nxp.com>
Cc: Rob Herring <robh@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mike Turquette <mturquette@baylibre.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Angus Ainslie <angus.ainslie@puri.sm>,
Anson Huang <anson.huang@nxp.com>,
dl-linux-imx <linux-imx@nxp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [RFC 5/5] arm64: dts: imx8mq: Add the opp table and the cpu-supply nodes
Date: Thu, 14 Feb 2019 18:32:40 +0100 [thread overview]
Message-ID: <1550165560.2546.50.camel@pengutronix.de> (raw)
In-Reply-To: <1550165185.2546.48.camel@pengutronix.de>
Am Donnerstag, den 14.02.2019, 18:26 +0100 schrieb Lucas Stach:
> Am Donnerstag, den 14.02.2019, 17:18 +0000 schrieb Abel Vesa:
> > On 19-02-14 16:50:28, Lucas Stach wrote:
> > > Hi Abel
> > >
> > > Am Mittwoch, den 13.02.2019, 19:05 +0000 schrieb Abel Vesa:
> > > > Add the opp table containing only non over drive opps.
> > > > Also add the cpu-supply nodes for the A53 cores in the EVK
> > > > board.
> > > >
> > > > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > > > ---
> > > > arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 17
> > > > +++++++++++++++++
> > > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 23
> > > > +++++++++++++++++++++++
> > > > 2 files changed, 40 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > > > b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > > > index 54737bf..114359e 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> > > > @@ -31,6 +31,23 @@
> > > > gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> > > > enable-active-high;
> > > > };
> > > > +
> > > > +};
> > > > +
> > > > +&A53_0 {
> > > > + cpu-supply = <&sw1a_reg>;
> > > > +};
> > > > +
> > > > +&A53_1 {
> > > > + cpu-supply = <&sw1a_reg>;
> > > > +};
> > > > +
> > > > +&A53_2 {
> > > > + cpu-supply = <&sw1a_reg>;
> > > > +};
> > > > +
> > > > +&A53_3 {
> > > > + cpu-supply = <&sw1a_reg>;
> > > > };
> > >
> > > This should be a separate patch.
> > >
> >
> > OK, will send as separate patches in the next version.
> >
> > > And AFAICS this is wrong, sw1a on the MX8M-EVK is the GPU supply,
> > > the
> > > CPU is supplied by a dedicated switcher that is controlled via a
> > > GPIO.
> > >
> >
> > Hmm, I think you're right. At least this is what the following
> > document says.
> >
> > https://www.mouser.com/ds/2/302/IMX8MDQLQEVKHUG-1280333.pdf
> >
> > So I guess this means there will not be any cpu-supply properties.
>
> There is a variable voltage CPU supply, but you need to model it as a
> gpio-regulator in the DT, it's not part of the PMIC provided rails.
In the schematics it's the line called PWM_LED (actually it's just
GPIO1_IO13) that controls the voltage. This changes the feedback of the
DCDC switcher, so it can toggle between 0.9V and 1.0V.
Regards,
Lucas
next prev parent reply other threads:[~2019-02-14 17:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 19:05 [RFC 0/5] Add cpufreq-dt support i.MX8MQ Abel Vesa
2019-02-13 19:05 ` [RFC 1/5] clk: imx: imx8mq: Fix the rate propagation for arm pll Abel Vesa
2019-02-14 15:51 ` Lucas Stach
2019-02-13 19:05 ` [RFC 2/5] dt-bindings: imx8mq-clock: Add the missing ARM clock Abel Vesa
2019-02-14 15:51 ` Lucas Stach
2019-02-13 19:05 ` [RFC 3/5] clk: imx8mq: " Abel Vesa
2019-02-14 15:52 ` Lucas Stach
2019-02-13 19:05 ` [RFC 4/5] arm64: dts: imx8mq: Add the clocks and the latencies for the A53 cores Abel Vesa
2019-02-13 19:05 ` [RFC 5/5] arm64: dts: imx8mq: Add the opp table and the cpu-supply nodes Abel Vesa
2019-02-14 15:50 ` Lucas Stach
2019-02-14 17:18 ` Abel Vesa
2019-02-14 17:26 ` Lucas Stach
2019-02-14 17:32 ` Lucas Stach [this message]
2019-02-14 17:52 ` Abel Vesa
2019-02-15 0:55 ` Angus Ainslie
2019-02-15 8:56 ` Abel Vesa
2019-02-14 15:55 ` [RFC 0/5] Add cpufreq-dt support i.MX8MQ Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550165560.2546.50.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=abel.vesa@nxp.com \
--cc=angus.ainslie@puri.sm \
--cc=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).