From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 610F7C10F02 for ; Fri, 15 Feb 2019 21:29:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28A6B222D7 for ; Fri, 15 Feb 2019 21:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550266167; bh=UR08ykxIkKh0Vfj/fVGtLCw461Bc+tzNrBFf3QgA33s=; h=To:In-Reply-To:Subject:References:Cc:From:Date:List-ID:From; b=zbc3g4bb1WCjWwMbRkWHEQz6LEfsUKsO2YH8H3THWLFYdlTfuwo/kcq3X11mVSfyF DbMgun5cmm2vdHyVGDSGFvyEYuKNnPNKkrLKzLK3IX2ibhFtlIFUzDPpfqxkFxQy8g uo1/yOKVIuh6HesLn4rcBFRg/OmsfpBGZD9Jtk2E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732617AbfBOV30 (ORCPT ); Fri, 15 Feb 2019 16:29:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:58534 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728755AbfBOV3Z (ORCPT ); Fri, 15 Feb 2019 16:29:25 -0500 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 471F6222BE; Fri, 15 Feb 2019 21:29:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550266165; bh=UR08ykxIkKh0Vfj/fVGtLCw461Bc+tzNrBFf3QgA33s=; h=To:In-Reply-To:Subject:References:Cc:From:Date:From; b=qhOvOvWRMRcsmaE5t8f0FlgIALa3sup2rb9Re5HuZMqX0k1XMEsy8Hq8FbOyxqC9P eIYcuR3Wuo1Dt5Gxb/jdMP4cut5buK01/KBRi2hFvCFLdsO7qsZPNAJgalomvmicG6 v2nhU9T0QaSBQACCRXUYUUGgQS4Ez1zEnijIsM+8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Jeffrey Hugo , Michael Turquette In-Reply-To: <488f5033-c7a5-b49b-b973-c1415e533019@codeaurora.org> User-Agent: alot/0.8 Subject: Re: [PATCH 2/9] clk: Introduce get_parent_hw clk op Message-ID: <155026616459.115909.14315694127255521155@swboyd.mtv.corp.google.com> References: <20190129061021.94775-1-sboyd@kernel.org> <20190129061021.94775-3-sboyd@kernel.org> <41f8f325-2738-3995-1fc8-354a9412041e@codeaurora.org> <155025643198.115909.9355230466710329335@swboyd.mtv.corp.google.com> <488f5033-c7a5-b49b-b973-c1415e533019@codeaurora.org> Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Miquel Raynal , Jerome Brunet , Russell King From: Stephen Boyd Date: Fri, 15 Feb 2019 13:29:24 -0800 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Jeffrey Hugo (2019-02-15 11:29:26) > On 2/15/2019 11:47 AM, Stephen Boyd wrote: > > Quoting Jeffrey Hugo (2019-02-11 08:09:00) > >> On 1/28/2019 11:10 PM, Stephen Boyd wrote: > >> > >>> +static int clk_init_parent(struct clk_core *core) > >>> +{ > >>> + core->parent =3D __clk_init_parent(core, true); > >>> + if (IS_ERR(core->parent)) > >>> + return PTR_ERR(core->parent); > >>> + > >>> + /* > >>> + * Populate core->parent if parent has already been clk_core_in= it'd. If > >>> + * parent has not yet been clk_core_init'd then place clk in th= e orphan > >>> + * list. If clk doesn't have any parents then place it in the = root > >>> + * clk list. > >>> + * > >>> + * Every time a new clk is clk_init'd then we walk the list of = orphan > >>> + * clocks and re-parent any that are children of the clock curr= ently > >>> + * being clk_init'd. > >>> + */ > >>> + if (core->parent) { > >>> + hlist_add_head(&core->child_node, > >>> + &core->parent->children); > >>> + core->orphan =3D core->parent->orphan; > >>> + } else if (!core->num_parents) { > >>> + hlist_add_head(&core->child_node, &clk_root_list); > >>> + core->orphan =3D false; > >>> + } else { > >>> + hlist_add_head(&core->child_node, &clk_orphan_list); > >> > >> Missing "core->orphan =3D true;"? > >> The snippet below had that line. Its not clear why it appears to be > >> dropped here. > >> > >=20 > > Hmm. Weird. I think I may have been getting ahead of myself and moving > > the orphan updating code into __clk_init_parent(). I can't remember why > > though, so I guess I'll go all the way and move it all into > > __clk_init_parent() now. Thanks for pointing it out. > >=20 >=20 > No problem. >=20 > Just FYI, I've rebased the 8998 mmcc series on top of this, and as far=20 > as I can tell, everything seems to be working great. >=20 Cool. Are you using the new way to specify parents or have you maintained the previous design of using string names for parents?