archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <>
Cc: Tetsuo Handa <>,
	Vlastimil Babka <>, Michal Hocko <>,
	Tetsuo Handa <>,,
Subject: [PATCH] mm: Fix buddy list helpers
Date: Sat, 16 Feb 2019 09:07:02 -0800	[thread overview]
Message-ID: <> (raw)

Tetsuo reports that free page statistics are not reporting correctly,
and Vlastimil noticed that "mm: Move buddy list manipulations into
helpers" botched one of its conversions of add_to_free_area(). Fix the
double-increment of ->nr_free.

Reported-by: Tetsuo Handa <>
Reported-by: Vlastimil Babka <>
Cc: Michal Hocko <>
Tested-by: Tetsuo Handa <>
Signed-off-by: Dan Williams <>
Hi Andrew,

Please fold this into

 mm/page_alloc.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2a0969e3b0eb..da537fc39c54 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1851,7 +1851,6 @@ static inline void expand(struct zone *zone, struct page *page,
 		add_to_free_area(&page[size], area, migratetype);
-		area->nr_free++;
 		set_page_order(&page[size], high);

             reply	other threads:[~2019-02-16 17:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-16 17:07 Dan Williams [this message]
2019-02-18  9:42 ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] mm: Fix buddy list helpers' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox