linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: kernel-janitors@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 06/12] omapfb: add missing of_node_put after of_device_is_available
Date: Sat, 23 Feb 2019 14:20:37 +0100	[thread overview]
Message-ID: <1550928043-14889-7-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1550928043-14889-1-git-send-email-Julia.Lawall@lip6.fr>

Add an of_node_put when a tested device node is not available.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@

e = f(...);
... when != of_node_put(e)
    when != x = e
    when != e = x
    when any
if (<+...of_device_is_available(e)...+>) {
  ... when != of_node_put(e)
(
  return e;
|
+ of_node_put(e);
  return ...;
)
}
// </smpl>

Fixes: f76ee892a99e6 ("omapfb: copy omapdss & displays for omapfb")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff -u -p a/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c b/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
--- a/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
@@ -193,8 +193,10 @@ static int __init omapdss_boot_init(void
 
 	dss = of_find_matching_node(NULL, omapdss_of_match);
 
-	if (dss == NULL || !of_device_is_available(dss))
+	if (dss == NULL || !of_device_is_available(dss)) {
+		of_node_put(dss);
 		return 0;
+	}
 
 	omapdss_walk_device(dss, true);
 


  parent reply	other threads:[~2019-02-23 13:59 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-23 13:20 [PATCH 00/12] add missing of_node_put after of_device_is_available Julia Lawall
2019-02-23 13:20 ` [PATCH 01/12] arm-cci: " Julia Lawall
2019-04-01 12:48   ` Mukesh Ojha
2019-04-14 14:45   ` Markus Elfring
2019-04-16 13:02     ` Robin Murphy
2019-02-23 13:20 ` [PATCH 02/12] drm/tegra: rgb: " Julia Lawall
2019-04-01 12:49   ` Mukesh Ojha
2019-04-14 15:01   ` Markus Elfring
2019-02-23 13:20 ` [PATCH 03/12] PowerPC-83xx: " Julia Lawall
2019-04-01 12:49   ` Mukesh Ojha
2019-04-14 15:25   ` Markus Elfring
2019-02-23 13:20 ` [PATCH 04/12] phy: tegra: " Julia Lawall
2019-04-01 12:50   ` Mukesh Ojha
2019-04-14 15:42   ` Markus Elfring
2019-02-23 13:20 ` [PATCH 05/12] tee: optee: " Julia Lawall
2019-02-28 11:17   ` Jens Wiklander
2019-02-23 13:20 ` Julia Lawall [this message]
2019-04-01 12:07   ` [PATCH 06/12] omapfb: " Bartlomiej Zolnierkiewicz
2019-02-23 13:20 ` [PATCH 07/12] drm: omapdrm: " Julia Lawall
2019-04-01 12:58   ` Mukesh Ojha
2019-02-23 13:20 ` [PATCH 08/12] crypto: " Julia Lawall
2019-02-28  6:39   ` Herbert Xu
2019-02-23 13:20 ` [PATCH 09/12] meson-gx-socinfo: " Julia Lawall
2019-03-12 20:28   ` Kevin Hilman
2019-04-14 16:12   ` Markus Elfring
2019-02-23 13:20 ` [PATCH 10/12] cpufreq: ap806: " Julia Lawall
2019-02-25  4:29   ` Viresh Kumar
2019-02-23 13:20 ` [PATCH 11/12] ARM: OMAP2+: " Julia Lawall
2019-03-22 22:24   ` Tony Lindgren
2019-04-14 16:38   ` [11/12] " Markus Elfring
2019-04-14 16:49     ` Julia Lawall
2019-02-23 13:20 ` [PATCH 12/12] drivers: firmware: psci: " Julia Lawall
2019-04-01 12:47   ` Mukesh Ojha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1550928043-14889-7-git-send-email-Julia.Lawall@lip6.fr \
    --to=julia.lawall@lip6.fr \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).