linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Qian Cai <cai@lca.pw>
To: Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hotplug: fix an imbalance with DEBUG_PAGEALLOC
Date: Tue, 26 Feb 2019 14:19:42 -0500	[thread overview]
Message-ID: <1551208782.6911.51.camel@lca.pw> (raw)
In-Reply-To: <20190226182007.GH10588@dhcp22.suse.cz>

On Tue, 2019-02-26 at 19:20 +0100, Michal Hocko wrote:
> Btw. what happens if the offlined pfn range is removed completely? Is
> the range still mapped? What kind of consequences does this have?

Well, the pages are still marked as reserved as well, so it is up to the
physically memory hotplug handler to free kernel direct mapping pagetable,
virtual memory mapping pages, and virtual memory mapping pagetable as by design,
although I have no way to test it.

> Also when does this tweak happens on a completely new hotplugged memory
> range?

I suppose it will call online_pages() which in-turn call
kernel_unmap_linear_page() which may or may not have the same issue, but I have
no way to test that path.

  reply	other threads:[~2019-02-26 19:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-25 19:17 [PATCH] mm/hotplug: fix an imbalance with DEBUG_PAGEALLOC Qian Cai
2019-02-26 12:13 ` Souptick Joarder
2019-02-26 14:07   ` Qian Cai
2019-02-26 12:35 ` Michal Hocko
2019-02-26 14:16   ` Qian Cai
2019-02-26 14:23     ` Michal Hocko
2019-02-26 17:53       ` Qian Cai
2019-02-26 18:16         ` Michal Hocko
2019-02-26 18:20           ` Michal Hocko
2019-02-26 19:19             ` Qian Cai [this message]
2019-02-26 19:40               ` Michal Hocko
2019-02-26 20:10                 ` Qian Cai
2019-02-26 20:40                   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1551208782.6911.51.camel@lca.pw \
    --to=cai@lca.pw \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).