From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F656C43381 for ; Thu, 28 Feb 2019 16:03:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E7D92184A for ; Thu, 28 Feb 2019 16:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551369832; bh=0moKi9ZDADvDamp5b4cHz81e+NQhJ8w3MIPUXyiDZQI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=n8IdIoDQHdhtIfPyp8ElCkar+PjZSEwziq4AcguiXCRDDS0jBiyCer//SKvKpSvLU CJLoXicURfUzt4IKUt3eGZEdoc1y8EYpdRnD75sHViOq2b66ZWvr2T9ZCj53f3yRdL GGT7J7rPVngZ8V+hEHco1piYf5oP1Ods+JRkuYGs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732430AbfB1QDu (ORCPT ); Thu, 28 Feb 2019 11:03:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:49754 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731208AbfB1QDu (ORCPT ); Thu, 28 Feb 2019 11:03:50 -0500 Received: from localhost.localdomain (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0C931218B0; Thu, 28 Feb 2019 16:03:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551369829; bh=0moKi9ZDADvDamp5b4cHz81e+NQhJ8w3MIPUXyiDZQI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gDikd4k/4WtwbrVy+FkwkVJ7/AaJKHSEA0dtvP0kI9CU2uk48GA2p3or1i/7DusKg cVW+BMGivYwr/OkQ8SmOUDFNXeY4vHGUAiFiTNurjpKYmusSHQfk4VYTZK9hiLK6Wk WUqGoAj3fkck0o7OaxtvmtfBWcwDSDVHg+RKyJqk= From: Masami Hiramatsu To: Steven Rostedt , Linus Torvalds , Shuah Khan Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Ingo Molnar , Andrew Morton , Changbin Du , Jann Horn , Kees Cook , Andy Lutomirski , Alexei Starovoitov , Nadav Amit , Peter Zijlstra , Joel Fernandes , yhs@fb.com Subject: [PATCH v5 2/6] uaccess: Use user_access_ok() in user_access_begin() Date: Fri, 1 Mar 2019 01:03:25 +0900 Message-Id: <155136980507.2968.15165201054223875356.stgit@devbox> X-Mailer: git-send-email 2.13.6 In-Reply-To: <155136974478.2968.3105123100519786079.stgit@devbox> References: <155136974478.2968.3105123100519786079.stgit@devbox> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use user_access_ok() instead of access_ok() in user_access_begin() to validate the access context is user. This also allow us to use (generic) strncpy_from_user() and strnlen_user() in atomic state with setting USER_DS and disable pagefaults. Signed-off-by: Masami Hiramatsu --- arch/x86/include/asm/uaccess.h | 2 +- include/linux/uaccess.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h index 3125d129d3b6..3b7502a34114 100644 --- a/arch/x86/include/asm/uaccess.h +++ b/arch/x86/include/asm/uaccess.h @@ -715,7 +715,7 @@ extern struct movsl_mask { */ static __must_check inline bool user_access_begin(const void __user *ptr, size_t len) { - if (unlikely(!access_ok(ptr,len))) + if (unlikely(!user_access_ok(ptr, len))) return 0; __uaccess_begin_nospec(); return 1; diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h index bf762689658b..1afd9dfabe67 100644 --- a/include/linux/uaccess.h +++ b/include/linux/uaccess.h @@ -282,7 +282,7 @@ extern long strncpy_from_unsafe(char *dst, const void *unsafe_addr, long count); probe_kernel_read(&retval, addr, sizeof(retval)) #ifndef user_access_begin -#define user_access_begin(ptr,len) access_ok(ptr, len) +#define user_access_begin(ptr, len) user_access_ok(ptr, len) #define user_access_end() do { } while (0) #define unsafe_get_user(x, ptr, err) do { if (unlikely(__get_user(x, ptr))) goto err; } while (0) #define unsafe_put_user(x, ptr, err) do { if (unlikely(__put_user(x, ptr))) goto err; } while (0)