From: Srinath Mannam <srinath.mannam@broadcom.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Srinath Mannam <srinath.mannam@broadcom.com>,
Abhishek Shah <abhishek.shah@broadcom.com>,
Ray Jui <ray.jui@broadcom.com>
Subject: [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region
Date: Fri, 1 Mar 2019 10:22:16 +0530 [thread overview]
Message-ID: <1551415936-30174-3-git-send-email-srinath.mannam@broadcom.com> (raw)
In-Reply-To: <1551415936-30174-1-git-send-email-srinath.mannam@broadcom.com>
In the present driver outbound window configuration is done to map above
32-bit address I/O regions with corresponding PCI memory range given in
ranges DT property.
This patch add outbound window configuration to map below 32-bit I/O range
with corresponding PCI memory, which helps to access I/O region in ARM
32-bit and one to one mapping of I/O region to PCI memory.
Ex:
1. ranges DT property given for current driver is,
ranges = <0x83000000 0x0 0x40000000 0x4 0x00000000 0 0x40000000>;
I/O region address is 0x400000000
2. ranges DT property can be given after this patch,
ranges = <0x83000000 0x0 0x42000000 0x0 0x42000000 0 0x2000000>;
I/O region address is 0x42000000
Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
Signed-off-by: Abhishek Shah <abhishek.shah@broadcom.com>
Signed-off-by: Ray Jui <ray.jui@broadcom.com>
---
drivers/pci/controller/pcie-iproc.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/pcie-iproc.c b/drivers/pci/controller/pcie-iproc.c
index b882255..080f142 100644
--- a/drivers/pci/controller/pcie-iproc.c
+++ b/drivers/pci/controller/pcie-iproc.c
@@ -955,8 +955,25 @@ static int iproc_pcie_setup_ob(struct iproc_pcie *pcie, u64 axi_addr,
resource_size_t window_size =
ob_map->window_sizes[size_idx] * SZ_1M;
- if (size < window_size)
- continue;
+ /*
+ * Keep iterating until we reach the last window and
+ * with the minimal window size at index zero. In this
+ * case, we take a compromise by mapping it using the
+ * minimum window size that can be supported
+ */
+ if (size < window_size) {
+ if (size_idx > 0 || window_idx > 0)
+ continue;
+
+ /*
+ * For the corner case of reaching the minimal
+ * window size that can be supported on the
+ * last window
+ */
+ axi_addr = ALIGN_DOWN(axi_addr, window_size);
+ pci_addr = ALIGN_DOWN(pci_addr, window_size);
+ size = window_size;
+ }
if (!IS_ALIGNED(axi_addr, window_size) ||
!IS_ALIGNED(pci_addr, window_size)) {
--
2.7.4
next prev parent reply other threads:[~2019-03-01 4:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 4:52 [PATCH v4 0/2] Add IPROC PCIe new features Srinath Mannam
2019-03-01 4:52 ` [PATCH v4 1/2] PCI: iproc: Add CRS check in config read Srinath Mannam
2019-03-01 4:52 ` Srinath Mannam [this message]
2019-03-29 17:35 ` [PATCH v4 2/2] PCI: iproc: Add outbound configuration for 32-bit I/O region Lorenzo Pieralisi
2019-04-01 5:34 ` Srinath Mannam
2019-04-01 16:44 ` Lorenzo Pieralisi
2019-04-01 22:03 ` Ray Jui
2019-04-02 9:50 ` Srinath Mannam
2019-04-02 10:26 ` Lorenzo Pieralisi
2019-04-02 10:46 ` Srinath Mannam
2019-04-02 13:38 ` Lorenzo Pieralisi
2019-04-03 3:11 ` Srinath Mannam
2019-04-03 11:31 ` Lorenzo Pieralisi
2019-04-04 5:41 ` Srinath Mannam
2019-04-04 17:48 ` Ray Jui
2019-03-27 8:38 ` [PATCH v4 0/2] Add IPROC PCIe new features Srinath Mannam
2019-03-27 12:31 ` Lorenzo Pieralisi
2019-03-27 15:15 ` Srinath Mannam
2019-03-29 16:51 ` Lorenzo Pieralisi
2019-03-29 17:03 ` Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551415936-30174-3-git-send-email-srinath.mannam@broadcom.com \
--to=srinath.mannam@broadcom.com \
--cc=abhishek.shah@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=ray.jui@broadcom.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).