From: James Bottomley <jejb@linux.ibm.com>
To: Erwan Velu <e.velu@criteo.com>,
Erwan Velu <erwanaliasr1@gmail.com>,
"elliott@hpe.com" <elliott@hpe.com>
Cc: Don Brace <don.brace@microsemi.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"open list:MICROSEMI SMART ARRAY SMARTPQI DRIVER (smartpqi)"
<esc.storagedev@microsemi.com>,
"open list:MICROSEMI SMART ARRAY SMARTPQI DRIVER (smartpqi)"
<linux-scsi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: smartpqi_init: Reporting 'logical unit failure'
Date: Fri, 01 Mar 2019 07:56:37 -0800 [thread overview]
Message-ID: <1551455797.3334.6.camel@linux.ibm.com> (raw)
In-Reply-To: <c858605b-7283-7882-64a8-8d1584274b95@criteo.com>
On Fri, 2019-03-01 at 15:43 +0000, Erwan Velu wrote:
> Le 01/03/2019 à 16:26, James Bottomley a écrit :
> > [...]
> > Shouldn't this be a variant of sdev/scmd_printk? Otherwise it
> > tells
> > you what disk in the array terms is the problem but not what device
> > in
> > your actual system is affected.
>
> Hey James,
>
> My initial take on that was that pqi_take_device_offline(), which is
> called just after, will print the "re-scanning " message with the
> same
> format.
>
> As they will be both printed in the same error context and one after
> the
> other, I though that would make sense to represent the same
> information
> to ease the reading like cause -> consequence.
>
> As the message is about the LUN itself, which is reported faulty, I
> though it would worth reporting the info that way.
>
> Shall I consider printing also the disk name in addition ?
I was thinking just
if (printk_ratelimit())
scmd_printk(KERN_ERR, scmd, "received 'logical unit failure' from controller for scsi %d:%d:%d:%d\n", ...
That will give all the necessary information
James
next prev parent reply other threads:[~2019-03-01 15:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-27 16:31 [PATCH] scsi: smartpqi_init: Reporting 'logical unit failure' Erwan Velu
2019-02-28 13:09 ` Erwan Velu
2019-02-28 20:03 ` Elliott, Robert (Persistent Memory)
2019-03-01 14:59 ` Erwan Velu
2019-03-01 14:58 ` [PATCH v2] " Erwan Velu
2019-03-01 15:26 ` James Bottomley
2019-03-01 15:43 ` Erwan Velu
2019-03-01 15:56 ` James Bottomley [this message]
2019-03-01 16:00 ` Erwan Velu
2019-03-01 16:08 ` [PATCH v3] " Erwan Velu
2019-03-05 22:30 ` Don.Brace
2019-03-06 17:34 ` Martin K. Petersen
2019-03-11 16:36 ` Erwan Velu
2019-03-11 16:43 ` Erwan Velu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551455797.3334.6.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=don.brace@microsemi.com \
--cc=e.velu@criteo.com \
--cc=elliott@hpe.com \
--cc=erwanaliasr1@gmail.com \
--cc=esc.storagedev@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).