From: Paul Cercueil <paul@crapouillou.net>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Harvey Hunt <harveyhuntnexus@gmail.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/9] dt-bindings: mtd: ingenic: Change 'BCH' to 'ECC' in documentation
Date: Mon, 04 Mar 2019 19:23:50 +0100 [thread overview]
Message-ID: <1551723830.4932.3@crapouillou.net> (raw)
In-Reply-To: <20190304105014.0cceea0a@xps13>
On Mon, Mar 4, 2019 at 10:50 AM, Miquel Raynal
<miquel.raynal@bootlin.com> wrote:
> Hi Paul,
>
> Paul Cercueil <paul@crapouillou.net <mailto:paul@crapouillou.net>>
> wrote on Sat, 9 Feb 2019 16:22:58
> -0300:
>
>> The JZ4740 ECC hardware is not BCH but Reed-Solomon, so it makes
>> more
>> sense to use the more generic ECC term.
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net
>> <mailto:paul@crapouillou.net>>
>> ---
>>
>> Changes:
>>
>> v3: New patch
>>
>> v4: No change
>>
>> .../devicetree/bindings/mtd/ingenic,jz4780-nand.txt | 18
>> +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt
>> b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt
>> index a5b940f18bf6..5a45cc54f46d 100644
>> --- a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt
>> +++ b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt
>> @@ -1,4 +1,4 @@
>> -* Ingenic JZ4780 NAND/BCH
>> +* Ingenic JZ4780 NAND/ECC
>>
>> This file documents the device tree bindings for NAND flash
>> devices on the
>> JZ4780. NAND devices are connected to the NEMC controller
>> (described in
>> @@ -14,10 +14,10 @@ Required NAND controller device properties:
>> an offset of 0 and a size of 0x1000000 (i.e. the whole NEMC
>> bank).
>>
>> Optional NAND controller device properties:
>> -- ingenic,bch-controller: To make use of the hardware BCH
>> controller, this
>> - property must contain a phandle for the BCH controller node. The
>> required
>> +- ingenic,bch-controller: To make use of the hardware ECC
>> controller, this
>> + property must contain a phandle for the ECC controller node. The
>> required
>
> I think there is already a 'ecc-engine' property used by MTK and Atmel
> NAND controllers to point to the ECC engine block. Please use this
> property instead of the ingenic specific one.
ingenic,bch-controller is already in the devicetree ABI. I can't change
it now...
>> properties for this node are described below. If this is not
>> specified,
>> - software BCH will be used instead.
>> + software ECC will be used instead.
>>
>> Optional children nodes:
>> - Individual NAND chips are children of the NAND controller node.
>> @@ -70,17 +70,17 @@ nemc: nemc@13410000 {
>> };
>> };
>>
>> -The BCH controller is a separate SoC component used for error
>> correction on
>> +The ECC controller is a separate SoC component used for error
>> correction on
>> NAND devices. The following is a description of the device
>> properties for a
>> -BCH controller.
>> +ECC controller.
>>
>> -Required BCH properties:
>> +Required ECC properties:
>> - compatible: Should be one of:
>> * ingenic,jz4740-ecc
>> * ingenic,jz4725b-bch
>> * ingenic,jz4780-bch
>> -- reg: Should specify the BCH controller registers location and
>> length.
>> -- clocks: Clock for the BCH controller.
>> +- reg: Should specify the ECC controller registers location and
>> length.
>> +- clocks: Clock for the ECC controller.
>>
>> Example:
>>
>
> Thanks,
> Miquèl
next prev parent reply other threads:[~2019-03-04 18:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 19:22 [PATCH v4 1/9] dt-bindings: mtd: ingenic: Add compatible strings for JZ4740 and JZ4725B Paul Cercueil
2019-02-09 19:22 ` [PATCH v4 2/9] dt-bindings: mtd: ingenic: Change 'BCH' to 'ECC' in documentation Paul Cercueil
2019-02-13 21:46 ` Rob Herring
2019-03-04 9:50 ` Miquel Raynal
2019-03-04 18:23 ` Paul Cercueil [this message]
2019-03-04 18:58 ` Miquel Raynal
2019-03-13 12:59 ` Paul Cercueil
2019-03-13 13:12 ` Miquel Raynal
2019-02-09 19:22 ` [PATCH v4 3/9] mtd: rawnand: Move drivers for Ingenic SoCs to subfolder Paul Cercueil
2019-02-09 19:23 ` [PATCH v4 4/9] mtd: rawnand: ingenic: Use SPDX license notifiers Paul Cercueil
2019-02-09 19:23 ` [PATCH v4 5/9] mtd: rawnand: ingenic: Rename jz4780_nand driver to ingenic_nand Paul Cercueil
2019-02-09 19:23 ` [PATCH v4 6/9] mtd: rawnand: ingenic: Separate top-level and SoC specific code Paul Cercueil
2019-03-04 10:20 ` Miquel Raynal
2019-03-04 18:26 ` Paul Cercueil
2019-03-04 19:04 ` Miquel Raynal
2019-02-09 19:23 ` [PATCH v4 7/9] mtd: rawnand: ingenic: Add support for the JZ4740 Paul Cercueil
2019-03-04 10:34 ` Miquel Raynal
2019-03-04 18:28 ` Paul Cercueil
2019-03-04 19:07 ` Miquel Raynal
2019-02-09 19:23 ` [PATCH v4 8/9] mtd: rawnand: ingenic: Add support for the JZ4725B Paul Cercueil
2019-03-04 10:35 ` Miquel Raynal
2019-03-04 18:30 ` Paul Cercueil
2019-03-04 19:09 ` Miquel Raynal
2019-03-13 12:46 ` Paul Cercueil
2019-02-09 19:23 ` [PATCH v4 9/9] mtd: rawnand: ingenic: Add ooblayout for the Qi Ben Nanonote Paul Cercueil
2019-02-13 21:45 ` [PATCH v4 1/9] dt-bindings: mtd: ingenic: Add compatible strings for JZ4740 and JZ4725B Rob Herring
2019-03-04 9:45 ` Miquel Raynal
2019-03-04 18:22 ` Paul Cercueil
2019-03-04 18:51 ` Miquel Raynal
2019-03-13 12:55 ` Paul Cercueil
2019-03-13 13:09 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551723830.4932.3@crapouillou.net \
--to=paul@crapouillou.net \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=harveyhuntnexus@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).