* [PATCH] drivers: uwb: Kconfig: pedantic cleanups
@ 2019-03-06 18:51 Enrico Weigelt, metux IT consult
2019-03-06 19:26 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-03-06 18:51 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-usb
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/uwb/Kconfig | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/uwb/Kconfig b/drivers/uwb/Kconfig
index afac258..d0e15e1 100644
--- a/drivers/uwb/Kconfig
+++ b/drivers/uwb/Kconfig
@@ -41,31 +41,31 @@ config UWB_HWA
is safe to select any even if you do not have the hardware.
config UWB_WHCI
- tristate "UWB Radio Control driver for WHCI-compliant cards"
- depends on PCI
- help
- This driver enables the radio controller for WHCI cards.
+ tristate "UWB Radio Control driver for WHCI-compliant cards"
+ depends on PCI
+ help
+ This driver enables the radio controller for WHCI cards.
- WHCI is a specification developed by Intel
- (http://www.intel.com/technology/comms/wusb/whci.htm) much
- in the spirit of USB's EHCI, but for UWB and Wireless USB
- radio/host controllers connected via memory mapping (eg:
- PCI). Most of these cards come also with a Wireless USB host
- controller.
+ WHCI is a specification developed by Intel
+ (http://www.intel.com/technology/comms/wusb/whci.htm) much
+ in the spirit of USB's EHCI, but for UWB and Wireless USB
+ radio/host controllers connected via memory mapping (eg:
+ PCI). Most of these cards come also with a Wireless USB host
+ controller.
- To compile this driver select Y (built in) or M (module). It
- is safe to select any even if you do not have the hardware.
+ To compile this driver select Y (built in) or M (module). It
+ is safe to select any even if you do not have the hardware.
config UWB_I1480U
- tristate "Support for Intel Wireless UWB Link 1480 HWA"
- depends on UWB_HWA
- select FW_LOADER
- help
- This driver enables support for the i1480 when connected via
- USB. It consists of a firmware uploader that will enable it
- to behave as an HWA device.
+ tristate "Support for Intel Wireless UWB Link 1480 HWA"
+ depends on UWB_HWA
+ select FW_LOADER
+ help
+ This driver enables support for the i1480 when connected via
+ USB. It consists of a firmware uploader that will enable it
+ to behave as an HWA device.
- To compile this driver select Y (built in) or M (module). It
- is safe to select any even if you do not have the hardware.
+ To compile this driver select Y (built in) or M (module). It
+ is safe to select any even if you do not have the hardware.
endif # UWB
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: uwb: Kconfig: pedantic cleanups
2019-03-06 18:51 [PATCH] drivers: uwb: Kconfig: pedantic cleanups Enrico Weigelt, metux IT consult
@ 2019-03-06 19:26 ` Greg KH
2019-03-06 21:43 ` [PATCH v2] " Enrico Weigelt, metux IT consult
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2019-03-06 19:26 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult; +Cc: linux-kernel, linux-usb
On Wed, Mar 06, 2019 at 07:51:46PM +0100, Enrico Weigelt, metux IT consult wrote:
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/uwb/Kconfig | 42 +++++++++++++++++++++---------------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
I do not take patches without any changelog comments.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] drivers: uwb: Kconfig: pedantic cleanups
2019-03-06 19:26 ` Greg KH
@ 2019-03-06 21:43 ` Enrico Weigelt, metux IT consult
2019-03-12 13:17 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-03-06 21:43 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-usb
Formatting of Kconfig files doesn't look so pretty, so just
take damp cloth and clean it up.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/uwb/Kconfig | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/uwb/Kconfig b/drivers/uwb/Kconfig
index afac258..d0e15e1 100644
--- a/drivers/uwb/Kconfig
+++ b/drivers/uwb/Kconfig
@@ -41,31 +41,31 @@ config UWB_HWA
is safe to select any even if you do not have the hardware.
config UWB_WHCI
- tristate "UWB Radio Control driver for WHCI-compliant cards"
- depends on PCI
- help
- This driver enables the radio controller for WHCI cards.
+ tristate "UWB Radio Control driver for WHCI-compliant cards"
+ depends on PCI
+ help
+ This driver enables the radio controller for WHCI cards.
- WHCI is a specification developed by Intel
- (http://www.intel.com/technology/comms/wusb/whci.htm) much
- in the spirit of USB's EHCI, but for UWB and Wireless USB
- radio/host controllers connected via memory mapping (eg:
- PCI). Most of these cards come also with a Wireless USB host
- controller.
+ WHCI is a specification developed by Intel
+ (http://www.intel.com/technology/comms/wusb/whci.htm) much
+ in the spirit of USB's EHCI, but for UWB and Wireless USB
+ radio/host controllers connected via memory mapping (eg:
+ PCI). Most of these cards come also with a Wireless USB host
+ controller.
- To compile this driver select Y (built in) or M (module). It
- is safe to select any even if you do not have the hardware.
+ To compile this driver select Y (built in) or M (module). It
+ is safe to select any even if you do not have the hardware.
config UWB_I1480U
- tristate "Support for Intel Wireless UWB Link 1480 HWA"
- depends on UWB_HWA
- select FW_LOADER
- help
- This driver enables support for the i1480 when connected via
- USB. It consists of a firmware uploader that will enable it
- to behave as an HWA device.
+ tristate "Support for Intel Wireless UWB Link 1480 HWA"
+ depends on UWB_HWA
+ select FW_LOADER
+ help
+ This driver enables support for the i1480 when connected via
+ USB. It consists of a firmware uploader that will enable it
+ to behave as an HWA device.
- To compile this driver select Y (built in) or M (module). It
- is safe to select any even if you do not have the hardware.
+ To compile this driver select Y (built in) or M (module). It
+ is safe to select any even if you do not have the hardware.
endif # UWB
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drivers: uwb: Kconfig: pedantic cleanups
2019-03-06 21:43 ` [PATCH v2] " Enrico Weigelt, metux IT consult
@ 2019-03-12 13:17 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2019-03-12 13:17 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult; +Cc: linux-kernel, linux-usb
On Wed, Mar 06, 2019 at 10:43:44PM +0100, Enrico Weigelt, metux IT consult wrote:
> Formatting of Kconfig files doesn't look so pretty, so just
> take damp cloth and clean it up.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
There's no need to put your "what I do" in the signed off by line, this
should just read:
Signed-off-by: Enrico Weigelt <info@metux.net>
It's obvious from your domain as to who you work for, the only reason
some people put a company name in this line is if they use the same
email address for different companies. And even then, I don't like it
and it turns out my scripts just ignore it when doing the "who works for
whom" reports :)
So please fix up and resend your patches with this change.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-12 13:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-06 18:51 [PATCH] drivers: uwb: Kconfig: pedantic cleanups Enrico Weigelt, metux IT consult
2019-03-06 19:26 ` Greg KH
2019-03-06 21:43 ` [PATCH v2] " Enrico Weigelt, metux IT consult
2019-03-12 13:17 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).