From: Stephen Boyd <sboyd@kernel.org>
To: Patrick Wildt <patrick@blueri.se>
Cc: Abel Vesa <abel.vesa@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Lucas Stach <l.stach@pengutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, dl-linux-imx <linux-imx@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: clock: imx8mq: Fix numbering overlaps and gaps
Date: Tue, 12 Mar 2019 13:39:50 -0700 [thread overview]
Message-ID: <155242319026.20095.4334777579139010310@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20190312073654.GA85609@thor.local>
Quoting Patrick Wildt (2019-03-12 00:36:54)
> On Fri, Mar 08, 2019 at 07:29:05AM -0800, Stephen Boyd wrote:
> > It's mostly about making sure that any existing dtbs don't have their
> > numbers shifted around. So hopefully any overlapping identifiers aren't
> > in use yet and then those ids can be changed while leaving the ones that
> > are in use how they are.
>
> In practice I bet no one uses Linux 5.0's i.MX8M device trees since they
> lack too much support. It's so basic it's not useful. You'd still run
> your existing non-mainline bindings until it is. Thus I would argue
> changing the ABI right now would be the only chance there is.
>
> If you think that chance is gone, then I guess the reasonable thing is
> to keep the numbers and only move those (to the end) which overlap. Or
> put them into that erreneous number gap.
>
The chance is quickly slipping away because we're going to be at -rc1
soon. I'm not the one to decide what is and isn't being used by people
out there, so I'm happy to apply this patch now before the next -rc1
comes out as long as it doesn't break anything in arm-soc area. The
confidence I'm getting isn't high though. Has anyone from NXP reviewed
this change? Maybe I can get an ack from someone else that normally
looks after the arm-soc/dts side of things here indicating that nothing
should go wrong? That would increase my confidence levels.
next prev parent reply other threads:[~2019-03-12 20:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 9:49 [PATCH] dt-bindings: clock: imx8mq: Fix numbering overlaps and gaps Abel Vesa
2019-03-05 18:38 ` Stephen Boyd
2019-03-06 13:09 ` Abel Vesa
2019-03-08 15:29 ` Stephen Boyd
2019-03-12 7:36 ` Patrick Wildt
2019-03-12 20:39 ` Stephen Boyd [this message]
2019-03-12 20:59 ` Patrick Wildt
2019-03-12 22:02 ` Stephen Boyd
2019-03-15 13:33 ` Aisheng Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155242319026.20095.4334777579139010310@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patrick@blueri.se \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).