From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1916C43381 for ; Thu, 14 Mar 2019 22:36:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88C4B2184C for ; Thu, 14 Mar 2019 22:36:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728454AbfCNWgY (ORCPT ); Thu, 14 Mar 2019 18:36:24 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:55051 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728299AbfCNWf2 (ORCPT ); Thu, 14 Mar 2019 18:35:28 -0400 Received: from orion.localdomain ([95.117.89.18]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N2VGj-1guDas0JF1-013tPv; Thu, 14 Mar 2019 23:34:53 +0100 From: "Enrico Weigelt, metux IT consult" To: linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, eric@anholt.net, stefan.wahren@i2se.com, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, andriy.shevchenko@linux.intel.com, vz@mleia.com, matthias.bgg@gmail.com, yamada.masahiro@socionext.com, tklauser@distanz.ch, richard.genoud@gmail.com, macro@linux-mips.org, u.kleine-koenig@pengutronix.de, kernel@pengutronix.de, slemieux.tyco@gmail.com, andy.gross@linaro.org, david.brown@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, baohua@kernel.org, jacmet@sunsite.dk, linux-serial@vger.kernel.org, linux-arm-msm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH v2 22/45] drivers: tty: serial: altera_uart: use devm_* functions Date: Thu, 14 Mar 2019 23:33:52 +0100 Message-Id: <1552602855-26086-23-git-send-email-info@metux.net> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1552602855-26086-1-git-send-email-info@metux.net> References: <1552602855-26086-1-git-send-email-info@metux.net> X-Provags-ID: V03:K1:HRcMubCl3N0QCtdhqoBNq0bPoJCbZHNiTmEpSNwwLRZVYnt2ZMx jUx1m4mQpcGoYURsig0O/V4XNZY3cW0ETmLEJO181v9/Phz7JS13acIuMZJXS2kVgeCDC0e rCQDk9V0Sr8dqk4fgIWphZNEiZMC9v9PkGsJwYowXf2tukaPvdV5AsU5QoTedKYHXyR9w25 T3HqZcufo578vTzTzuIsA== X-UI-Out-Filterresults: notjunk:1;V03:K0:lpRqgLeb8zc=:sNipjjzqP8wdzFQL6Kw4vZ MSDB6yhuOSOfxVhWGKozjrCOY1WswqY7E+cMjEZ9JI+EZA2q6s6ZNUzB5Z0CQZnUMG1MimHmE wF8us2SJRAsBrBCw3i8j0cFtULXuwTzhWQJqeibknIFxtUsnfYXKM6ARtSgnj1OaM16cuqtZM klcjsNMSExmysWWLiGmqGmEt8CraYu25yutjQbLArR4cV3sIittiav51rKJ8XFkQRCwT9s5EI wU2VP79xIRiqTc7NpPIer1L/k8hLq5wV5AgzsMpbOsGCmJ4dJgtAivXp/97tQcAo0BBR3qwq/ ln1m6hl3JYIpjMvE7s30grv/9HV3vcNE0OK8RTK+6ydQiHWS2vpscS+My9IItuhbzhvTpRmPb GL9nwGUGXTbYRdZaKvjSM/qJR3grbl9f0lvO7aqPg0Fmh+I7Mq6ZliNNY2/1eC0XeCLApGdPL HAIA7XNK5euFkmrnd7rdiGs1YCC8JPlv5CgghK6PI7xhW/ORoncvdxVjDQz2QW3QrMOF1gFiE +sDWYBtjGemcUtTfaCSLaKSGqKd1rS40qqiqZobymHCQV32ywtXcDLSSW7TI56c3iSgUUTXEy FLYD9mQYh6w3kHL/oG8SdVg93Xv95W4PJbj6Onub32os097Rd6fXeOA0odkkugrNZvZ5rdK7b NTLbTTiuYYijV2/ZlLH/qq6gJnxoImCjA/+GU3qu6+vNuIj4RvV5ZSqNFBgk32e+rojN8xTQV rBRXLv1d9wm7LwRS8b0kkH1tXHF8kb7tuoLQeg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the safer devm versions of memory mapping functions. The iounmap() call isn't necessary anymore, as devm will clean up. Signed-off-by: Enrico Weigelt, metux IT consult --- drivers/tty/serial/altera_uart.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/altera_uart.c b/drivers/tty/serial/altera_uart.c index 0e487ce..d4f7150 100644 --- a/drivers/tty/serial/altera_uart.c +++ b/drivers/tty/serial/altera_uart.c @@ -595,7 +595,9 @@ static int altera_uart_probe(struct platform_device *pdev) return ret; } - port->membase = ioremap(port->mapbase, ALTERA_UART_SIZE); + port->membase = devm_ioremap(port->dev, + port->mapbase, + ALTERA_UART_SIZE); if (!port->membase) return -ENOMEM; @@ -625,7 +627,6 @@ static int altera_uart_remove(struct platform_device *pdev) if (port) { uart_remove_one_port(&altera_uart_driver, port); port->mapbase = 0; - iounmap(port->membase); } return 0; -- 1.9.1