From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Herring <robh@kernel.org>
Cc: Archit Taneja <architt@codeaurora.org>,
Alexandru M Stan <amstan@chromium.org>,
David Airlie <airlied@linux.ie>,
Mark Rutland <mark.rutland@arm.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Sean Paul <seanpaul@chromium.org>,
devicetree@vger.kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Heiko Stuebner <heiko@sntech.de>,
briannorris@chromium.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, dianders@chromium.org,
linux-rockchip@lists.infradead.org, marcheu@chromium.org,
hoegsberg@chromium.org,
Thierry Escande <thierry.escande@collabora.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>
Subject: Re: [PATCH 1/2] dt-bindings: analogix-dp: Add backlight-pwm-passthru
Date: Tue, 20 Mar 2018 16:07:50 +0200 [thread overview]
Message-ID: <15529527.TZOXJSfS0B@avalon> (raw)
In-Reply-To: <20180318125245.ndnplplmtsy3hmu7@rob-hp-laptop>
Hello,
On Sunday, 18 March 2018 14:52:45 EET Rob Herring wrote:
> On Fri, Mar 16, 2018 at 02:56:09PM +0530, Archit Taneja wrote:
> > On Friday 16 March 2018 08:26 AM, Alexandru M Stan wrote:
> > > Documentation for the optional backlight-pwm-passthru property.
> > > Tells the EDP panel to folow the input pwm frequency instead
> >
> > s/folow/follow
> >
> > It would be nice if we could add the details you mentioned in
> > patch #0 in either this or the next patch.
> >
> > > of generating its own.
> >
> > This is one of those bindings which is more a knob than a HW property,
> > but I can't think of any easy way to figure this out in SW. So, I guess
> > it's okay to have.
> >
> > One thing I was wondering about was whether this prop should belong to
> > the eDP controller or the eDP panel. I don't have any strong opinion
> > about it, though.
>
> Seems to me, it should be the panel. It's a setting in the panel, right?
As this aims at fixing an issue with the panel, I agree it should be a panel
property.
Stupid question (I'm not too familiar with eDP panels), couldn't we set
EDP_BACKLIGHT_FREQ_PWM_PIN_PASSTHRU unconditionally ?
> Is this generic to DP panels or something specific to a certain panel?
> The naming (vendor prefix or not) and doc location should match
> whatever the answer to that is.
>
> > Reviewed-by: Archit Taneja <architt@codeaurora.org>
> >
> > Thanks,
> > Archit
> >
> > > Signed-off-by: Alexandru M Stan <amstan@chromium.org>
> > > ---
> > >
> > > Documentation/devicetree/bindings/display/bridge/analogix_dp.txt | 4
> > > ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt
> > > b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt
> > > index 0c7473dd0e51..3c15242f6ce3 100644
> > > --- a/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt
> > > +++ b/Documentation/devicetree/bindings/display/bridge/analogix_dp.txt
> > >
> > > @@ -23,6 +23,10 @@ Required properties for dp-controller:
> > > from general PHY binding: Should be "dp".
> > >
> > > Optional properties for dp-controller:
> > > + -backlight-pwm-passthru:
> > > + Directly pass the PWM frequency applied to the BL_PWM_DIM
> > > + pin to the backlight current source. Done via
> > > + EDP_BACKLIGHT_MODE_SET_REGISTER on DPCD.
> > >
> > > -force-hpd:
> > > Indicate driver need force hpd when hpd detect failed, this
> > > is used for some eDP screen which don't have hpd signal.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-03-20 14:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 2:56 [PATCH 0/2] Add backlight-pwm-passthru in analogix DP driver Alexandru M Stan
2018-03-16 2:56 ` [PATCH 1/2] dt-bindings: analogix-dp: Add backlight-pwm-passthru Alexandru M Stan
2018-03-16 9:26 ` Archit Taneja
2018-03-18 12:52 ` Rob Herring
2018-03-20 14:07 ` Laurent Pinchart [this message]
2018-03-16 2:56 ` [PATCH 2/2] drm/bridge: analogix: Enable EDP_BACKLIGHT_FREQ_PWM_PIN_PASSTHRU Alexandru M Stan
2018-03-16 8:36 ` Daniel Vetter
2018-03-16 16:50 ` [PATCH 0/2] Add backlight-pwm-passthru in analogix DP driver Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15529527.TZOXJSfS0B@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=amstan@chromium.org \
--cc=architt@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=heiko@sntech.de \
--cc=hoegsberg@chromium.org \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marcheu@chromium.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=seanpaul@chromium.org \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).