From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22081C43381 for ; Fri, 22 Mar 2019 20:56:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E136B21929 for ; Fri, 22 Mar 2019 20:56:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727521AbfCVU40 (ORCPT ); Fri, 22 Mar 2019 16:56:26 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:45744 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726822AbfCVU4X (ORCPT ); Fri, 22 Mar 2019 16:56:23 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2MKmgEn106735 for ; Fri, 22 Mar 2019 16:56:22 -0400 Received: from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rd4srwyef-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 22 Mar 2019 16:56:22 -0400 Received: from localhost by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 22 Mar 2019 20:56:19 -0000 Received: from b03cxnp08026.gho.boulder.ibm.com (9.17.130.18) by e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 22 Mar 2019 20:56:14 -0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x2MKuFjo61014164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 22 Mar 2019 20:56:15 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 19AA3C605A; Fri, 22 Mar 2019 20:56:15 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 00CDAC6059; Fri, 22 Mar 2019 20:56:14 +0000 (GMT) Received: from arbab-laptop.localdomain (unknown [9.53.179.210]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 22 Mar 2019 20:56:14 +0000 (GMT) Received: by arbab-laptop.localdomain (Postfix, from userid 152845) id 9B9F54607FA; Fri, 22 Mar 2019 15:56:13 -0500 (CDT) From: Reza Arbab To: Dave Airlie , Sean Paul , David Airlie , Daniel Vetter , Robert Tarasov , Linus Walleij , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: wzabolot@elektron.elka.pw.edu.pl, Pavel Machek , Alex Deucher , =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= Subject: [PATCH 1/2] drm/udl: Fix off-by-one error in udl_get_edid() Date: Fri, 22 Mar 2019 15:56:12 -0500 X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1553288173-10845-1-git-send-email-arbab@linux.ibm.com> References: <1553288173-10845-1-git-send-email-arbab@linux.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 19032220-8235-0000-0000-00000E7224F4 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00010796; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000282; SDB=6.01178185; UDB=6.00616394; IPR=6.00958883; MB=3.00026116; MTD=3.00000008; XFM=3.00000015; UTC=2019-03-22 20:56:17 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19032220-8236-0000-0000-000044DEC244 Message-Id: <1553288173-10845-2-git-send-email-arbab@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-22_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903220148 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The loop which reads EDID extension blocks is off by one. Fix it. Fixes: 75c65ee20ade ("drm/udl: Reading all edid blocks in DRM/UDL driver") Signed-off-by: Reza Arbab --- drivers/gpu/drm/udl/udl_connector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c index 66885c24590f..820543415a78 100644 --- a/drivers/gpu/drm/udl/udl_connector.c +++ b/drivers/gpu/drm/udl/udl_connector.c @@ -71,7 +71,7 @@ static bool udl_get_edid(struct udl_device *udl, u8 **result_buff, memcpy(buff_ptr, block_buff, EDID_LENGTH); kfree(block_buff); buff_ptr += EDID_LENGTH; - for (i = 1; i < extensions; ++i) { + for (i = 1; i <= extensions; ++i) { if (udl_get_edid_block(udl, i, buff_ptr)) { buff_ptr += EDID_LENGTH; } else { -- 1.8.3.1