linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Kieran Bingham <kbingham@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Douglas Anderson <dianders@chromium.org>,
	Nikolay Borisov <n.borisov.lkml@gmail.com>,
	Jackie Liu <liuyun01@kylinos.cn>
Subject: Re: [PATCH 3/4] scripts/gdb: Add rb tree iterating utilities
Date: Tue, 26 Mar 2019 13:39:00 -0700	[thread overview]
Message-ID: <155363274033.20095.10762543028999566245@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <ff5bffea-2689-0ace-9c77-2aaa6605342c@siemens.com>

Quoting Jan Kiszka (2019-03-26 10:21:21)
> On 26.03.19 18:05, Stephen Boyd wrote:
> > Quoting Kieran Bingham (2019-03-26 01:52:10)
> >>
> >> Do you foresee any similar issue here? Or is the corresponding RB code
> >> in the kernel fairly 'stable'?
> >>
> >>
> >> Please could we make sure whomever maintains the RBTree code is aware of
> >> the python implementation?
> >>
> >> That said, MAINTAINERS doesn't actually seem to list any ownership over
> >> the rb-tree code, and get_maintainers.pl [0] seems to be pointing at
> >> Andrew as the probable route in for that code so perhaps that's already
> >> in place :D
> > 
> > I don't think that the rb tree implementation is going to change. It
> > feels similar to the list API. I suppose this problem of keeping things
> > in sync is a more general problem than just data-structures changing.
> > The only solution I can offer is to have more testing and usage of these
> > scripts. Unless gdb can "simulate" or run arbitrary code for us then I
> > think we're stuck reimplementing kernel internal code in gdb scripts so
> > that we can get debug info out.
> > 
> 
> Could we possibly leave some link in form of comment in the related headers or 
> implementations? Won't magically solve the problem but at least increase changes 
> that author actually read them when they start changing the C implementations.
> 

Sure. Can you propose some sort of patch against the 'list'
implementation for this? I'd like to just use whatever policy is decided
here.

  reply	other threads:[~2019-03-26 20:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25 18:45 [PATCH 0/4] gdb script for kconfig and timer list Stephen Boyd
2019-03-25 18:45 ` [PATCH 1/4] scripts/gdb: Find vmlinux where it was before Stephen Boyd
2019-03-25 18:45 ` [PATCH 2/4] scripts/gdb: Add kernel config dumping command Stephen Boyd
2019-03-25 18:45 ` [PATCH 3/4] scripts/gdb: Add rb tree iterating utilities Stephen Boyd
2019-03-26  8:52   ` Kieran Bingham
2019-03-26 17:05     ` Stephen Boyd
2019-03-26 17:21       ` Jan Kiszka
2019-03-26 20:39         ` Stephen Boyd [this message]
2019-03-27 10:37       ` Kieran Bingham
2019-03-25 18:45 ` [PATCH 4/4] scripts/gdb: Add a timer list command Stephen Boyd
2019-03-26  8:39 ` [PATCH 0/4] gdb script for kconfig and timer list Kieran Bingham
2019-03-26 20:35   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=155363274033.20095.10762543028999566245@swboyd.mtv.corp.google.com \
    --to=swboyd@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=dianders@chromium.org \
    --cc=jan.kiszka@siemens.com \
    --cc=kbingham@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuyun01@kylinos.cn \
    --cc=n.borisov.lkml@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).