LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] platform/x86: dell-laptop: fix rfkill functionality
@ 2019-03-27 14:25 Mario Limonciello
  2019-04-03 20:23 ` Darren Hart
  0 siblings, 1 reply; 4+ messages in thread
From: Mario Limonciello @ 2019-03-27 14:25 UTC (permalink / raw)
  To: dvhart, Andy Shevchenko; +Cc: LKML, platform-driver-x86, Mario Limonciello

When converting the driver two arguments were transposed leading
to rfkill not working.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427
Reported-by: Pepijn de Vos <pepijndevos@gmail.com>
Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls")
Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
---
 drivers/platform/x86/dell-laptop.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index 95e6ca1..a561f65 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -531,7 +531,7 @@ static void dell_rfkill_query(struct rfkill *rfkill, void *data)
 		return;
 	}
 
-	dell_fill_request(&buffer, 0, 0x2, 0, 0);
+	dell_fill_request(&buffer, 0x2, 0, 0, 0);
 	ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL);
 	hwswitch = buffer.output[1];
 
@@ -562,7 +562,7 @@ static int dell_debugfs_show(struct seq_file *s, void *data)
 		return ret;
 	status = buffer.output[1];
 
-	dell_fill_request(&buffer, 0, 0x2, 0, 0);
+	dell_fill_request(&buffer, 0x2, 0, 0, 0);
 	hwswitch_ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL);
 	if (hwswitch_ret)
 		return hwswitch_ret;
@@ -647,7 +647,7 @@ static void dell_update_rfkill(struct work_struct *ignored)
 	if (ret != 0)
 		return;
 
-	dell_fill_request(&buffer, 0, 0x2, 0, 0);
+	dell_fill_request(&buffer, 0x2, 0, 0, 0);
 	ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL);
 
 	if (ret == 0 && (status & BIT(0)))
-- 
2.7.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86: dell-laptop: fix rfkill functionality
  2019-03-27 14:25 [PATCH] platform/x86: dell-laptop: fix rfkill functionality Mario Limonciello
@ 2019-04-03 20:23 ` Darren Hart
  2019-04-03 21:54   ` Mario.Limonciello
  0 siblings, 1 reply; 4+ messages in thread
From: Darren Hart @ 2019-04-03 20:23 UTC (permalink / raw)
  To: Mario Limonciello; +Cc: Andy Shevchenko, LKML, platform-driver-x86

On Wed, Mar 27, 2019 at 09:25:34AM -0500, Mario Limonciello wrote:
> When converting the driver two arguments were transposed leading
> to rfkill not working.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427
> Reported-by: Pepijn de Vos <pepijndevos@gmail.com>
> Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls")
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> Acked-by: Pali Rohár <pali.rohar@gmail.com>

Looks like this broken in 4.14? So Cc stable back to then? I'm surprised it's
been broken that long :-(

-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] platform/x86: dell-laptop: fix rfkill functionality
  2019-04-03 20:23 ` Darren Hart
@ 2019-04-03 21:54   ` Mario.Limonciello
  2019-04-03 22:03     ` Darren Hart
  0 siblings, 1 reply; 4+ messages in thread
From: Mario.Limonciello @ 2019-04-03 21:54 UTC (permalink / raw)
  To: dvhart; +Cc: andy.shevchenko, linux-kernel, platform-driver-x86

> -----Original Message-----
> From: Darren Hart <dvhart@infradead.org>
> Sent: Wednesday, April 3, 2019 3:24 PM
> To: Limonciello, Mario
> Cc: Andy Shevchenko; LKML; platform-driver-x86@vger.kernel.org
> Subject: Re: [PATCH] platform/x86: dell-laptop: fix rfkill functionality
> 
> 
> [EXTERNAL EMAIL]
> 
> On Wed, Mar 27, 2019 at 09:25:34AM -0500, Mario Limonciello wrote:
> > When converting the driver two arguments were transposed leading
> > to rfkill not working.
> >
> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427
> > Reported-by: Pepijn de Vos <pepijndevos@gmail.com>
> > Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls")
> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > Acked-by: Pali Rohár <pali.rohar@gmail.com>
> 
> Looks like this broken in 4.14? So Cc stable back to then? I'm surprised it's
> been broken that long :-(
> 

Not many "newer" platforms actually use this radio control anymore.  It's been
superseded by other technologies.  So I think that would be the main reason.

Can you CC it to stable when it's committed or do I need to re-send or anything?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86: dell-laptop: fix rfkill functionality
  2019-04-03 21:54   ` Mario.Limonciello
@ 2019-04-03 22:03     ` Darren Hart
  0 siblings, 0 replies; 4+ messages in thread
From: Darren Hart @ 2019-04-03 22:03 UTC (permalink / raw)
  To: Mario.Limonciello; +Cc: andy.shevchenko, linux-kernel, platform-driver-x86

On Wed, Apr 03, 2019 at 09:54:27PM +0000, Mario.Limonciello@dell.com wrote:
> > -----Original Message-----
> > From: Darren Hart <dvhart@infradead.org>
> > Sent: Wednesday, April 3, 2019 3:24 PM
> > To: Limonciello, Mario
> > Cc: Andy Shevchenko; LKML; platform-driver-x86@vger.kernel.org
> > Subject: Re: [PATCH] platform/x86: dell-laptop: fix rfkill functionality
> > 
> > 
> > [EXTERNAL EMAIL]
> > 
> > On Wed, Mar 27, 2019 at 09:25:34AM -0500, Mario Limonciello wrote:
> > > When converting the driver two arguments were transposed leading
> > > to rfkill not working.
> > >
> > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427
> > > Reported-by: Pepijn de Vos <pepijndevos@gmail.com>
> > > Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls")
> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > > Acked-by: Pali Rohár <pali.rohar@gmail.com>
> > 
> > Looks like this broken in 4.14? So Cc stable back to then? I'm surprised it's
> > been broken that long :-(
> > 
> 
> Not many "newer" platforms actually use this radio control anymore.  It's been
> superseded by other technologies.  So I think that would be the main reason.
> 
> Can you CC it to stable when it's committed or do I need to re-send or anything?
> 

I will add the Cc to stable. Just wanted to confirm our expectations were
aligned.

-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-27 14:25 [PATCH] platform/x86: dell-laptop: fix rfkill functionality Mario Limonciello
2019-04-03 20:23 ` Darren Hart
2019-04-03 21:54   ` Mario.Limonciello
2019-04-03 22:03     ` Darren Hart

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git