From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7DC2C43381 for ; Fri, 29 Mar 2019 07:29:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 975C12082F for ; Fri, 29 Mar 2019 07:29:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="x0unXnVM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728922AbfC2H3k (ORCPT ); Fri, 29 Mar 2019 03:29:40 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:64928 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728864AbfC2H3j (ORCPT ); Fri, 29 Mar 2019 03:29:39 -0400 Received: from grover.tkatk1.zaq.ne.jp (zaqdadce369.zaq.ne.jp [218.220.227.105]) (authenticated) by conuserg-10.nifty.com with ESMTP id x2T7SQaD002537; Fri, 29 Mar 2019 16:28:32 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com x2T7SQaD002537 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1553844513; bh=BRBvSJ4W65C/fPjveY5umdo5eBXm18HEgOWm+EkOD7U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x0unXnVMr9Cy58s7P8cByEoY3byAv10ixm490Y5dvO8ih/ozmRirL2QF/oTQKM5Ms yiCyTKLBwt/RgaUPrYJbyogiPfd8lmHNEkRwN7CvJydf6hyNFRBgT7jcY7K6Nc7kQk 47wf+GJvPnqrJrqM8wlxKtC+Q18rZOkRgsUevqS3TOr2o6ydUcPzNlEv8qvKwsbrYK 7KlR9PKmn4i5NDFz9YzMD6blb6XuXAgqRIOe+CVrsuSYGQOu0c0IQ9+e0Qr9/i/uYj QNEFIucpBCTBPaQqkVV3IGI3z5kBGebdzMowmlensaxkH6+bt12ewPUz2onM+Pa/gy mO+RBY/fgEPoA== X-Nifty-SrcIP: [218.220.227.105] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Miquel Raynal Cc: Masahiro Yamada , Brian Norris , linux-kernel@vger.kernel.org, Marek Vasut , Richard Weinberger , David Woodhouse , Boris Brezillon Subject: [PATCH v4 6/9] mtd: rawnand: denali_pci: rename goto labels Date: Fri, 29 Mar 2019 16:28:18 +0900 Message-Id: <1553844501-7119-7-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1553844501-7119-1-git-send-email-yamada.masahiro@socionext.com> References: <1553844501-7119-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As Documentation/process/coding-style.rst says, choose label names which say what the goto does. The out_ label style is already used in denali_dt.c. Rename likewise for denali_pci.c Signed-off-by: Masahiro Yamada --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/mtd/nand/raw/denali_pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/denali_pci.c b/drivers/mtd/nand/raw/denali_pci.c index 48e9ac5..02eb599 100644 --- a/drivers/mtd/nand/raw/denali_pci.c +++ b/drivers/mtd/nand/raw/denali_pci.c @@ -84,20 +84,20 @@ static int denali_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) if (!denali->host) { dev_err(&dev->dev, "Spectra: ioremap_nocache failed!"); ret = -ENOMEM; - goto failed_remap_reg; + goto out_unmap_reg; } ret = denali_init(denali); if (ret) - goto failed_remap_mem; + goto out_unmap_host; pci_set_drvdata(dev, denali); return 0; -failed_remap_mem: +out_unmap_host: iounmap(denali->host); -failed_remap_reg: +out_unmap_reg: iounmap(denali->reg); return ret; } -- 2.7.4