From: Stefan Wahren <stefan.wahren@i2se.com>
To: Kamil Debski <kamil@wypas.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stefan Wahren <stefan.wahren@i2se.com>
Subject: [PATCH V4 0/3] hwmon: pwm-fan: Add RPM support
Date: Tue, 2 Apr 2019 16:21:47 +0200 [thread overview]
Message-ID: <1554214910-29925-1-git-send-email-stefan.wahren@i2se.com> (raw)
Contrary to the gpio-fan the pwm-fan driver isn't easy to setup
with pwmconfig/fancontrol because of the missing hwmon sysfs entry
for actual revolutions per minute. This series adds this feature.
Changes in V4:
- remove copy & paste artifact in dt-binding example
- switch to u64 for rpm calculation
- drop overflow handling and init atomic
- handle 0 not as valid irq
- reduce range of pulses_per_revolution
- handle probe defer of platform_get_irq
- delete timer properly in bail-out path
Changes in V3:
- rename property interrupt-ratio to pulses-per-revolution
to avoid confusion with interrupt binding
- handle error case pulses-per-revolution = 0
- bail out properly in case we are unable to request the irq
Changes in V2:
- address Guenter's comments:
- improve description of interrupts
- use atomic_t to avoid races of the pulse counter
- measure sample time to make rpm more reliable under load
- make sysfs entry fan1_input conditional
- add dt-property to define interrupts per fan revolution
- example for fan with RPM support
Stefan Wahren (3):
dt-bindings: hwmon: Add tachometer interrupt to pwm-fan
Documentation: pwm-fan: Add description for RPM support
hwmon: pwm-fan: Add RPM support via external interrupt
.../devicetree/bindings/hwmon/pwm-fan.txt | 21 +++-
Documentation/hwmon/pwm-fan | 3 +
drivers/hwmon/pwm-fan.c | 111 ++++++++++++++++++++-
3 files changed, 130 insertions(+), 5 deletions(-)
--
2.7.4
next reply other threads:[~2019-04-02 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 14:21 Stefan Wahren [this message]
2019-04-02 14:21 ` [PATCH V4 1/3] dt-bindings: hwmon: Add tachometer interrupt to pwm-fan Stefan Wahren
2019-04-02 14:21 ` [PATCH V4 2/3] Documentation: pwm-fan: Add description for RPM support Stefan Wahren
2019-04-02 14:21 ` [PATCH V4 3/3] hwmon: pwm-fan: Add RPM support via external interrupt Stefan Wahren
2019-04-02 20:55 ` Guenter Roeck
2019-04-03 9:55 ` Stefan Wahren
2019-04-03 15:59 ` Robin Murphy
2019-04-03 16:11 ` Guenter Roeck
2019-04-03 16:23 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554214910-29925-1-git-send-email-stefan.wahren@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kamil@wypas.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).