* [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG
@ 2019-04-06 16:00 Markus Kueffner
2019-04-11 6:54 ` Shawn Guo
0 siblings, 1 reply; 7+ messages in thread
From: Markus Kueffner @ 2019-04-06 16:00 UTC (permalink / raw)
Cc: Markus Kueffner, Rob Herring, Mark Rutland, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel
Add Pincfgs to enable the i.MX6's OTG feature for UDOO
Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>
---
arch/arm/boot/dts/imx6qdl-udoo.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
index 776bfc7..42954ee 100644
--- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
@@ -221,6 +221,14 @@
>;
};
+ pinctrl_usbotg: usbotg {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
+ MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x17059
+ MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x17059
+ >;
+ };
+
pinctrl_ac97_running: ac97running {
fsl,pins = <
MX6QDL_PAD_DI0_PIN2__AUD6_TXD 0x1b0b0
@@ -294,6 +302,14 @@
status = "okay";
};
+&usbotg {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbotg>;
+ fsl,power-line-polarity-active-high;
+ fsl,over-current-polarity-active-low;
+ status = "okay";
+};
+
&audmux {
status = "okay";
};
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG
2019-04-06 16:00 [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG Markus Kueffner
@ 2019-04-11 6:54 ` Shawn Guo
2019-04-13 13:19 ` [PATCH v2] " Markus Kueffner
0 siblings, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2019-04-11 6:54 UTC (permalink / raw)
To: Markus Kueffner
Cc: Rob Herring, Mark Rutland, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, devicetree, linux-arm-kernel,
linux-kernel
On Sat, Apr 06, 2019 at 06:00:20PM +0200, Markus Kueffner wrote:
> Add Pincfgs to enable the i.MX6's OTG feature for UDOO
>
> Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>
> ---
> arch/arm/boot/dts/imx6qdl-udoo.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> index 776bfc7..42954ee 100644
> --- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
> @@ -221,6 +221,14 @@
> >;
> };
>
> + pinctrl_usbotg: usbotg {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
> + MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x17059
> + MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x17059
> + >;
> + };
> +
I know ac97 is out of order, but I still would like to keep pinctrl
nodes sort alphabetically. That said, pinctrl_usbotg should go after
pinctrl_usbh.
> pinctrl_ac97_running: ac97running {
> fsl,pins = <
> MX6QDL_PAD_DI0_PIN2__AUD6_TXD 0x1b0b0
> @@ -294,6 +302,14 @@
> status = "okay";
> };
>
> +&usbotg {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usbotg>;
> + fsl,power-line-polarity-active-high;
> + fsl,over-current-polarity-active-low;
Are these two properties supported by upstream bindings and driver?
Shawn
> + status = "okay";
> +};
> +
> &audmux {
> status = "okay";
> };
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG
2019-04-11 6:54 ` Shawn Guo
@ 2019-04-13 13:19 ` Markus Kueffner
2019-04-13 14:08 ` Fabio Estevam
2019-04-15 9:11 ` Shawn Guo
0 siblings, 2 replies; 7+ messages in thread
From: Markus Kueffner @ 2019-04-13 13:19 UTC (permalink / raw)
Cc: Markus Kueffner, Rob Herring, Mark Rutland, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel
Add Pincfgs to enable the i.MX6's OTG feature for UDOO
Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>
---
Changes in v2:
- put pinctrl_usbotg node after pinctrl_usbh as suggested
- remove unsupported properties from &usbotg
arch/arm/boot/dts/imx6qdl-udoo.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
index 776bfc7..828dd20 100644
--- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
@@ -210,6 +210,14 @@
>;
};
+ pinctrl_usbotg: usbotg {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x17059
+ MX6QDL_PAD_EIM_D22__USB_OTG_PWR 0x17059
+ MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x17059
+ >;
+ };
+
pinctrl_usdhc3: usdhc3grp {
fsl,pins = <
MX6QDL_PAD_SD3_CMD__SD3_CMD 0x17059
@@ -287,6 +295,12 @@
status = "okay";
};
+&usbotg {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbotg>;
+ status = "okay";
+};
+
&usdhc3 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usdhc3>;
--
2.1.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG
2019-04-13 13:19 ` [PATCH v2] " Markus Kueffner
@ 2019-04-13 14:08 ` Fabio Estevam
2019-04-15 9:11 ` Shawn Guo
1 sibling, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2019-04-13 14:08 UTC (permalink / raw)
To: Markus Kueffner
Cc: Rob Herring, Mark Rutland, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, NXP Linux Team,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel
On Sat, Apr 13, 2019 at 10:20 AM Markus Kueffner
<kueffner.markus@gmail.com> wrote:
>
> Add Pincfgs to enable the i.MX6's OTG feature for UDOO
>
> Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG
2019-04-13 13:19 ` [PATCH v2] " Markus Kueffner
2019-04-13 14:08 ` Fabio Estevam
@ 2019-04-15 9:11 ` Shawn Guo
2019-09-16 13:06 ` Markus Kueffner
1 sibling, 1 reply; 7+ messages in thread
From: Shawn Guo @ 2019-04-15 9:11 UTC (permalink / raw)
To: Markus Kueffner
Cc: Rob Herring, Mark Rutland, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, devicetree, linux-arm-kernel,
linux-kernel
On Sat, Apr 13, 2019 at 03:19:36PM +0200, Markus Kueffner wrote:
> Add Pincfgs to enable the i.MX6's OTG feature for UDOO
>
> Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG
2019-04-15 9:11 ` Shawn Guo
@ 2019-09-16 13:06 ` Markus Kueffner
2019-09-24 23:09 ` Shawn Guo
0 siblings, 1 reply; 7+ messages in thread
From: Markus Kueffner @ 2019-09-16 13:06 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Mark Rutland, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, devicetree, linux-arm-kernel,
linux-kernel
On Mon, Apr 15, 2019 at 05:11:51PM +0800, Shawn Guo wrote:
> On Sat, Apr 13, 2019 at 03:19:36PM +0200, Markus Kueffner wrote:
> > Add Pincfgs to enable the i.MX6's OTG feature for UDOO
> >
> > Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>
>
> Applied, thanks.
Hello,
I was wondering when this might get merged into a release.
Is there anything else I need to fix?
Best Regards,
Markus
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG
2019-09-16 13:06 ` Markus Kueffner
@ 2019-09-24 23:09 ` Shawn Guo
0 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2019-09-24 23:09 UTC (permalink / raw)
To: Markus Kueffner
Cc: Rob Herring, Mark Rutland, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, devicetree, linux-arm-kernel,
linux-kernel
On Mon, Sep 16, 2019 at 01:06:04PM +0000, Markus Kueffner wrote:
> On Mon, Apr 15, 2019 at 05:11:51PM +0800, Shawn Guo wrote:
> > On Sat, Apr 13, 2019 at 03:19:36PM +0200, Markus Kueffner wrote:
> > > Add Pincfgs to enable the i.MX6's OTG feature for UDOO
> > >
> > > Signed-off-by: Markus Kueffner <kueffner.markus@gmail.com>
> >
> > Applied, thanks.
>
> Hello,
>
> I was wondering when this might get merged into a release.
> Is there anything else I need to fix?
I'm sorry, Markus. There was something wrong on my side, and the patch
did not really get applied for 5.4. I just fixed it for the next
release. Sorry about that!
Shawn
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-09-24 23:09 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-06 16:00 [PATCH] ARM: dts: imx6qdl-udoo: Add Pincfgs for OTG Markus Kueffner
2019-04-11 6:54 ` Shawn Guo
2019-04-13 13:19 ` [PATCH v2] " Markus Kueffner
2019-04-13 14:08 ` Fabio Estevam
2019-04-15 9:11 ` Shawn Guo
2019-09-16 13:06 ` Markus Kueffner
2019-09-24 23:09 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).