From: Nicholas Mc Guire <hofrat@opentech.at>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Nicholas Mc Guire <hofrat@opentech.at>
Subject: [PATCH 2/3] media: smiapp: regs: add range to usleep_range
Date: Sun, 7 Apr 2019 04:16:03 +0200 [thread overview]
Message-ID: <1554603364-10500-2-git-send-email-hofrat@opentech.at> (raw)
In-Reply-To: <1554603364-10500-1-git-send-email-hofrat@opentech.at>
As this is a retry loop for a sender not responding there is no reason
to mandate a high accuracy delay - extend the sleep range to 2-4ms
so that the hrtimer subsystem can work efficiently.
Signed-off-by: Nicholas Mc Guire <hofrat@opentech.at>
---
Problem located by an experimental coccinelle script
Patch was compile tested with: x86_64_defconfig + MEDIA_SUPPORT=m,
MEDIA_CAMERA_SUPPORT=y, MEDIA_CONTROLLER=y, VIDEO_V4L2_SUBDEV_API=y,
VIDEO_SMIAPP=m
Patch is against 5.1-rc3 (localversion-next is next-20190405)
drivers/media/i2c/smiapp/smiapp-regs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-regs.c b/drivers/media/i2c/smiapp/smiapp-regs.c
index 145653d..dfa4f99 100644
--- a/drivers/media/i2c/smiapp/smiapp-regs.c
+++ b/drivers/media/i2c/smiapp/smiapp-regs.c
@@ -276,7 +276,7 @@ int smiapp_write_no_quirk(struct smiapp_sensor *sensor, u32 reg, u32 val)
return 0;
}
- usleep_range(2000, 2000);
+ usleep_range(2000, 4000);
}
dev_err(&client->dev,
--
2.1.4
next prev parent reply other threads:[~2019-04-07 3:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-07 2:16 [PATCH 1/3] media: smiapp: core: add range to usleep_range Nicholas Mc Guire
2019-04-07 2:16 ` Nicholas Mc Guire [this message]
2019-04-07 2:16 ` [PATCH 3/3] media: smiapp: quirk: " Nicholas Mc Guire
2019-04-30 13:49 ` [PATCH 1/3] media: smiapp: core: " Sakari Ailus
2019-05-04 9:46 ` Nicholas Mc Guire
2019-05-07 21:04 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554603364-10500-2-git-send-email-hofrat@opentech.at \
--to=hofrat@opentech.at \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).