From: Paul Cercueil <paul@crapouillou.net>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
od@zcrc.me, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 3/5] media: uapi: Add RGB bus formats for the GiantPlus GPM940B0 panel
Date: Mon, 08 Apr 2019 12:40:34 +0200 [thread overview]
Message-ID: <1554720034.1893.1@crapouillou.net> (raw)
In-Reply-To: <20190403163259.GS5238@ulmo>
Hi Thierry,
Le mer. 3 avril 2019 à 18:32, Thierry Reding
<thierry.reding@gmail.com> a écrit :
> On Thu, Mar 14, 2019 at 01:26:20PM +0100, Paul Cercueil wrote:
>> The GiantPlus GPM940B0 is a 24-bit TFT panel where the RGB
>> components
>> are transferred sequentially on a 8-bit bus.
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> ---
>>
>> Notes:
>> v2: New patch
>>
>> include/uapi/linux/media-bus-format.h | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Please make sure you Cc the media maintainers on this one when you
> send
> the next version. Adding them now.
Oops. Will do.
>>
>> diff --git a/include/uapi/linux/media-bus-format.h
>> b/include/uapi/linux/media-bus-format.h
>> index d6a5a3bfe6c4..f31724d6cd40 100644
>> --- a/include/uapi/linux/media-bus-format.h
>> +++ b/include/uapi/linux/media-bus-format.h
>> @@ -34,7 +34,7 @@
>>
>> #define MEDIA_BUS_FMT_FIXED 0x0001
>>
>> -/* RGB - next is 0x101b */
>> +/* RGB - next is 0x101d */
>> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016
>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
>> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
>> @@ -54,6 +54,8 @@
>> #define MEDIA_BUS_FMT_RGB888_1X24 0x100a
>> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
>> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
>> +#define MEDIA_BUS_FMT_RGB888_3X8_BE 0x101b
>> +#define MEDIA_BUS_FMT_RGB888_3X8_LE 0x101c
>
> The list looks roughly sorted, but these are not. That said, there are
> others that don't seem like they are sorted either.
To me it looks like it's sorted alphabetically, that's why I
put the two new macros there.
> All the more important to get feedback from the media maintainers.
>
> Thierry
next prev parent reply other threads:[~2019-04-08 10:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 12:26 [PATCH v2 1/5] dt-bindings: display: Add Sharp LS020B1DD01D panel documentation Paul Cercueil
2019-03-14 12:26 ` [PATCH v2 2/5] dt-bindings: display: Add GiantPlus GPM940B0 " Paul Cercueil
2019-03-28 15:39 ` Rob Herring
2019-03-14 12:26 ` [PATCH v2 3/5] media: uapi: Add RGB bus formats for the GiantPlus GPM940B0 panel Paul Cercueil
2019-04-03 16:32 ` Thierry Reding
2019-04-08 10:40 ` Paul Cercueil [this message]
2019-03-14 12:26 ` [PATCH v2 4/5] drm/panel: simple: Add Sharp LS020B1DD01D panel support Paul Cercueil
2019-03-14 12:26 ` [PATCH v2 5/5] drm/panel: simple: Add GiantPlus GPM940B0 " Paul Cercueil
2019-03-28 15:39 ` [PATCH v2 1/5] dt-bindings: display: Add Sharp LS020B1DD01D panel documentation Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554720034.1893.1@crapouillou.net \
--to=paul@crapouillou.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=od@zcrc.me \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).