* [PATCH] HID: rmi: fix devm_add_action_or_reset() parameter
@ 2019-04-12 12:54 Fabien Dessenne
2019-05-03 12:19 ` Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: Fabien Dessenne @ 2019-04-12 12:54 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, linux-input, linux-kernel
Cc: Fabien Dessenne
The second parameter of devm_add_action_or_reset() shall be a function,
not a function address.
Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
---
drivers/hid/hid-rmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 9e33165..8748d4d 100644
--- a/drivers/hid/hid-rmi.c
+++ b/drivers/hid/hid-rmi.c
@@ -623,7 +623,7 @@ static int rmi_setup_irq_domain(struct hid_device *hdev)
if (!hdata->domain)
return -ENOMEM;
- ret = devm_add_action_or_reset(&hdev->dev, &rmi_irq_teardown, hdata);
+ ret = devm_add_action_or_reset(&hdev->dev, rmi_irq_teardown, hdata);
if (ret)
return ret;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: rmi: fix devm_add_action_or_reset() parameter
2019-04-12 12:54 [PATCH] HID: rmi: fix devm_add_action_or_reset() parameter Fabien Dessenne
@ 2019-05-03 12:19 ` Jiri Kosina
2019-05-03 12:38 ` Fabien DESSENNE
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Kosina @ 2019-05-03 12:19 UTC (permalink / raw)
To: Fabien Dessenne; +Cc: Benjamin Tissoires, linux-input, linux-kernel
On Fri, 12 Apr 2019, Fabien Dessenne wrote:
> The second parameter of devm_add_action_or_reset() shall be a function,
> not a function address.
>
> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
> ---
> drivers/hid/hid-rmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
> index 9e33165..8748d4d 100644
> --- a/drivers/hid/hid-rmi.c
> +++ b/drivers/hid/hid-rmi.c
> @@ -623,7 +623,7 @@ static int rmi_setup_irq_domain(struct hid_device *hdev)
> if (!hdata->domain)
> return -ENOMEM;
>
> - ret = devm_add_action_or_reset(&hdev->dev, &rmi_irq_teardown, hdata);
> + ret = devm_add_action_or_reset(&hdev->dev, rmi_irq_teardown, hdata);
Why do you think this is wrong C?
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: rmi: fix devm_add_action_or_reset() parameter
2019-05-03 12:19 ` Jiri Kosina
@ 2019-05-03 12:38 ` Fabien DESSENNE
2019-05-03 12:42 ` Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: Fabien DESSENNE @ 2019-05-03 12:38 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Benjamin Tissoires, linux-input, linux-kernel
On 03/05/2019 2:19 PM, Jiri Kosina wrote:
> On Fri, 12 Apr 2019, Fabien Dessenne wrote:
>
>> The second parameter of devm_add_action_or_reset() shall be a function,
>> not a function address.
>>
>> Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
>> ---
>> drivers/hid/hid-rmi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
>> index 9e33165..8748d4d 100644
>> --- a/drivers/hid/hid-rmi.c
>> +++ b/drivers/hid/hid-rmi.c
>> @@ -623,7 +623,7 @@ static int rmi_setup_irq_domain(struct hid_device *hdev)
>> if (!hdata->domain)
>> return -ENOMEM;
>>
>> - ret = devm_add_action_or_reset(&hdev->dev, &rmi_irq_teardown, hdata);
>> + ret = devm_add_action_or_reset(&hdev->dev, rmi_irq_teardown, hdata);
> Why do you think this is wrong C?
Because I was not aware that both func and &func refer to the same
function pointer.
Now I know :)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: rmi: fix devm_add_action_or_reset() parameter
2019-05-03 12:38 ` Fabien DESSENNE
@ 2019-05-03 12:42 ` Jiri Kosina
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2019-05-03 12:42 UTC (permalink / raw)
To: Fabien DESSENNE; +Cc: Benjamin Tissoires, linux-input, linux-kernel
On Fri, 3 May 2019, Fabien DESSENNE wrote:
> >> - ret = devm_add_action_or_reset(&hdev->dev, &rmi_irq_teardown, hdata);
> >> + ret = devm_add_action_or_reset(&hdev->dev, rmi_irq_teardown, hdata);
> > Why do you think this is wrong C?
>
> Because I was not aware that both func and &func refer to the same
> function pointer.
>
> Now I know :)
Yup, it's defined in 6.3.2.1.4 in C99.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-03 12:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-12 12:54 [PATCH] HID: rmi: fix devm_add_action_or_reset() parameter Fabien Dessenne
2019-05-03 12:19 ` Jiri Kosina
2019-05-03 12:38 ` Fabien DESSENNE
2019-05-03 12:42 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).