From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [v2 PATCH 1/6] usb: xhci-mtk: get optional clock by devm_clk_get_optional()
Date: Wed, 17 Apr 2019 13:53:57 +0800 [thread overview]
Message-ID: <1555480437.10179.203.camel@mhfsdcap03> (raw)
In-Reply-To: <20190416101506.GB26091@kroah.com>
On Tue, 2019-04-16 at 12:15 +0200, Greg Kroah-Hartman wrote:
> On Wed, Apr 10, 2019 at 02:47:24PM +0800, Chunfeng Yun wrote:
> > Use devm_clk_get_optional() to get optional clock
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v2: no changes
> > ---
> > drivers/usb/host/xhci-mtk.c | 19 +++----------------
> > 1 file changed, 3 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> > index 60987c787e44..026fe18972d3 100644
> > --- a/drivers/usb/host/xhci-mtk.c
> > +++ b/drivers/usb/host/xhci-mtk.c
> > @@ -206,19 +206,6 @@ static int xhci_mtk_ssusb_config(struct xhci_hcd_mtk *mtk)
> > return xhci_mtk_host_enable(mtk);
> > }
> >
> > -/* ignore the error if the clock does not exist */
> > -static struct clk *optional_clk_get(struct device *dev, const char *id)
> > -{
> > - struct clk *opt_clk;
> > -
> > - opt_clk = devm_clk_get(dev, id);
> > - /* ignore error number except EPROBE_DEFER */
> > - if (IS_ERR(opt_clk) && (PTR_ERR(opt_clk) != -EPROBE_DEFER))
> > - opt_clk = NULL;
> > -
> > - return opt_clk;
> > -}
> > -
> > static int xhci_mtk_clks_get(struct xhci_hcd_mtk *mtk)
> > {
> > struct device *dev = mtk->dev;
> > @@ -229,15 +216,15 @@ static int xhci_mtk_clks_get(struct xhci_hcd_mtk *mtk)
> > return PTR_ERR(mtk->sys_clk);
> > }
> >
> > - mtk->ref_clk = optional_clk_get(dev, "ref_ck");
> > + mtk->ref_clk = devm_clk_get_optional(dev, "ref_ck");
> > if (IS_ERR(mtk->ref_clk))
> > return PTR_ERR(mtk->ref_clk);
> >
> > - mtk->mcu_clk = optional_clk_get(dev, "mcu_ck");
> > + mtk->mcu_clk = devm_clk_get_optional(dev, "mcu_ck");
> > if (IS_ERR(mtk->mcu_clk))
> > return PTR_ERR(mtk->mcu_clk);
> >
> > - mtk->dma_clk = optional_clk_get(dev, "dma_ck");
> > + mtk->dma_clk = devm_clk_get_optional(dev, "dma_ck");
>
> Also, now that this clock (and the others here) are controlled by the
> devm infrastructure, do you have to change when you were cleaning up and
> stopping the clock?
No need, optional_clk_get() uses devm_clk_get() to get clock
Thanks
> That logic seems to be the same here, which does
> not seem to be correct to me.
>
> Please also document that in your changelog comments when resending this
> series, as all of these patches have this issue as well.
>
> thanks,
>
> greg k-h
prev parent reply other threads:[~2019-04-17 5:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 6:47 [v2 PATCH 1/6] usb: xhci-mtk: get optional clock by devm_clk_get_optional() Chunfeng Yun
2019-04-10 6:47 ` [v2 PATCH 2/6] usb: host: xhci-plat: " Chunfeng Yun
2019-04-10 6:47 ` [v2 PATCH 3/6] usb: misc: usb3503: " Chunfeng Yun
2019-04-10 6:47 ` [v2 PATCH 4/6] usb: dwc2: " Chunfeng Yun
2019-04-10 6:47 ` [v2 PATCH 5/6] usb: chipidea: msm: " Chunfeng Yun
2019-04-10 6:47 ` [v2 PATCH 6/6] usb: mtu3: " Chunfeng Yun
2019-04-12 19:06 ` Matthias Brugger
2019-04-16 10:12 ` [v2 PATCH 1/6] usb: xhci-mtk: " Greg Kroah-Hartman
2019-04-17 5:53 ` Chunfeng Yun
2019-04-16 10:15 ` Greg Kroah-Hartman
2019-04-17 5:53 ` Chunfeng Yun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555480437.10179.203.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).