From: Pan Bian <bianpan2016@163.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Pan Bian <bianpan2016@163.com>
Subject: iommu/vt-d: drop mm use count if address is not canonical
Date: Wed, 17 Apr 2019 17:12:57 +0800 [thread overview]
Message-ID: <1555492377-79859-1-git-send-email-bianpan2016@163.com> (raw)
The use count of svm->mm is incremented by mmget_not_zero. However, it
is not dropped when the address is not canonical. This patch fixes the
bug.
Fixes: 9d8c3af31607("iommu/vt-d: IOMMU Page Request needs to check if
address is canonical.")
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/iommu/intel-svm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c
index 3a4b09a..2630d2e 100644
--- a/drivers/iommu/intel-svm.c
+++ b/drivers/iommu/intel-svm.c
@@ -574,8 +574,10 @@ static irqreturn_t prq_event_thread(int irq, void *d)
goto bad_req;
/* If address is not canonical, return invalid response */
- if (!is_canonical_address(address))
+ if (!is_canonical_address(address)) {
+ mmput(svm->mm);
goto bad_req;
+ }
down_read(&svm->mm->mmap_sem);
vma = find_extend_vma(svm->mm, address);
--
2.7.4
next reply other threads:[~2019-04-17 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 9:12 Pan Bian [this message]
2019-04-26 13:38 ` iommu/vt-d: drop mm use count if address is not canonical Joerg Roedel
2019-04-26 15:47 ` Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555492377-79859-1-git-send-email-bianpan2016@163.com \
--to=bianpan2016@163.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).