From: Stephen Boyd <sboyd@kernel.org>
To: "kernelci.org bot" <bot@kernelci.org>,
Jeffrey Hugo <jhugo@codeaurora.org>,
broonie@kernel.org, enric.balletbo@collabora.com,
guillaume.tucker@collabora.com, khilman@baylibre.com,
matthew.hart@linaro.org, mgalka@collabora.com,
tomeu.vizoso@collabora.com
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: clk/clk-next boot bisection: v5.1-rc1-142-ga55b079c961b on panda
Date: Mon, 22 Apr 2019 18:06:38 -0700 [thread overview]
Message-ID: <155598159898.15276.8408514960097680895@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <5cbe596c.1c69fb81.e252.b9d0@mx.google.com>
Quoting kernelci.org bot (2019-04-22 17:16:44)
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
> * This automated bisection report was sent to you on the basis *
> * that you may be involved with the breaking commit it has *
> * found. No manual investigation has been done to verify it, *
> * and the root cause of the problem may be somewhere else. *
> * Hope this helps! *
> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
>
> clk/clk-next boot bisection: v5.1-rc1-142-ga55b079c961b on panda
>
> Summary:
> Start: a55b079c961b Merge branch 'clk-hisi' into clk-next
> Details: https://kernelci.org/boot/id/5cbe3cdb59b514fd22fe6025
> Plain log: https://storage.kernelci.org//clk/clk-next/v5.1-rc1-142-ga55b079c961b/arm/omap2plus_defconfig/gcc-7/lab-baylibre/boot-omap4-panda.txt
> HTML log: https://storage.kernelci.org//clk/clk-next/v5.1-rc1-142-ga55b079c961b/arm/omap2plus_defconfig/gcc-7/lab-baylibre/boot-omap4-panda.html
> Result: ecbf3f1795fd clk: fixed-factor: Let clk framework find parent
>
> Checks:
> revert: PASS
> verify: PASS
>
> Parameters:
> Tree: clk
> URL: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git
> Branch: clk-next
> Target: panda
> CPU arch: arm
> Lab: lab-baylibre
> Compiler: gcc-7
> Config: omap2plus_defconfig
> Test suite: boot
>
> Breaking commit found:
Awesome! I LOVE IT!!!
>
> diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
> index 241b3f8c61a9..5b09f2cdb7de 100644
> --- a/drivers/clk/clk-fixed-factor.c
> +++ b/drivers/clk/clk-fixed-factor.c
> @@ -64,12 +64,14 @@ const struct clk_ops clk_fixed_factor_ops = {
> };
> EXPORT_SYMBOL_GPL(clk_fixed_factor_ops);
>
> -struct clk_hw *clk_hw_register_fixed_factor(struct device *dev,
> - const char *name, const char *parent_name, unsigned long flags,
> - unsigned int mult, unsigned int div)
> +static struct clk_hw *
> +__clk_hw_register_fixed_factor(struct device *dev, struct device_node *np,
> + const char *name, const char *parent_name, int index,
> + unsigned long flags, unsigned int mult, unsigned int div)
> {
> struct clk_fixed_factor *fix;
> struct clk_init_data init;
> + struct clk_parent_data pdata = { .index = index };
> struct clk_hw *hw;
> int ret;
>
> @@ -85,11 +87,17 @@ struct clk_hw *clk_hw_register_fixed_factor(struct device *dev,
> init.name = name;
> init.ops = &clk_fixed_factor_ops;
> init.flags = flags | CLK_IS_BASIC;
> - init.parent_names = &parent_name;
> + if (parent_name)
> + init.parent_names = &parent_name;
> + else
> + init.parent_data = &pdata;
Ick. I realized that 'init.parent_names' here can be full of junk! Let's
initialize it properly. Maybe that makes this all better?
----8<----
diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
index 5b09f2cdb7de..2d988a7585d5 100644
--- a/drivers/clk/clk-fixed-factor.c
+++ b/drivers/clk/clk-fixed-factor.c
@@ -70,7 +70,7 @@ __clk_hw_register_fixed_factor(struct device *dev, struct device_node *np,
unsigned long flags, unsigned int mult, unsigned int div)
{
struct clk_fixed_factor *fix;
- struct clk_init_data init;
+ struct clk_init_data init = { };
struct clk_parent_data pdata = { .index = index };
struct clk_hw *hw;
int ret;
next prev parent reply other threads:[~2019-04-23 1:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 0:16 clk/clk-next boot bisection: v5.1-rc1-142-ga55b079c961b on panda kernelci.org bot
2019-04-23 1:06 ` Stephen Boyd [this message]
2019-04-23 11:54 ` Geert Uytterhoeven
2019-04-23 14:40 ` Tony Lindgren
2019-04-25 17:28 ` Mark Brown
2019-04-25 17:44 ` Guillaume Tucker
2019-04-25 18:17 ` Mark Brown
2019-04-25 19:28 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155598159898.15276.8408514960097680895@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=bot@kernelci.org \
--cc=broonie@kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=guillaume.tucker@collabora.com \
--cc=jhugo@codeaurora.org \
--cc=khilman@baylibre.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.hart@linaro.org \
--cc=mgalka@collabora.com \
--cc=mturquette@baylibre.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).