From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Sirio Balmelli <sirio@b-ad.ch>, Song Liu <songliubraving@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
netdev@vger.kernel.org, Yonghong Song <yhs@fb.com>,
Taeung Song <treeze.taeung@gmail.com>,
linux-kernel@vger.kernel.org,
Jakub Kicinski <jakub.kicinski@netronome.com>,
Martin KaFai Lau <kafai@fb.com>,
bpf@vger.kernel.org
Subject: [PATCH] bpftool: exclude bash-completion/bpftool from .gitignore pattern
Date: Mon, 29 Apr 2019 23:47:39 +0900 [thread overview]
Message-ID: <1556549259-16298-1-git-send-email-yamada.masahiro@socionext.com> (raw)
tools/bpf/bpftool/.gitignore has the "bpftool" pattern, which is
intended to ignore the following build artifact:
tools/bpf/bpftool/bpftool
However, the .gitignore entry is effective not only for the current
directory, but also for any sub-directories.
So, the following file is also considered to be ignored:
tools/bpf/bpftool/bash-completion/bpftool
It is obviously version-controlled, so should be excluded from the
.gitignore pattern.
You can fix it by prefixing the pattern with '/', which means it is
only effective in the current directory.
I prefixed the other patterns consistently. IMHO, '/' prefixing is
safer when you intend to ignore specific files.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
tools/bpf/bpftool/.gitignore | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/bpf/bpftool/.gitignore b/tools/bpf/bpftool/.gitignore
index 67167e4..19efcc8 100644
--- a/tools/bpf/bpftool/.gitignore
+++ b/tools/bpf/bpftool/.gitignore
@@ -1,5 +1,5 @@
*.d
-bpftool
-bpftool*.8
-bpf-helpers.*
-FEATURE-DUMP.bpftool
+/bpftool
+/bpftool*.8
+/bpf-helpers.*
+/FEATURE-DUMP.bpftool
--
2.7.4
next reply other threads:[~2019-04-29 14:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 14:47 Masahiro Yamada [this message]
2019-04-29 15:32 ` [PATCH] bpftool: exclude bash-completion/bpftool from .gitignore pattern Quentin Monnet
2019-04-30 0:15 ` Masahiro Yamada
2019-04-30 9:21 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556549259-16298-1-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sirio@b-ad.ch \
--cc=songliubraving@fb.com \
--cc=treeze.taeung@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).