From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9D5C004C9 for ; Tue, 7 May 2019 20:04:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4103E20825 for ; Tue, 7 May 2019 20:04:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="KU3Fd0/z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726775AbfEGUE0 (ORCPT ); Tue, 7 May 2019 16:04:26 -0400 Received: from mail-qt1-f172.google.com ([209.85.160.172]:38723 "EHLO mail-qt1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726091AbfEGUEZ (ORCPT ); Tue, 7 May 2019 16:04:25 -0400 Received: by mail-qt1-f172.google.com with SMTP id d13so3644502qth.5 for ; Tue, 07 May 2019 13:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=jOz25/N6iIBGpoDYghLukWmlA3AuvITwq8GHAzb9s00=; b=KU3Fd0/zdKEr+7NlBmuDBdwyrN9QgGp0aNtQ+K4xqQNqQz7mpUK0sSnLgIv4rwYHdb CxxORtHiyOcmJ05W4D/RcZrH0SmgaSdZY+oEZPH7PneZ4u+g2Y74LvYYhsZiNt1LPJ4W 5adDQLDn7JZ1j2qRR2z7nfdKdO9o8G1qYRWl5GDlJ52vORR/ag8dY9WUp6YyMf/ROxrf pvKnt2vTvpaPIJ6SCNmF6QKxWUERUQVcFvKYzLt2Qb5+1Pd2wwTpGK2r3bqVDd0LTjOa 5s30upag0zgfdDn1eF2n3DqOl1mGvoYJqFR8iD1c0SmUK2YclTz8PaD4UCgB/5p0vLTj eNtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=jOz25/N6iIBGpoDYghLukWmlA3AuvITwq8GHAzb9s00=; b=F4s3DfLPj3nr8vTdwpZ0GhAkWWtz/QyWdSPrO9R+k0/+4x6uvOv9ZhLiqd99wmO1zy KsAP0Wq+YsRNcvidEl/Yh4MmMcEClwqtieF10wkucfkOcZN0mSZT5j20dvMkKIZF5v/i 7Aa+tF7W6HGe95oVfZE/xH8lOTK6oDkdTaztzn0518AYqIF8Zl0kaAbZ1AU09XiaJf9U 0sDju0CSWQQnL2OiAHcPY4H62o3NSxJ6ZKWjhImNvcKPotQI0QlCCqhIe3Cds9PeUV0v lJRLm8iexuSYx/AZwk3YwDBmQ6VU8e0HxhFb2puXnww/DZdWxsfRS4um4yJ/5xfa3COo OzYg== X-Gm-Message-State: APjAAAXqLvR3geKX6U9FNnJYYk9UX7ULIUrxAqy7bprdamFgVWDkfZS0 6s2LJGDNs/kTWclgabTUJjpR4w== X-Google-Smtp-Source: APXvYqy66LP0bpVqkfQXMlJsS9p7rgZGdyffnIPWURW83BGlSRsFf/EpCZfc3KGn/v5//l1UJU4Vfg== X-Received: by 2002:ac8:2527:: with SMTP id 36mr28619350qtm.260.1557259464642; Tue, 07 May 2019 13:04:24 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id 8sm9632544qtr.32.2019.05.07.13.04.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 May 2019 13:04:23 -0700 (PDT) Message-ID: <1557259462.6132.20.camel@lca.pw> Subject: ptrace warning due to "cgroup: get rid of cgroup_freezer_frozen_exit()" From: Qian Cai To: guro@fb.com Cc: oleg@redhat.com, tj@kernel.org, lizefan@huawei.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, "linux-kernel@vger.kernel.org" Date: Tue, 07 May 2019 16:04:22 -0400 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org LTP ptrace01 test case triggers a warning below. Looks at ptrace_stop() calls cgroup_enter_frozen() there in the cgroup v2 freezer. [ 8373.336330] WARNING: CPU: 56 PID: 67026 at kernel/cgroup/cgroup.c:6008 cgroup_exit+0x2a9/0x2f0 [ 8373.345001] Modules linked in: brd ext4 crc16 mbcache jbd2 overlay loop nls_iso8859_1 nls_cp437 vfat fat kvm_amd kvm ses enclosure dax_pmem irqbypass dax_pmem_core efivars ip_tables x_tables xfs sd_mod smartpqi scsi_transport_sas tg3 mlx5_core libphy firmware_class dm_mirror dm_region_hash dm_log dm_mod efivarfs [last unloaded: dummy_del_mod] [ 8373.375561] CPU: 56 PID: 67026 Comm: ptrace01 Tainted: G           O      5.1.0-next-20190507+ #25 [ 8373.384579] Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 01/25/2019 [ 8373.393164] RIP: 0010:cgroup_exit+0x2a9/0x2f0 [ 8373.397556] Code: 0d ff ff ff 4c 89 f7 e8 75 4b 1b 00 4c 8b ab 20 0f 00 00 49 8d 7d 50 e8 65 4b 1b 00 49 8b 7d 50 e8 4c 56 00 00 e9 db fe ff ff <0f> 0b e9 3a fe ff ff 48 01 f1 0f 82 3b ff ff ff 48 c7 c7 40 83 5b [ 8373.416443] RSP: 0018:ffff888bdc9ef9b8 EFLAGS: 00010002 [ 8373.421709] RAX: 0000000000000000 RBX: ffff888e5cfcc040 RCX: ffffffffab3a8e7d [ 8373.428897] RDX: 1ffff111cb9f9875 RSI: dffffc0000000000 RDI: ffff888e5cfcc3a8 [ 8373.436080] RBP: ffff888bdc9efa50 R08: ffffed117b93df25 R09: ffffed117b93df24 [ 8373.443266] R10: ffffed117b93df24 R11: 0000000000000003 R12: ffff888bdc9efa28 [ 8373.450451] R13: ffff888f4c2346c8 R14: ffff888e5cfccf60 R15: ffff888e5cfccf68 [ 8373.457637] FS:  00007ff1e2e3d5c0(0000) GS:ffff88902f800000(0000) knlGS:0000000000000000 [ 8373.465781] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 8373.471569] CR2: 00007ff1e286fe8a CR3: 000000092c412000 CR4: 00000000001406a0 [ 8373.478750] Call Trace: [ 8373.481219]  ? cgroup_post_fork+0x350/0x350 [ 8373.485435]  ? fpu__drop+0x5e/0x230 [ 8373.488951]  ? exit_thread+0x10c/0x160 [ 8373.492736]  do_exit+0x5cb/0x1740 [ 8373.496083]  ? check_chain_key+0x142/0x200 [ 8373.500210]  ? mm_update_next_owner+0x360/0x360 [ 8373.504775]  ? map_id_up+0x14c/0x1f0 [ 8373.508380]  ? check_chain_key+0x142/0x200 [ 8373.512512]  ? get_signal+0x5f1/0xde0 [ 8373.516206]  ? lock_downgrade+0x300/0x300 [ 8373.520246]  ? lock_downgrade+0x300/0x300 [ 8373.524287]  do_group_exit+0x78/0x160 [ 8373.527978]  get_signal+0x1e8/0xde0 [ 8373.531498]  do_signal+0x9c/0x9d0 [ 8373.534841]  ? check_chain_key+0x142/0x200 [ 8373.538970]  ? setup_sigcontext+0x280/0x280 [ 8373.543185]  ? lock_downgrade+0x300/0x300 [ 8373.547228]  ? kill_pid_info+0x2e/0xd0 [ 8373.551006]  ? kill_pid_info+0xa4/0xd0 [ 8373.554788]  ? __x64_sys_kill+0x262/0x350 [ 8373.558830]  exit_to_usermode_loop+0x9d/0xc0 [ 8373.563131]  do_syscall_64+0x470/0x5d8 [ 8373.566910]  ? syscall_return_slowpath+0xf0/0xf0 [ 8373.571565]  ? __do_page_fault+0x44d/0x5b0 [ 8373.575698]  entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 8373.580789] RIP: 0033:0x7ff1e2893c3b [ 8373.584402] Code: Bad RIP value. [ 8373.587653] RSP: 002b:00007ffd8e5efe78 EFLAGS: 00000206 ORIG_RAX: 000000000000003e [ 8373.595276] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00007ff1e2893c3b [ 8373.602461] RDX: 0000000000000000 RSI: 000000000000000c RDI: 00000000000105d2 [ 8373.609642] RBP: 0000000000000000 R08: 00000000ffffffff R09: 00007ff1e2e3d5c0 [ 8373.616824] R10: fffffffffffff768 R11: 0000000000000206 R12: 00007ffd8e5efe98 [ 8373.624005] R13: 00007ffd8e5f00c0 R14: 0000000000000000 R15: 0000000000000000 [ 8373.631190] ---[ end trace a7169f3366f1d100 ]---