From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7758AC04AB2 for ; Thu, 9 May 2019 17:27:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CF1320675 for ; Thu, 9 May 2019 17:27:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557422868; bh=TuZoZqt3C0Ly1PPKUwukLctgk89R/xZyUazagckl/rc=; h=In-Reply-To:References:From:Subject:Cc:To:Date:List-ID:From; b=ro287xQoNStU8XZs4QqamW18CO/lxnMBJUacSFOfbtBQkLfCIgxqTUifSQkd9K+wR xCQprdjy86ABr0RKtrYnr/YslBBk18JzGS2/ETeGAmxTiSu5n36E0EY34zqY+PY/IR EnbSza9hFTyufvACQovs6/p9ZAMi1dUtPxvrKM10= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726923AbfEIR1r (ORCPT ); Thu, 9 May 2019 13:27:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:57804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726632AbfEIR1r (ORCPT ); Thu, 9 May 2019 13:27:47 -0400 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D8AF20675; Thu, 9 May 2019 17:27:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557422866; bh=TuZoZqt3C0Ly1PPKUwukLctgk89R/xZyUazagckl/rc=; h=In-Reply-To:References:From:Subject:Cc:To:Date:From; b=bAZfXMIUKIKsOuzgSpi04J+BjpwxbbTPE/x7MCVEFuVBqCpdtCOViJGgsx21EZ67I lGvMgzfqW2K/Eeh/hdq+zWXs0fXub0NvjX+yAbxGce9cUQxzdcndvp+8MFfTprWGWb mjdzIqNY2L/6UFFn+ipSqvXCDut4TsqQcqn9DBaA= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1557339895-21952-4-git-send-email-tdas@codeaurora.org> References: <1557339895-21952-1-git-send-email-tdas@codeaurora.org> <1557339895-21952-4-git-send-email-tdas@codeaurora.org> From: Stephen Boyd Subject: Re: [PATCH v1 3/3] clk: qcom: rcg: update the DFS macro for RCG Cc: Andy Gross , David Brown , Rajendra Nayak , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Taniya Das To: Michael Turquette , Taniya Das Message-ID: <155742286525.14659.18081373668341127486@swboyd.mtv.corp.google.com> User-Agent: alot/0.8 Date: Thu, 09 May 2019 10:27:45 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Taniya Das (2019-05-08 11:24:55) > Update the init data name for each of the dynamic frequency switch > controlled clock associated with the RCG clock name, so that it can be > generated as per the hardware plan. Thus update the macro accordingly. >=20 > Signed-off-by: Taniya Das This patch doesn't make any sense to me. > --- > drivers/clk/qcom/clk-rcg.h | 2 +- > drivers/clk/qcom/gcc-sdm845.c | 96 +++++++++++++++++++++----------------= ------ > 2 files changed, 49 insertions(+), 49 deletions(-) >=20 > diff --git a/drivers/clk/qcom/clk-rcg.h b/drivers/clk/qcom/clk-rcg.h > index 5562f38..e40e8f8 100644 > --- a/drivers/clk/qcom/clk-rcg.h > +++ b/drivers/clk/qcom/clk-rcg.h > @@ -171,7 +171,7 @@ struct clk_rcg_dfs_data { > }; >=20 > #define DEFINE_RCG_DFS(r) \ > - { .rcg =3D &r##_src, .init =3D &r##_init } > + { .rcg =3D &r, .init =3D &r##_init } Why do we need to rename the init data? >=20 > extern int qcom_cc_register_rcg_dfs(struct regmap *regmap, > const struct clk_rcg_dfs_data *rcgs, > diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c > index 7131dcf..a76178b 100644 > --- a/drivers/clk/qcom/gcc-sdm845.c > +++ b/drivers/clk/qcom/gcc-sdm845.c > @@ -408,7 +408,7 @@ enum { > { } > }; >=20 > -static struct clk_init_data gcc_qupv3_wrap0_s0_clk_init =3D { > +static struct clk_init_data gcc_qupv3_wrap0_s0_clk_src_init =3D { > .name =3D "gcc_qupv3_wrap0_s0_clk_src", > .parent_names =3D gcc_parent_names_0, > .num_parents =3D 4, > @@ -3577,22 +3577,22 @@ enum { > MODULE_DEVICE_TABLE(of, gcc_sdm845_match_table); >=20 > static const struct clk_rcg_dfs_data gcc_dfs_clocks[] =3D { > - DEFINE_RCG_DFS(gcc_qupv3_wrap0_s0_clk), > + DEFINE_RCG_DFS(gcc_qupv3_wrap0_s0_clk_src), I've trimmed the above to try and see what's changed but it doesn't make sense still.