From: Jitao Shi <jitao.shi@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, <linux-pwm@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
Thierry Reding <treding@nvidia.com>,
"Ajay Kumar" <ajaykumar.rs@samsung.com>,
Inki Dae <inki.dae@samsung.com>,
"Rahul Sharma" <rahul.sharma@samsung.com>,
Sean Paul <seanpaul@chromium.org>,
Vincent Palatin <vpalatin@chromium.org>,
Andy Yan <andy.yan@rock-chips.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
"Russell King" <rmk+kernel@arm.linux.org.uk>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>,
Sascha Hauer <kernel@pengutronix.de>, <yingjoe.chen@mediatek.com>,
<eddie.huang@mediatek.com>, <cawa.cheng@mediatek.com>,
<bibby.hsieh@mediatek.com>, <stonea168@163.com>
Subject: Re: [v2 3/3] drm/mediatek: add mipi_tx driver for mt8183
Date: Sat, 18 May 2019 15:51:32 +0800 [thread overview]
Message-ID: <1558165892.7681.8.camel@mszsdaap41> (raw)
In-Reply-To: <1557134258.5345.5.camel@mtksdaap41>
On Mon, 2019-05-06 at 17:17 +0800, CK Hu wrote:
> Hi, Jitao:
>
> On Tue, 2019-04-16 at 13:42 +0800, Jitao Shi wrote:
> > This patch add mt8183 mipi_tx driver.
> > And also support other chips that use the same binding and driver.
> >
> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/Makefile | 1 +
> > drivers/gpu/drm/mediatek/mtk_mipi_tx.c | 2 +
> > drivers/gpu/drm/mediatek/mtk_mipi_tx.h | 1 +
> > drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c | 154 ++++++++++++++++++
> > 4 files changed, 158 insertions(+)
> > create mode 100644 drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c
> >
>
> [snip]
>
> > +
> > +static int mtk_mipi_tx_pll_prepare(struct clk_hw *hw)
> > +{
> > + struct mtk_mipi_tx *mipi_tx = mtk_mipi_tx_from_clk_hw(hw);
> > + unsigned int txdiv, txdiv0;
> > + u64 pcw;
> > + int ret;
> > +
> > + dev_dbg(mipi_tx->dev, "prepare: %u bps\n", mipi_tx->data_rate);
> > +
> > + if (mipi_tx->data_rate >= 2000000000) {
> > + txdiv = 1;
> > + txdiv0 = 0;
> > + } else if (mipi_tx->data_rate >= 1000000000) {
> > + txdiv = 2;
> > + txdiv0 = 1;
> > + } else if (mipi_tx->data_rate >= 500000000) {
> > + txdiv = 4;
> > + txdiv0 = 2;
> > + } else if (mipi_tx->data_rate > 250000000) {
> > + txdiv = 8;
> > + txdiv0 = 3;
> > + } else if (mipi_tx->data_rate >= 125000000) {
> > + txdiv = 16;
> > + txdiv0 = 4;
> > + } else {
> > + return -EINVAL;
> > + }
> > +
> > + ret = clk_prepare_enable(mipi_tx->ref_clk);
> > + if (ret < 0) {
> > + dev_err(mipi_tx->dev,
> > + "can't prepare and enable mipi_tx ref_clk %d\n", ret);
> > + return ret;
> > + }
>
> You enable the parent clock when prepare this clock here, this behavior
> looks strange. I think the flow should be:
>
> 1. Parent clock prepare
> 2. This clock prepare
> 3. Parent clock enable
> 4. This clock enable
>
> Maybe you should implement 'enable callback' so that parent clock would
> be already enabled.
>
> One question is, mipi_tx_pll is used by dsi driver, but I does not see
> dsi prepare_enable() mipi_tx_pll, how does this work?
>
> Regards,
> CK
>
The mipi_tx can be accessed after clk_prepare_enable(mipi_tx->ref_clk);
So place the clk_prepare_enable(mipi_tx->ref_clk) before accessing
mipitx.
mipi_tx_pll is enable by mtk_mipi_tx_power_on() in mtk_mip_tx.c.
clk_prepare_enable(mipi_tx->pll) will enable mipi_tx_pll.
Beset Regards
Jitao
> > +
> > + mtk_mipi_tx_clear_bits(mipi_tx, MIPITX_PLL_CON4, RG_DSI_PLL_IBIAS);
> > +
> > + mtk_mipi_tx_set_bits(mipi_tx, MIPITX_PLL_PWR, AD_DSI_PLL_SDM_PWR_ON);
> > + usleep_range(30, 100);
> > + mtk_mipi_tx_clear_bits(mipi_tx, MIPITX_PLL_PWR, AD_DSI_PLL_SDM_ISO_EN);
> > + pcw = div_u64(((u64)mipi_tx->data_rate * txdiv) << 24, 26000000);
> > + writel(pcw, mipi_tx->regs + MIPITX_PLL_CON0);
> > + mtk_mipi_tx_update_bits(mipi_tx, MIPITX_PLL_CON1, RG_DSI_PLL_POSDIV,
> > + txdiv0 << 8);
> > + usleep_range(1000, 2000);
> > + mtk_mipi_tx_set_bits(mipi_tx, MIPITX_PLL_CON1, RG_DSI_PLL_EN);
> > +
> > + return 0;
> > +}
> > +
> > +static void mtk_mipi_tx_pll_unprepare(struct clk_hw *hw)
> > +{
> > + struct mtk_mipi_tx *mipi_tx = mtk_mipi_tx_from_clk_hw(hw);
> > +
> > + dev_dbg(mipi_tx->dev, "unprepare\n");
> > +
> > + mtk_mipi_tx_clear_bits(mipi_tx, MIPITX_PLL_CON1, RG_DSI_PLL_EN);
> > +
> > + mtk_mipi_tx_set_bits(mipi_tx, MIPITX_PLL_PWR, AD_DSI_PLL_SDM_ISO_EN);
> > + mtk_mipi_tx_clear_bits(mipi_tx, MIPITX_PLL_PWR, AD_DSI_PLL_SDM_PWR_ON);
> > + clk_disable_unprepare(mipi_tx->ref_clk);
> > +}
> > +
>
>
next prev parent reply other threads:[~2019-05-18 7:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 5:42 [v2 0/3] support mipitx on mt8183 Jitao Shi
2019-04-16 5:42 ` [v2 1/3] dt-bindings: display: mediatek: update dsi supported chips Jitao Shi
2019-04-29 22:26 ` Rob Herring
2019-04-16 5:42 ` [v2 2/3] drm/mediatek: separate mipi_tx to different file Jitao Shi
2019-04-16 5:42 ` [v2 3/3] drm/mediatek: add mipi_tx driver for mt8183 Jitao Shi
2019-05-06 9:17 ` CK Hu
2019-05-18 7:51 ` Jitao Shi [this message]
2019-05-20 5:30 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558165892.7681.8.camel@mszsdaap41 \
--to=jitao.shi@mediatek.com \
--cc=airlied@linux.ie \
--cc=ajaykumar.rs@samsung.com \
--cc=andy.yan@rock-chips.com \
--cc=bibby.hsieh@mediatek.com \
--cc=cawa.cheng@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eddie.huang@mediatek.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=rahul.sharma@samsung.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
--cc=srv_heupstream@mediatek.com \
--cc=stonea168@163.com \
--cc=treding@nvidia.com \
--cc=vpalatin@chromium.org \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).