From: Chris Wilson <chris@chris-wilson.co.uk>
To: Andrew Morton <akpm@linux-foundation.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Hugh Dickins <hughd@google.com>,
x86@kernel.org, Mike Rapoport <rppt@linux.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Borislav Petkov <bp@suse.de>, Pavel Machek <pavel@ucw.cz>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v2] x86/fpu: Use fault_in_pages_writeable() for pre-faulting
Date: Wed, 29 May 2019 22:29:03 +0100 [thread overview]
Message-ID: <155916534299.2252.10999808950517357760@skylake-alporthouse-com> (raw)
In-Reply-To: <20190529072540.g46j4kfeae37a3iu@linutronix.de>
Quoting Sebastian Andrzej Siewior (2019-05-29 08:25:40)
> From: Hugh Dickins <hughd@google.com>
>
> Since commit
>
> d9c9ce34ed5c8 ("x86/fpu: Fault-in user stack if copy_fpstate_to_sigframe() fails")
>
> we use get_user_pages_unlocked() to pre-faulting user's memory if a
> write generates a pagefault while the handler is disabled.
> This works in general and uncovered a bug as reported by Mike Rapoport.
> It has been pointed out that this function may be fragile and a
> simple pre-fault as in fault_in_pages_writeable() would be a better
> solution. Better as in taste and simplicity: That write (as performed by
> the alternative function) performs exactly the same faulting of memory
> that we had before. This was suggested by Hugh Dickins and Andrew
> Morton.
>
> Use fault_in_pages_writeable() for pre-faulting of user's stack.
>
> Fixes: d9c9ce34ed5c8 ("x86/fpu: Fault-in user stack if copy_fpstate_to_sigframe() fails")
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Hugh Dickins <hughd@google.com>
> [bigeasy: patch description]
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
I am able to reliably hit the bug here by putting the system under
mempressure, and afterwards processes would die as the exit. This patch
also greatly reduces cycletest latencies while under that mempressure,
~320ms -> ~16ms (on a bxt while also spinning on i915.ko).
Tested-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
prev parent reply other threads:[~2019-05-29 21:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 17:33 [PATCH] x86/fpu: Use fault_in_pages_writeable() for pre-faulting Sebastian Andrzej Siewior
2019-05-26 17:35 ` Sebastian Andrzej Siewior
2019-05-26 19:25 ` Hugh Dickins
2019-05-28 11:54 ` My emacs problem -- was " Pavel Machek
2019-05-29 4:18 ` Andrew Morton
2019-05-29 7:25 ` [PATCH v2] " Sebastian Andrzej Siewior
2019-05-14 14:29 ` [PATCH] mm/gup: continue VM_FAULT_RETRY processing event for pre-faults Mike Rapoport
2019-05-16 16:25 ` Andrei Vagin
2019-05-21 15:53 ` Mike Rapoport
2019-05-22 19:21 ` Andrew Morton
2019-05-22 19:43 ` Sebastian Andrzej Siewior
2019-05-24 22:22 ` Hugh Dickins
2019-05-25 8:45 ` Sebastian Andrzej Siewior
2019-05-25 18:09 ` Hugh Dickins
2019-05-26 19:36 ` Sebastian Andrzej Siewior
2019-05-26 20:17 ` Hugh Dickins
2019-05-26 17:25 ` Pavel Machek
2019-05-22 20:38 ` Mike Rapoport
2019-05-22 21:18 ` Andrew Morton
2019-06-22 17:51 ` Andrea Arcangeli
2019-06-06 17:25 ` [tip:x86/urgent] x86/fpu: Use fault_in_pages_writeable() for pre-faulting tip-bot for Hugh Dickins
2019-05-29 21:29 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155916534299.2252.10999808950517357760@skylake-alporthouse-com \
--to=chris@chris-wilson.co.uk \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pavel@ucw.cz \
--cc=rppt@linux.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).