From: Neal Liu <neal.liu@mediatek.com>
To: Sean Wang <sean.wang@kernel.org>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rob Herring <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-crypto@vger.kernel.org>, <devicetree@vger.kernel.org>,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
lkml <linux-kernel@vger.kernel.org>, <wsd_upstream@mediatek.com>,
Crystal Guo <Crystal.Guo@mediatek.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: rng: update bindings for MediaTek ARMv8 SoCs
Date: Mon, 3 Jun 2019 10:27:07 +0800 [thread overview]
Message-ID: <1559528827.6663.8.camel@mtkswgap22> (raw)
In-Reply-To: <CAGp9LzrQegBb9Oe-=jfkwOrsYY=eN3BSF=DWnu+aSBAhQ5bexA@mail.gmail.com>
Hi Sean,
On Thu, 2019-05-30 at 15:56 -0700, Sean Wang wrote:
> Hi, Neal
>
> On Mon, May 27, 2019 at 1:39 AM Neal Liu <neal.liu@mediatek.com> wrote:
> >
> > Document the binding used by the MediaTek ARMv8 SoCs random
> > number generator with TrustZone enabled.
> >
> > Signed-off-by: Neal Liu <neal.liu@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/rng/mtk-rng.txt | 13 ++++++++++---
> > 1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/rng/mtk-rng.txt b/Documentation/devicetree/bindings/rng/mtk-rng.txt
> > index 2bc89f1..1fb9b1d 100644
> > --- a/Documentation/devicetree/bindings/rng/mtk-rng.txt
> > +++ b/Documentation/devicetree/bindings/rng/mtk-rng.txt
> > @@ -3,9 +3,12 @@ found in MediaTek SoC family
> >
> > Required properties:
> > - compatible : Should be
> > - "mediatek,mt7622-rng", "mediatek,mt7623-rng" : for MT7622
> > - "mediatek,mt7629-rng", "mediatek,mt7623-rng" : for MT7629
> > - "mediatek,mt7623-rng" : for MT7623
> > + "mediatek,mt7622-rng", "mediatek,mt7623-rng" for MT7622
> > + "mediatek,mt7629-rng", "mediatek,mt7623-rng" for MT7629
> > + "mediatek,mt7623-rng" for MT7623
>
> No make any change for those lines not belong to the series
There are some unused spaces and symbols. We try to align coding style
with other bindings.
>
> > + "mediatek,mtk-sec-rng" for MediaTek ARMv8 SoCs
>
> I thought "mediatek,mtk-sec-rng" is only for those MediaTek ARMv8 SoCs
> with security RNG
Yes, sure. It's better to describe with "MediaTek ARMv8 SoCs with
security RNG".
>
> > +
> > +Optional properties:
> > - clocks : list of clock specifiers, corresponding to
> > entries in clock-names property;
> > - clock-names : Should contain "rng" entries;
> > @@ -19,3 +22,7 @@ rng: rng@1020f000 {
> > clocks = <&infracfg CLK_INFRA_TRNG>;
> > clock-names = "rng";
> > };
>
> For those MediaTek ARMv8 SoCs with security RNG
Are you suggesting we create a new binding file with security RNG?
>
> > +
> > +hwrng: hwrng {
> > + compatible = "mediatek,mtk-sec-rng";
> > +};
> > --
> > 1.7.9.5
> >
next prev parent reply other threads:[~2019-06-03 2:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 8:38 [PATCH v2 0/3] MediaTek Security random number generator support Neal Liu
2019-05-27 8:38 ` [PATCH v2 1/3] soc: mediatek: add SMC fid table for SIP interface Neal Liu
2019-05-30 22:50 ` Sean Wang
2019-06-03 2:39 ` Neal Liu
2019-05-27 8:38 ` [PATCH v2 2/3] dt-bindings: rng: update bindings for MediaTek ARMv8 SoCs Neal Liu
2019-05-30 22:56 ` Sean Wang
2019-06-03 2:27 ` Neal Liu [this message]
2019-05-27 8:38 ` [PATCH v2 3/3] hwrng: add mtk-sec-rng driver Neal Liu
2019-05-30 22:59 ` Sean Wang
2019-06-03 2:36 ` Neal Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559528827.6663.8.camel@mtkswgap22 \
--to=neal.liu@mediatek.com \
--cc=Crystal.Guo@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mpm@selenic.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).