From: Qian Cai <cai@lca.pw>
To: akpm@linux-foundation.org
Cc: rppt@linux.ibm.com, will.deacon@arm.com, catalin.marinas@arm.com,
linux-arm-kernel@lists.infradead.org, hannes@cmpxchg.org,
mhocko@kernel.org, vdavydov.dev@gmail.com,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Qian Cai <cai@lca.pw>
Subject: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc()
Date: Tue, 4 Jun 2019 10:00:36 -0400 [thread overview]
Message-ID: <1559656836-24940-1-git-send-email-cai@lca.pw> (raw)
The commit "arm64: switch to generic version of pte allocation"
introduced endless failures during boot like,
kobject_add_internal failed for pgd_cache(285:chronyd.service) (error:
-2 parent: cgroup)
It turns out __GFP_ACCOUNT is passed to kernel page table allocations
and then later memcg finds out those don't belong to any cgroup.
backtrace:
kobject_add_internal
kobject_init_and_add
sysfs_slab_add+0x1a8
__kmem_cache_create
create_cache
memcg_create_kmem_cache
memcg_kmem_cache_create_func
process_one_work
worker_thread
kthread
Signed-off-by: Qian Cai <cai@lca.pw>
---
arch/arm64/mm/pgd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/mm/pgd.c b/arch/arm64/mm/pgd.c
index 769516cb6677..53c48f5c8765 100644
--- a/arch/arm64/mm/pgd.c
+++ b/arch/arm64/mm/pgd.c
@@ -38,7 +38,7 @@ pgd_t *pgd_alloc(struct mm_struct *mm)
if (PGD_SIZE == PAGE_SIZE)
return (pgd_t *)__get_free_page(gfp);
else
- return kmem_cache_alloc(pgd_cache, gfp);
+ return kmem_cache_alloc(pgd_cache, GFP_PGTABLE_KERNEL);
}
void pgd_free(struct mm_struct *mm, pgd_t *pgd)
--
1.8.3.1
next reply other threads:[~2019-06-04 14:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 14:00 Qian Cai [this message]
2019-06-04 14:23 ` [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc() Mark Rutland
2019-06-04 14:30 ` Mark Rutland
2019-06-05 21:33 ` Mike Rapoport
2019-06-04 14:54 ` Mike Rapoport
2019-06-10 11:43 ` Will Deacon
2019-06-10 17:26 ` Qian Cai
2019-06-11 10:03 ` Mark Rutland
2019-06-11 12:41 ` Mike Rapoport
2019-06-11 12:46 ` Qian Cai
2019-06-12 6:57 ` Mike Rapoport
2019-06-12 18:35 ` Qian Cai
2019-06-11 13:02 ` Mark Rutland
2019-06-13 12:11 ` Mike Rapoport
2019-06-13 13:22 ` Qian Cai
2019-06-13 19:44 ` Mike Rapoport
2019-06-17 15:12 ` Mike Rapoport
2019-06-17 16:36 ` Will Deacon
2019-06-18 6:12 ` Mike Rapoport
2019-06-18 6:54 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559656836-24940-1-git-send-email-cai@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=vdavydov.dev@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).