From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F729C282CE for ; Tue, 4 Jun 2019 14:01:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E968E24483 for ; Tue, 4 Jun 2019 14:01:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="FjD0vS90" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727741AbfFDOBL (ORCPT ); Tue, 4 Jun 2019 10:01:11 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:33481 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727515AbfFDOBI (ORCPT ); Tue, 4 Jun 2019 10:01:08 -0400 Received: by mail-qt1-f193.google.com with SMTP id 14so13864273qtf.0 for ; Tue, 04 Jun 2019 07:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id; bh=HA9nmzXQ1v1EpP1te6eSn7ZdKChVSouT7677WSi9nIU=; b=FjD0vS909bew//7s7kZ4U68BxVAcYNK5lIoo28VJ0iR1cKCHo5uwPCWhKdZwvb5R3h l+JLi7kgdhHQ1mXfsVZvplZ78xwVC8/ftBcb4Y1CP7AfT7ECrvsLzhzJmhjoXKQ+9YfW jkK1KfkjNxpW1xSRKQnYK4mvUMqCOfcP73zC3WHA+ooGIl+psI9Q4jqvA7bBCK7mH9Ef w3/bC3nfoSs3iDZfv8dHX2070J87acrVGFg6U4tChzCNpv8wZEvISzXrFjF4d2cH+dQg CW65qtmF/xSV9/UwnhEaWAjNq9r1a+ZARBE5OytTmcBx9/3tgsvUzYwtXDaZM5w9ZTBz LD/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=HA9nmzXQ1v1EpP1te6eSn7ZdKChVSouT7677WSi9nIU=; b=N4IvicvV8GxZo679nkb+IfAq9ztP/q8d7vxJN2Cfhcl7yvCuBX3ZPMI2p9z+sue3DW VrIhR2u8wR3osUqKSKnNPDlyzMC7XjTk61WcPQndFVWfGg8P9/E2bZpoq4n2IxzeSS5N WhgRlAAr1LJ/spVj/BHGgyOKdIexRYw61Ozt3eNJUPhS3mqOIiSZIV36ZZqeVAjTaQ66 9v8klV3FEnMkhAPmc8sVna9Jv4fmQp5bd13dAl5Z+DldC0eWpu+S3qkZ5xrq68/uIAb6 STH3bEvto4wXwP7bXBEUVyJMIpKh0276Vao9Z8VRMgSbwcsXWaAK4+z3Oa32kV6b+OAM oMTw== X-Gm-Message-State: APjAAAUQ/QugD1dD0rh7BR/slw3s8oDuISZAqevuEXZQY+1/gC6CcAsl 7ITv/6hkdSL43Lq+7eWOisnVyw== X-Google-Smtp-Source: APXvYqyaYFcOVCNNE4EgaFXVtcyiuzl8/nFtl+bPshTs3JbBCrjCSlVZ/oa+7ymTOAx0gJHRKZE4qg== X-Received: by 2002:a0c:be87:: with SMTP id n7mr8195030qvi.65.1559656867510; Tue, 04 Jun 2019 07:01:07 -0700 (PDT) Received: from qcai.nay.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id f189sm2340295qkj.13.2019.06.04.07.01.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 07:01:06 -0700 (PDT) From: Qian Cai To: akpm@linux-foundation.org Cc: rppt@linux.ibm.com, will.deacon@arm.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc() Date: Tue, 4 Jun 2019 10:00:36 -0400 Message-Id: <1559656836-24940-1-git-send-email-cai@lca.pw> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The commit "arm64: switch to generic version of pte allocation" introduced endless failures during boot like, kobject_add_internal failed for pgd_cache(285:chronyd.service) (error: -2 parent: cgroup) It turns out __GFP_ACCOUNT is passed to kernel page table allocations and then later memcg finds out those don't belong to any cgroup. backtrace: kobject_add_internal kobject_init_and_add sysfs_slab_add+0x1a8 __kmem_cache_create create_cache memcg_create_kmem_cache memcg_kmem_cache_create_func process_one_work worker_thread kthread Signed-off-by: Qian Cai --- arch/arm64/mm/pgd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/mm/pgd.c b/arch/arm64/mm/pgd.c index 769516cb6677..53c48f5c8765 100644 --- a/arch/arm64/mm/pgd.c +++ b/arch/arm64/mm/pgd.c @@ -38,7 +38,7 @@ pgd_t *pgd_alloc(struct mm_struct *mm) if (PGD_SIZE == PAGE_SIZE) return (pgd_t *)__get_free_page(gfp); else - return kmem_cache_alloc(pgd_cache, gfp); + return kmem_cache_alloc(pgd_cache, GFP_PGTABLE_KERNEL); } void pgd_free(struct mm_struct *mm, pgd_t *pgd) -- 1.8.3.1