* [PATCH] drivers/ata: remove flood "Enabling discard_zeroes_data"
@ 2019-06-07 7:34 Konstantin Khlebnikov
2019-06-07 17:26 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Khlebnikov @ 2019-06-07 7:34 UTC (permalink / raw)
To: Jens Axboe, linux-ide, linux-kernel; +Cc: Dmitry Monakhov
Printing this at each SCSI READ_CAPACITY command is too verbose.
Flag "discard_zeroes_data" is deprecated since commit 48920ff2a5a9
("block: remove the discard_zeroes_data flag").
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
---
drivers/ata/libata-scsi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 391ac0503dc0..a475e94944b7 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -2735,10 +2735,8 @@ static unsigned int ata_scsiop_read_cap(struct ata_scsi_args *args, u8 *rbuf)
rbuf[14] |= 0x80; /* LBPME */
if (ata_id_has_zero_after_trim(args->id) &&
- dev->horkage & ATA_HORKAGE_ZERO_AFTER_TRIM) {
- ata_dev_info(dev, "Enabling discard_zeroes_data\n");
+ dev->horkage & ATA_HORKAGE_ZERO_AFTER_TRIM)
rbuf[14] |= 0x40; /* LBPRZ */
- }
}
if (ata_id_zoned_cap(args->id) ||
args->dev->class == ATA_DEV_ZAC)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/ata: remove flood "Enabling discard_zeroes_data"
2019-06-07 7:34 [PATCH] drivers/ata: remove flood "Enabling discard_zeroes_data" Konstantin Khlebnikov
@ 2019-06-07 17:26 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-06-07 17:26 UTC (permalink / raw)
To: Konstantin Khlebnikov
Cc: Jens Axboe, linux-ide, linux-kernel, Dmitry Monakhov
Konstantin,
> Printing this at each SCSI READ_CAPACITY command is too verbose.
>
> Flag "discard_zeroes_data" is deprecated since commit 48920ff2a5a9
> ("block: remove the discard_zeroes_data flag").
> - dev->horkage & ATA_HORKAGE_ZERO_AFTER_TRIM) {
> - ata_dev_info(dev, "Enabling discard_zeroes_data\n");
> + dev->horkage & ATA_HORKAGE_ZERO_AFTER_TRIM)
> rbuf[14] |= 0x40; /* LBPRZ */
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-07 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-07 7:34 [PATCH] drivers/ata: remove flood "Enabling discard_zeroes_data" Konstantin Khlebnikov
2019-06-07 17:26 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).