From: Guenter Roeck <linux@roeck-us.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
alpha <linux-alpha@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-parisc@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: [PATCH 4/4] alpha: Use absolute_pointer for strcmp on fixed memory location
Date: Sun, 12 Sep 2021 13:15:09 -0700 [thread overview]
Message-ID: <155e002d-9546-4090-fc62-fab91412aec7@roeck-us.net> (raw)
In-Reply-To: <CAHk-=wi1=8shingNuo1CtfJ7eDByDsmwsz750Nbxq=7q0Gs+zg@mail.gmail.com>
On 9/12/21 12:13 PM, Linus Torvalds wrote:
> On Sun, Sep 12, 2021 at 9:02 AM Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> - if (strcmp(COMMAND_LINE, "INSTALL") == 0) {
>> + if (strcmp(absolute_pointer(COMMAND_LINE), "INSTALL") == 0) {
>
> Again, this feels very much like treating the symptoms, not actually
> fixing the real issue.
>
> It's COMMAND_LINE itself that should have been fixed up, not that one use of it.
>
> Because the only reason you didn't get a warning from later uses is
> that 'strcmp()' is doing compiler-specific magic. You're just delaying
> the inevitable warnings about the other uses of that thing.
>
Makes sense. I'll change the patch accordingly.
Thanks,
Guenter
next prev parent reply other threads:[~2021-09-12 20:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 16:01 [PATCH 0/4] Introduce and use absolute_pointer macro Guenter Roeck
2021-09-12 16:01 ` [PATCH 1/4] compiler.h: Introduce " Guenter Roeck
2021-09-12 16:01 ` [PATCH 2/4] net: i825xx: Use absolute_pointer for memcpy on fixed memory location Guenter Roeck
2021-09-12 16:11 ` Jeroen Roovers
2021-09-12 16:16 ` Guenter Roeck
2021-09-12 16:01 ` [PATCH 3/4] parisc: Use absolute_pointer for memcmp " Guenter Roeck
2021-09-12 19:11 ` Linus Torvalds
2021-09-12 19:58 ` Helge Deller
2021-09-12 20:28 ` Guenter Roeck
2021-09-12 16:01 ` [PATCH 4/4] alpha: Use absolute_pointer for strcmp " Guenter Roeck
2021-09-12 19:13 ` Linus Torvalds
2021-09-12 20:15 ` Guenter Roeck [this message]
2021-09-12 20:37 ` Guenter Roeck
2021-09-12 22:58 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155e002d-9546-4090-fc62-fab91412aec7@roeck-us.net \
--to=linux@roeck-us.net \
--cc=James.Bottomley@hansenpartnership.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=ink@jurassic.park.msu.ru \
--cc=kuba@kernel.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rth@twiddle.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).