From: Mathias Nyman <mathias.nyman@intel.com>
To: "Zengtao (B)" <prime.zeng@hisilicon.com>,
Greg KH <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: Can we just remove the sw_lpm_support from current xhci driver?
Date: Mon, 15 Oct 2018 15:11:19 +0300 [thread overview]
Message-ID: <155e2a10-d324-6bc6-b3fc-b23d15a3af25@intel.com> (raw)
In-Reply-To: <678F3D1BB717D949B966B68EAEB446ED1F18C855@dggemm526-mbx.china.huawei.com>
On 15.10.2018 12:35, Zengtao (B) wrote:
> Hi:
>
> I am recently reading the LPM related code in xhci driver, and I find
> that the xhci->sw_lpm_support is not really used, but I am not sure
> whether we should remove it or not?
>
> Any ideas, Thanks.
I think it was used to prevent LPM in pre-0.96 xHC controllers.
Now driver only supports HW LPM for 1.0 and later controllers, so xhci->sw_lpm_support
doesn't really do anything.
You can send a patch removing it
Thanks
-Mathias
next prev parent reply other threads:[~2018-10-15 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 9:35 Can we just remove the sw_lpm_support from current xhci driver? Zengtao (B)
2018-10-15 12:11 ` Mathias Nyman [this message]
2018-10-16 3:23 ` Zengtao (B)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155e2a10-d324-6bc6-b3fc-b23d15a3af25@intel.com \
--to=mathias.nyman@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=prime.zeng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).