linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	Li Jun <jun.li@nxp.com>,
	"Badhri Jagan Sridharan" <badhri@google.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Min Guo <min.guo@mediatek.com>,
	devicetree <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	USB <linux-usb@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	Biju Das <biju.das@bp.renesas.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	"Yu Chen" <chenyu56@huawei.com>
Subject: Re: [PATCH v6 09/10] usb: roles: add USB Type-B GPIO connector driver
Date: Tue, 11 Jun 2019 13:47:46 +0800	[thread overview]
Message-ID: <1560232066.8487.119.camel@mhfsdcap03> (raw)
In-Reply-To: <CAHp75VeWu+8H2=PRNud_MAoD9zozb2Ugh9b=9TCtYmGLVyCTpQ@mail.gmail.com>

On Thu, 2019-06-06 at 09:31 +0300, Andy Shevchenko wrote:
> On Thu, Jun 6, 2019 at 5:53 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> >
> > On Wed, 2019-06-05 at 11:45 +0300, Andy Shevchenko wrote:
> > > On Wed, May 29, 2019 at 10:44 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
> > > >
> > > > Due to the requirement of usb-connector.txt binding, the old way
> > > > using extcon to support USB Dual-Role switch is now deprecated
> > > > when use Type-B connector.
> > > > This patch introduces a driver of Type-B connector which typically
> > > > uses an input GPIO to detect USB ID pin, and try to replace the
> > > > function provided by extcon-usb-gpio driver
> > >
> > > > +static SIMPLE_DEV_PM_OPS(usb_conn_pm_ops,
> > > > +                        usb_conn_suspend, usb_conn_resume);
> > > > +
> > > > +#define DEV_PMS_OPS (IS_ENABLED(CONFIG_PM_SLEEP) ? &usb_conn_pm_ops : NULL)
> > >
> > > Why this macro is needed?
> > Want to set .pm as NULL when CONFIG_PM_SLEEP is not enabled.
> 
> Doesn't SIMPLE_DEV_PM_OPS do this for you?
Yes, you are right, it provides an empty dev_pm_ops struct, I'll remove
DEV_PMS_OPS, thanks a lot

> 



  reply	other threads:[~2019-06-11  5:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-29  7:43 [PATCH v6 00/10] add USB Type-B GPIO connector driver Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 01/10] dt-binding: usb: add usb-role-switch property Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 02/10] dt-bindings: connector: add optional properties for Type-B Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 03/10] dt-bindings: usb: add binding for Type-B GPIO connector driver Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 04/10] dt-bindings: usb: mtu3: add properties about USB Role Switch Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 05/10] usb: roles: Introduce stubs for the exiting functions in role.h Chunfeng Yun
2019-06-03 13:19   ` Greg Kroah-Hartman
2019-06-04  6:43     ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 06/10] device connection: Add fwnode_connection_find_match() Chunfeng Yun
2019-05-31  7:40   ` Biju Das
2019-06-07 10:30   ` Heikki Krogerus
2019-06-10  1:50     ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 07/10] usb: roles: Add fwnode_usb_role_switch_get() function Chunfeng Yun
2019-05-31  7:41   ` Biju Das
2019-06-03 13:19   ` Greg Kroah-Hartman
2019-06-04  6:42     ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 08/10] usb: roles: get usb-role-switch from parent Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 09/10] usb: roles: add USB Type-B GPIO connector driver Chunfeng Yun
2019-06-05  8:45   ` Andy Shevchenko
2019-06-06  2:53     ` Chunfeng Yun
2019-06-06  6:31       ` Andy Shevchenko
2019-06-11  5:47         ` Chunfeng Yun [this message]
2019-06-10 10:33   ` Nagarjuna Kristam
2019-06-11  5:59     ` Chunfeng Yun
2019-05-29  7:43 ` [PATCH v6 10/10] usb: mtu3: register a USB Role Switch for dual role mode Chunfeng Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1560232066.8487.119.camel@mhfsdcap03 \
    --to=chunfeng.yun@mediatek.com \
    --cc=Adam.Thomson.Opensource@diasemi.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=badhri@google.com \
    --cc=biju.das@bp.renesas.com \
    --cc=chenyu56@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jun.li@nxp.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=min.guo@mediatek.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).