From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE768C31E49 for ; Thu, 13 Jun 2019 15:17:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B717020449 for ; Thu, 13 Jun 2019 15:17:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="bBNgno4o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388702AbfFMPRW (ORCPT ); Thu, 13 Jun 2019 11:17:22 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:33572 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732187AbfFMNWk (ORCPT ); Thu, 13 Jun 2019 09:22:40 -0400 Received: by mail-qk1-f194.google.com with SMTP id r6so12710028qkc.0 for ; Thu, 13 Jun 2019 06:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=RvQ7s6KqQFboNBrXACowYJehaEqJCBGaI4+3OVeMERI=; b=bBNgno4o9GAsUM3oGJioC5sI7aRIso2DiB+okxiU8rjGN4HJ0v1gxCNMi7udkAGL6f oky91oVZh7z6knKRvgJl9IikO9fYnZb3jWcg1ZNvsauYAOjk0zxqs7/D+G+mWwOQwvi5 XAEFmebepC8uobYYn6F6j3a1ccrCPMqRs6NImFil6YZeSfTI0Yunqha+8AmBT4bPOMrq uta0iARaSykyvjwOQfIWg6pltLH3IEX2UrTqThwQMVGM6Fbs4UncTG6BzJSoXCLm0n7w kk42c1Hsa+EHGKm3zEtga8Aae3Cdyj5QWiVaxE58eV4dWzuC7FmEvF7H7iUOL7yA11ah k7JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=RvQ7s6KqQFboNBrXACowYJehaEqJCBGaI4+3OVeMERI=; b=rYI5+F9aX4ySXLujBl/16zyNfoJ4wgUpbHCgJzHVNVSsROZ+Z6ZyEluYf4T/SW2PVY tNcTBKqpYgSIHdV7YH+hQExVbOxM+WdelEI1gZcI1pzuH6CiNh60Zk4D5QY3+4jXd2zw HDhQyMJ7pocctbWkohapeRnCbWBM6wFfARe4Ncr/DJ9Y9YH2RKITh9eebHi5K/+MPzK2 OA+BgDVOtefiuf6wCpZ6d2VuldCR1rQB+vGqqrmJDPJz1G3Hd3umvQYARUR+lTYV5tW3 9QaPc9M2zi+oo+NS+XqFZXxkjdr+BtyeK99nTWcfjZr8mm1xNou+wQEJz7cKzPQzXsAA QP0w== X-Gm-Message-State: APjAAAXMWd/wPmxlAypdSur0eLirCKkWh0YuGIadhE/Uy69p4KR/P3kY BGmJVBagqxJfkd20K3d2Qg+NAA== X-Google-Smtp-Source: APXvYqxBFU+2n7NeM2FTrwHp7MWYv4DOOcIQv0wH6sniaZCois+k70ecIkcp7EZJ319MIspcW/P2rg== X-Received: by 2002:a37:9885:: with SMTP id a127mr50858690qke.230.1560432158880; Thu, 13 Jun 2019 06:22:38 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id 77sm1564782qkd.59.2019.06.13.06.22.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 06:22:38 -0700 (PDT) Message-ID: <1560432156.5154.11.camel@lca.pw> Subject: Re: [PATCH -next] arm64/mm: fix a bogus GFP flag in pgd_alloc() From: Qian Cai To: Mike Rapoport , Mark Rutland Cc: Will Deacon , akpm@linux-foundation.org, Roman Gushchin , catalin.marinas@arm.com, linux-kernel@vger.kernel.org, mhocko@kernel.org, linux-mm@kvack.org, vdavydov.dev@gmail.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Thu, 13 Jun 2019 09:22:36 -0400 In-Reply-To: <20190613121100.GB25164@rapoport-lnx> References: <1559656836-24940-1-git-send-email-cai@lca.pw> <20190604142338.GC24467@lakrids.cambridge.arm.com> <20190610114326.GF15979@fuggles.cambridge.arm.com> <1560187575.6132.70.camel@lca.pw> <20190611100348.GB26409@lakrids.cambridge.arm.com> <20190613121100.GB25164@rapoport-lnx> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-06-13 at 15:11 +0300, Mike Rapoport wrote: > The log Qian Cai posted at [1] and partially cited below confirms that the > failure happens when *user* PGDs are allocated and the addition of > __GFP_ACCOUNT to gfp flags used by pgd_alloc() only uncovered another > issue. > > I'm still failing to reproduce it with qemu and I'm not really familiar > with slub/memcg code to say anything smart about it. Will keep looking. > > Note, that as failures start way after efi_virtmap_init() that allocates a > PGD for efi_mm, there are no real fixes required for the original series, > except that the check for mm == &init_mm I copied for some reason from > powerpc is bogus and can be removed. Yes, there is more places are not happy with __GFP_ACCOUNT other than efi_mm. For example, [  132.786842][ T1501] kobject_add_internal failed for pgd_cache(49:systemd- udevd.service) (error: -2 parent: cgroup) [  132.795589][ T1889] CPU: 9 PID: 1889 Comm: systemd-udevd Tainted: G        W         5.2.0-rc4-next-20190613+ #8 [  132.807356][ T1889] Hardware name: HPE Apollo 70             /C01_APACHE_MB         , BIOS L50_5.13_1.0.9 03/01/2019 [  132.817872][ T1889] Call trace: [  132.821017][ T1889]  dump_backtrace+0x0/0x268 [  132.825372][ T1889]  show_stack+0x20/0x2c [  132.829380][ T1889]  dump_stack+0xb4/0x108 [  132.833475][ T1889]  pgd_alloc+0x34/0x5c [  132.837396][ T1889]  mm_init+0x27c/0x32c [  132.841315][ T1889]  dup_mm+0x84/0x7b4 [  132.845061][ T1889]  copy_process+0xf20/0x24cc [  132.849500][ T1889]  _do_fork+0xa4/0x66c [  132.853420][ T1889]  __arm64_sys_clone+0x114/0x1b4 [  132.858208][ T1889]  el0_svc_handler+0x198/0x260 [  132.862821][ T1889]  el0_svc+0x8/0xc > > I surely can add pgd_alloc_kernel() to be used by the EFI code to make sure > we won't run into issues with memcg in the future. > > [   82.125966] Freeing unused kernel memory: 28672K > [   87.940365] Checked W+X mappings: passed, no W+X pages found > [   87.946769] Run /init as init process > [   88.040040] systemd[1]: System time before build time, advancing clock. > [   88.054593] systemd[1]: Failed to insert module 'autofs4': No such file or > directory > [   88.374129] modprobe (1726) used greatest stack depth: 28464 bytes left > [   88.470108] systemd[1]: systemd 239 running in system mode. (+PAM +AUDIT > +SELINUX +IMA -APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT > +GNUTLS +ACL +XZ +LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD +IDN2 -IDN +PCRE2 > default-hierarchy=legacy) > [   88.498398] systemd[1]: Detected architecture arm64. > [   88.506517] systemd[1]: Running in initial RAM disk. > [   89.621995] mkdir (1730) used greatest stack depth: 27872 bytes left > [   90.222658] random: systemd: uninitialized urandom read (16 bytes read) > [   90.230072] systemd[1]: Reached target Swap. > [   90.240205] random: systemd: uninitialized urandom read (16 bytes read) > [   90.251088] systemd[1]: Reached target Timers. > [   90.261303] random: systemd: uninitialized urandom read (16 bytes read) > [   90.271209] systemd[1]: Listening on udev Control Socket. > [   90.283238] systemd[1]: Reached target Local File Systems. > [   90.296232] systemd[1]: Reached target Slices. > [   90.307239] systemd[1]: Listening on udev Kernel Socket. > [   90.608597] kobject_add_internal failed for pgd_cache(13:init.scope) > (error: -2 parent: cgroup) > [   90.678007] kobject_add_internal failed for pgd_cache(13:init.scope)(error: > -2 parent: cgroup) > [   90.713260] kobject_add_internal failed for pgd_cache(21:systemd-tmpfiles- > setup.service) (error: -2 parent: cgroup) > [   90.820012] systemd-tmpfile (1759) used greatest stack depth: 27184 bytes > left > [   90.861942] kobject_add_internal failed for pgd_cache(13:init.scope) error: > -2 parent: cgroup) >   > > Thanks, > > Mark. > > > > [1] https://cailca.github.io/files/dmesg.txt >