From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C078EC48BE0 for ; Wed, 19 Jun 2019 20:53:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F2E82147A for ; Wed, 19 Jun 2019 20:53:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="PBQvRmU9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730452AbfFSUx1 (ORCPT ); Wed, 19 Jun 2019 16:53:27 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:44385 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbfFSUx1 (ORCPT ); Wed, 19 Jun 2019 16:53:27 -0400 Received: by mail-qt1-f196.google.com with SMTP id x47so692957qtk.11 for ; Wed, 19 Jun 2019 13:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id; bh=r1JW72QZvFM97mG3byq8Xb6t+u2a6sidb0hhLRwcOmU=; b=PBQvRmU97QmDiSH6VHDaVQhPepePHrPHYlwwQ/KedfmWFuxP7nUwqp4/gHO2vD8PXY SW9GabxMpnd0/VDvqluCZBrgba4B+TZYn77dps9SRIWk2FLlws4+lPZaBGwxR9ZgjM2C 7xwslkwmmsnwnPue83IhaipYL5eRyUk5+oWTnWae3b1fwgku785VXUP54Ar7RnMV4R3m RE9tyi1FcCXdjUJTubVkJobdiO0q/NrOpxhXAtRsHS/dMms3Qj4rgqvYQf5xhyi07dpw TqZPdrr43X0vGiK+pke37NhAY8QZWb7anvOlUJl9WUNKa1+r9pA81Myq6CsYzOWv+tym apsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=r1JW72QZvFM97mG3byq8Xb6t+u2a6sidb0hhLRwcOmU=; b=m4SQzka5YFpAD1W5vQRBcHeetANnNzKpSOgnqb7JRvPHaAn14Rk9bh4d4RxdyrKEeB Ql+FUAbBC28rY4FOuYpc8P+Pzrngruwy+saNZcvkLSmn44K/6tTAuxnJNMqv1x8l9OYj mC9Ncut6KV56AD6kzJ2D2zPE1O31RTMnxXRFKT5Kz2UQdQy3Yf323W6P/TCd8IOJrS7Z jUmwLb8QbpmsI+OV+wCoT214bESu0bVjXOFYktvJ7iTVRNkXywdCXqe/ujQsIdYAVkxA ohx5aNeoBhHK2KR4LEEz1XTPK+lobEkMtWBFQz/vqX56bqtVAKpm+KqEdNRXcY5ybhIN CBxA== X-Gm-Message-State: APjAAAWKxm9RcEeEjyJtof1UWnICF4iTU3L0dn8h+iRgv5Y8ifWKKnTL z3oeA0ptXNH2oPOmj57829c74Q== X-Google-Smtp-Source: APXvYqzoYanqwMwE8GB/pmwJLxlLQcRHAuhdcsBEYsWD0YJ/kIjmSl19ksNIX8BZAxajAHkqRUDi9g== X-Received: by 2002:a0c:acab:: with SMTP id m40mr19419150qvc.52.1560977605321; Wed, 19 Jun 2019 13:53:25 -0700 (PDT) Received: from qcai.nay.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id g2sm8477275qkm.31.2019.06.19.13.53.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Jun 2019 13:53:24 -0700 (PDT) From: Qian Cai To: akpm@linux-foundation.org Cc: guro@fb.com, vdavydov.dev@gmail.com, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH -next] mm/slab: fix an use-after-free in kmemcg_workfn() Date: Wed, 19 Jun 2019 16:52:53 -0400 Message-Id: <1560977573-10715-1-git-send-email-cai@lca.pw> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The linux-next commit "mm: rework non-root kmem_cache lifecycle management" [1] introduced an use-after-free below because kmemcg_workfn() may call slab_kmem_cache_release() which has already freed the whole kmem_cache. Fix it by removing the bogus NULL assignment and checkings that will not work with SLUB_DEBUG poisoning anyway. [1] https://lore.kernel.org/patchwork/patch/1087376/ BUG kmem_cache (Tainted: G B W ): Poison overwritten INFO: 0x(____ptrval____)-0x(____ptrval____). First byte 0x0 instead of 0x6b INFO: Allocated in create_cache+0x6c/0x1bc age=2653 cpu=154 pid=1599 kmem_cache_alloc+0x514/0x568 create_cache+0x6c/0x1bc memcg_create_kmem_cache+0xfc/0x11c memcg_kmem_cache_create_func+0x40/0x170 process_one_work+0x4e0/0xa54 worker_thread+0x498/0x650 kthread+0x1b8/0x1d4 ret_from_fork+0x10/0x18 INFO: Freed in slab_kmem_cache_release+0x3c/0x48 age=255 cpu=7 pid=1505 slab_kmem_cache_release+0x3c/0x48 kmem_cache_release+0x1c/0x28 kobject_cleanup+0x134/0x288 kobject_put+0x5c/0x68 sysfs_slab_release+0x2c/0x38 shutdown_cache+0x190/0x234 kmemcg_cache_shutdown_fn+0x1c/0x34 kmemcg_workfn+0x44/0x68 process_one_work+0x4e0/0xa54 worker_thread+0x498/0x650 kthread+0x1b8/0x1d4 ret_from_fork+0x10/0x18 INFO: Slab 0x(____ptrval____) objects=64 used=64 fp=0x(____ptrval____) flags=0x17ffffffc000200 INFO: Object 0x(____ptrval____) @offset=11601272640106456192 fp=0x(____ptrval____) Redzone (____ptrval____): bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb ................ Redzone (____ptrval____): bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb ................ Redzone (____ptrval____): bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb ................ Redzone (____ptrval____): bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb ................ Redzone (____ptrval____): bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb ................ Redzone (____ptrval____): bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb ................ Redzone (____ptrval____): bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb ................ Redzone (____ptrval____): bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb bb ................ Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 00 00 00 00 00 00 00 00 kkkkkkkk........ Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b kkkkkkkkkkkkkkkk Object (____ptrval____): 6b 6b 6b 6b 6b 6b 6b a5 kkkkkkk. Redzone (____ptrval____): bb bb bb bb bb bb bb bb ........ Padding (____ptrval____): 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZZZZZZZZZ Padding (____ptrval____): 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZZZZZZZZZ Padding (____ptrval____): 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZZZZZZZZZ Padding (____ptrval____): 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZZZZZZZZZ Padding (____ptrval____): 5a 5a 5a 5a 5a 5a 5a 5a ZZZZZZZZ CPU: 193 PID: 1557 Comm: kworker/193:1 Tainted: G B W 5.2.0-rc5-next-20190619+ #8 Hardware name: HPE Apollo 70 /C01_APACHE_MB , BIOS L50_5.13_1.0.9 03/01/2019 Workqueue: memcg_kmem_cache memcg_kmem_cache_create_func Call trace: dump_backtrace+0x0/0x268 show_stack+0x20/0x2c dump_stack+0xb4/0x108 print_trailer+0x274/0x298 check_bytes_and_report+0xc4/0x118 check_object+0x2fc/0x36c alloc_debug_processing+0x154/0x240 ___slab_alloc+0x710/0xa68 kmem_cache_alloc+0x514/0x568 create_cache+0x6c/0x1bc memcg_create_kmem_cache+0xfc/0x11c memcg_kmem_cache_create_func+0x40/0x170 process_one_work+0x4e0/0xa54 worker_thread+0x498/0x650 kthread+0x1b8/0x1d4 ret_from_fork+0x10/0x18 FIX kmem_cache: Restoring 0x(____ptrval____)-0x(____ptrval____)=0x6b FIX kmem_cache: Marking all objects used Signed-off-by: Qian Cai --- mm/slab_common.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/slab_common.c b/mm/slab_common.c index 91e8c739dc97..bb8aec6d8744 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -714,10 +714,7 @@ static void kmemcg_workfn(struct work_struct *work) get_online_mems(); mutex_lock(&slab_mutex); - s->memcg_params.work_fn(s); - s->memcg_params.work_fn = NULL; - mutex_unlock(&slab_mutex); put_online_mems(); @@ -753,7 +750,6 @@ static void kmemcg_cache_shutdown(struct percpu_ref *percpu_ref) if (s->memcg_params.root_cache->memcg_params.dying) goto unlock; - WARN_ON(s->memcg_params.work_fn); s->memcg_params.work_fn = kmemcg_cache_shutdown_fn; INIT_WORK(&s->memcg_params.work, kmemcg_workfn); queue_work(memcg_kmem_cache_wq, &s->memcg_params.work); @@ -784,7 +780,6 @@ static void kmemcg_cache_deactivate(struct kmem_cache *s) if (s->memcg_params.root_cache->memcg_params.dying) goto unlock; - WARN_ON_ONCE(s->memcg_params.work_fn); s->memcg_params.work_fn = kmemcg_cache_deactivate_after_rcu; call_rcu(&s->memcg_params.rcu_head, kmemcg_rcufn); unlock: -- 1.8.3.1