From: Ley Foon Tan <ley.foon.tan@intel.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
Ley Foon Tan <lftan@altera.com>,
nios2-dev@lists.rocketboards.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nios2: remove pointless second entry for CONFIG_TRACE_IRQFLAGS_SUPPORT
Date: Tue, 25 Jun 2019 09:49:34 +0800 [thread overview]
Message-ID: <1561427374.3131.2.camel@intel.com> (raw)
In-Reply-To: <CAK7LNATViOYXJVLuJ8VnCruyMAPbYOkTc_0ZuW+gqi5H9x9-cA@mail.gmail.com>
On Sun, 2019-06-23 at 23:13 +0900, Masahiro Yamada wrote:
> On Sun, May 12, 2019 at 10:16 PM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
> >
> >
> > Strangely enough, NIOS2 defines TRACE_IRQFLAGS_SUPPORT twice
> > with different values, which is pointless and confusing.
> >
> > [1] arch/nios2/Kconfig
> >
> > config TRACE_IRQFLAGS_SUPPORT
> > def_bool n
> >
> > [2] arch/nios2/Kconfig.debug
> >
> > config TRACE_IRQFLAGS_SUPPORT
> > def_bool y
> >
> > [1] is included before [2]. In the Kconfig syntax, the first one
> > is effective. So, TRACE_IRQFLAGS_SUPPORT is always 'n'.
> >
> > The second define in arch/nios2/Kconfig.debug is dead code.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
> Ping.
>
>
Acked-by: Ley Foon Tan <ley.foon.tan@intel.com>
Will integrate to next kernel version.
Thanks.
> >
> > arch/nios2/Kconfig.debug | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/arch/nios2/Kconfig.debug b/arch/nios2/Kconfig.debug
> > index f1da8a7..a8bc06e 100644
> > --- a/arch/nios2/Kconfig.debug
> > +++ b/arch/nios2/Kconfig.debug
> > @@ -1,8 +1,5 @@
> > # SPDX-License-Identifier: GPL-2.0
> >
> > -config TRACE_IRQFLAGS_SUPPORT
> > - def_bool y
> > -
> > config EARLY_PRINTK
> > bool "Activate early kernel debugging"
> > default y
> > --
> > 2.7.4
> >
>
> --
> Best Regards
> Masahiro Yamada
>
> ________________________________
Regards
Ley Foon
prev parent reply other threads:[~2019-06-25 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 13:12 [PATCH] nios2: remove pointless second entry for CONFIG_TRACE_IRQFLAGS_SUPPORT Masahiro Yamada
2019-06-23 14:13 ` Masahiro Yamada
2019-06-25 1:49 ` Ley Foon Tan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561427374.3131.2.camel@intel.com \
--to=ley.foon.tan@intel.com \
--cc=lftan@altera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nios2-dev@lists.rocketboards.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).