linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Raslan, KarimAllah" <karahmed@amazon.de>
To: "tglx@linutronix.de" <tglx@linutronix.de>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>
Cc: "boris.ostrovsky@oracle.com" <boris.ostrovsky@oracle.com>,
	"joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"kernellwp@gmail.com" <kernellwp@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mtosatti@redhat.com" <mtosatti@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"ankur.a.arora@oracle.com" <ankur.a.arora@oracle.com>,
	"rkrcmar@redhat.com" <rkrcmar@redhat.com>
Subject: Re: cputime takes cstate into consideration
Date: Wed, 26 Jun 2019 18:55:36 +0000	[thread overview]
Message-ID: <1561575336.25880.7.camel@amazon.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1906262038040.32342@nanos.tec.linutronix.de>

On Wed, 2019-06-26 at 20:41 +0200, Thomas Gleixner wrote:
> On Wed, 26 Jun 2019, Konrad Rzeszutek Wilk wrote:
> > 
> > On Wed, Jun 26, 2019 at 06:16:08PM +0200, Peter Zijlstra wrote:
> > > 
> > > On Wed, Jun 26, 2019 at 10:54:13AM -0400, Konrad Rzeszutek Wilk wrote:
> > > > 
> > > > There were some ideas that Ankur (CC-ed) mentioned to me of using the perf
> > > > counters (in the host) to sample the guest and construct a better
> > > > accounting idea of what the guest does. That way the dashboard
> > > > from the host would not show 100% CPU utilization.
> > > 
> > > But then you generate extra noise and vmexits on those cpus, just to get
> > > this accounting sorted, which sounds like a bad trade.
> > 
> > Considering that the CPUs aren't doing anything and if you do say the 
> > IPIs "only" 100/second - that would be so small but give you a big benefit
> > in properly accounting the guests.
> 
> The host doesn't know what the guest CPUs are doing. And if you have a full
> zero exit setup and the guest is computing stuff or doing that network
> offloading thing then they will notice the 100/s vmexits and complain.

If the host is completely in no_full_hz mode and the pCPU is dedicated to a 
single vCPU/task (and the guest is 100% CPU bound and never exits), you would 
still be ticking in the host once every second for housekeeping, right? Would 
not updating the mwait-time once a second be enough here?

> 
> > 
> > But perhaps there are other ways too to "snoop" if a guest is sitting on
> > an MWAIT?
> 
> No idea.
> 
> Thanks,
> 
> 	tglx
> 
> 



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879



  reply	other threads:[~2019-06-26 18:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26  9:43 cputime takes cstate into consideration Wanpeng Li
2019-06-26 10:13 ` Peter Zijlstra
2019-06-26 10:33 ` Thomas Gleixner
2019-06-26 14:54   ` Konrad Rzeszutek Wilk
2019-06-26 16:16     ` Peter Zijlstra
2019-06-26 18:30       ` Konrad Rzeszutek Wilk
2019-06-26 18:41         ` Thomas Gleixner
2019-06-26 18:55           ` Raslan, KarimAllah [this message]
2019-06-26 19:19             ` Thomas Gleixner
2019-06-26 19:21             ` Peter Zijlstra
2019-06-26 19:27               ` Raslan, KarimAllah
2019-06-26 19:32                 ` Thomas Gleixner
2019-06-26 20:01                 ` Peter Zijlstra
2019-06-26 20:09                   ` Thomas Gleixner
2019-12-10  0:44                 ` Wanpeng Li
2019-06-26 19:29               ` Thomas Gleixner
2019-06-26 18:58     ` Raslan, KarimAllah
2019-06-26 19:23       ` Thomas Gleixner
2019-07-09  2:00         ` Ankur Arora
2019-07-09  2:06           ` Wanpeng Li
2019-07-09 12:38           ` Peter Zijlstra
2019-07-09 18:27             ` Ankur Arora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1561575336.25880.7.camel@amazon.de \
    --to=karahmed@amazon.de \
    --cc=ankur.a.arora@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=joao.m.martins@oracle.com \
    --cc=kernellwp@gmail.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rkrcmar@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).