From: CK Hu <ck.hu@mediatek.com>
To: Derek Basehore <dbasehore@chromium.org>
Cc: <linux-kernel@vger.kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sam Ravnborg <sam@ravnborg.org>,
<intel-gfx@lists.freedesktop.org>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
David Airlie <airlied@linux.ie>,
"Thierry Reding" <thierry.reding@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
<dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel@ffwll.ch>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
<linux-mediatek@lists.infradead.org>, Sean Paul <sean@poorly.run>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 4/4] drm/mtk: add panel orientation property
Date: Mon, 1 Jul 2019 09:59:19 +0800 [thread overview]
Message-ID: <1561946359.23228.0.camel@mtksdaap41> (raw)
In-Reply-To: <20190622034105.188454-5-dbasehore@chromium.org>
Hi, Derek:
On Fri, 2019-06-21 at 20:41 -0700, Derek Basehore wrote:
> This inits the panel orientation property for the mediatek dsi driver
> if the panel orientation (connector.display_info.panel_orientation) is
> not DRM_MODE_PANEL_ORIENTATION_UNKNOWN.
>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
> Signed-off-by: Derek Basehore <dbasehore@chromium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 4a0b9150a7bb..08ffdc7526dd 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -782,10 +782,18 @@ static int mtk_dsi_create_connector(struct drm_device *drm, struct mtk_dsi *dsi)
> DRM_ERROR("Failed to attach panel to drm\n");
> goto err_connector_cleanup;
> }
> +
> + ret = drm_connector_init_panel_orientation_property(&dsi->conn);
> + if (ret) {
> + DRM_ERROR("Failed to init panel orientation\n");
> + goto err_panel_detach;
> + }
> }
>
> return 0;
>
> +err_panel_detach:
> + drm_panel_detach(dsi->panel);
> err_connector_cleanup:
> drm_connector_cleanup(&dsi->conn);
> return ret;
next prev parent reply other threads:[~2019-07-01 1:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-22 3:41 [PATCH v3 0/4] Panel rotation patches Derek Basehore
2019-06-22 3:41 ` [PATCH v3 1/4] drm/panel: Add helper for reading DT rotation Derek Basehore
2019-06-24 20:36 ` Sam Ravnborg
2019-06-25 22:12 ` dbasehore .
2019-06-22 3:41 ` [PATCH v3 2/4] drm/panel: set display info in panel attach Derek Basehore
2019-06-24 23:04 ` dbasehore .
2019-06-22 3:41 ` [PATCH v3 3/4] drm/connector: Split out orientation quirk detection Derek Basehore
2019-06-23 12:11 ` [Intel-gfx] " Hans de Goede
2019-06-24 13:24 ` Ville Syrjälä
2019-07-02 3:24 ` dbasehore .
2019-06-22 3:41 ` [PATCH v4 4/4] drm/mtk: add panel orientation property Derek Basehore
2019-07-01 1:59 ` CK Hu [this message]
2019-07-02 23:42 [PATCH v4 0/4] Panel rotation patches Derek Basehore
2019-07-02 23:42 ` [PATCH v4 4/4] drm/mtk: add panel orientation property Derek Basehore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561946359.23228.0.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dbasehore@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@bootlin.com \
--cc=p.zabel@pengutronix.de \
--cc=rodrigo.vivi@intel.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).