From: Qii Wang <qii.wang@mediatek.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: <linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>,
<matthias.bgg@gmail.com>, <robh+dt@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: i2c: Add MediaTek i2c AC timing binding
Date: Wed, 17 Jul 2019 20:55:21 +0800 [thread overview]
Message-ID: <1563368121.16970.7.camel@mhfsdcap03> (raw)
In-Reply-To: <20190626133941.GL801@ninjato>
On Wed, 2019-06-26 at 15:39 +0200, Wolfram Sang wrote:
> Hi,
>
> On Tue, Jun 11, 2019 at 04:11:54PM +0800, Qii Wang wrote:
> > Add i2c AC timing binding to binding file. It can give the AC
> > timing parameters to meet I2C specification at different speed.
> >
> > Signed-off-by: Qii Wang <qii.wang@mediatek.com>
>
> I think this is a too specific 1:1 mapping of your register set into DT
> world. We already have these generic parameters:
>
> - clock-frequency
> frequency of bus clock in Hz.
>
> - i2c-scl-falling-time-ns
> Number of nanoseconds the SCL signal takes to fall; t(f) in the I2C
> specification.
>
> - i2c-scl-internal-delay-ns
> Number of nanoseconds the IP core additionally needs to setup SCL.
>
> - i2c-scl-rising-time-ns
> Number of nanoseconds the SCL signal takes to rise; t(r) in the I2C
> specification.
>
> - i2c-sda-falling-time-ns
> Number of nanoseconds the SDA signal takes to fall; t(f) in the I2C
> specification.
>
> (check Documentation/devicetree/bindings/i2c/i2c.txt)
>
> Can't you use those to derive your values from that? Which ones are you missing
> if not?
>
> Regards,
>
> Wolfram
I have take a little time to develop a new patch which based on your
suggestions, and it tested OK. Thanks for your suggestions, I will
update the patch after I test it fully.
next prev parent reply other threads:[~2019-07-17 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 8:11 [PATCH 0/2] Add support for AC timing adjustment Qii Wang
2019-06-11 8:11 ` [PATCH 1/2] dt-bindings: i2c: Add MediaTek i2c AC timing binding Qii Wang
2019-06-26 13:39 ` Wolfram Sang
2019-07-17 12:55 ` Qii Wang [this message]
2019-07-17 13:29 ` Wolfram Sang
2019-06-11 8:11 ` [PATCH 2/2] i2c: mediatek: Add i2c AC timing adjust support Qii Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563368121.16970.7.camel@mhfsdcap03 \
--to=qii.wang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).