From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E348C76191 for ; Wed, 24 Jul 2019 05:04:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7047B227BF for ; Wed, 24 Jul 2019 05:04:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726215AbfGXFEL (ORCPT ); Wed, 24 Jul 2019 01:04:11 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:59979 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725870AbfGXFEL (ORCPT ); Wed, 24 Jul 2019 01:04:11 -0400 X-UUID: e0f47eec30464f22bd9e18ba89f1f95a-20190724 X-UUID: e0f47eec30464f22bd9e18ba89f1f95a-20190724 Received: from mtkmrs01.mediatek.inc [(172.21.131.159)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 29376682; Wed, 24 Jul 2019 13:04:03 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 24 Jul 2019 13:04:02 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 24 Jul 2019 13:04:02 +0800 Message-ID: <1563944642.13531.0.camel@mtkswgap22> Subject: Re: [PATCH v4 2/3] dt-bindings: rng: add bindings for MediaTek ARMv8 SoCs From: Neal Liu To: Rob Herring CC: Mark Rutland , "devicetree@vger.kernel.org" , Herbert Xu , wsd_upstream , Sean Wang , "linux-kernel@vger.kernel.org" , Crystal Guo =?UTF-8?Q?=28=E9=83=AD=E6=99=B6=29?= , "linux-crypto@vger.kernel.org" , Matt Mackall , Matthias Brugger , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Date: Wed, 24 Jul 2019 13:04:02 +0800 In-Reply-To: References: <1561361052-13072-1-git-send-email-neal.liu@mediatek.com> <1561361052-13072-3-git-send-email-neal.liu@mediatek.com> <20190722171320.GA9806@bogus> <1563848465.31451.4.camel@mtkswgap22> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-07-23 at 08:35 -0600, Rob Herring wrote: > On Mon, Jul 22, 2019 at 8:21 PM Neal Liu wrote: > > > > Please don't top post to lists. > > > Dear Rob, > > You can check my driver for detail: > > http://patchwork.kernel.org/patch/11012475/ or patchset 3/3 > > I could, or you could just answer my question. > > > > > This driver is registered as hardware random number generator, and > > combines with rng-core. > > We want to add one rng hw based on the dts. Is this proper or do you > > have other suggestion to meet this requirement? > > It depends. There doesn't appear to be any resource configuration, so > why does it need to be in DT. DT is not the only way instantiate > drivers. > > Rob This hwrng is only supported on some chipsets. It needs DT to identify which platform is supported or not. Is there any better idea to meet this requirement? Neal > > > > Thanks > > > > > > On Tue, 2019-07-23 at 01:13 +0800, Rob Herring wrote: > > > On Mon, Jun 24, 2019 at 03:24:11PM +0800, Neal Liu wrote: > > > > Document the binding used by the MediaTek ARMv8 SoCs random > > > > number generator with TrustZone enabled. > > > > > > > > Signed-off-by: Neal Liu > > > > --- > > > > .../devicetree/bindings/rng/mtk-sec-rng.txt | 10 ++++++++++ > > > > 1 file changed, 10 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/rng/mtk-sec-rng.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/rng/mtk-sec-rng.txt b/Documentation/devicetree/bindings/rng/mtk-sec-rng.txt > > > > new file mode 100644 > > > > index 0000000..c04ce15 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/rng/mtk-sec-rng.txt > > > > @@ -0,0 +1,10 @@ > > > > +MediaTek random number generator with TrustZone enabled > > > > + > > > > +Required properties: > > > > +- compatible : Should be "mediatek,mtk-sec-rng" > > > > > > What's the interface to access this? > > > > > > A node with a 'compatible' and nothing else is a sign of something that > > > a parent device should instantiate and doesn't need to be in DT. IOW, > > > what do complete bindings for firmware functions look like? > > > > > > > + > > > > +Example: > > > > + > > > > +hwrng: hwrng { > > > > + compatible = "mediatek,mtk-sec-rng"; > > > > +} > > > > -- > > > > 1.7.9.5 > > > > > > > > > > _______________________________________________ > > > Linux-mediatek mailing list > > > Linux-mediatek@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-mediatek > > > >