* [PATCH] gpio: just plain warning when nonexisting gpio requested
@ 2019-07-29 14:36 Enrico Weigelt, metux IT consult
2019-07-30 8:19 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-07-29 14:36 UTC (permalink / raw)
To: linux-kernel; +Cc: linus.walleij, bgolaszewski, linux-gpio
From: Enrico Weigelt <info@metux.net>
When trying to export an nonexisting gpio ID, the kernel prints
outs a big warning w/ stacktrace, sounding like a huge problem.
In fact it's a pretty normal situation, like file or device not
found.
So, just print a more relaxed warning instead.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/gpio/gpiolib.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 3ee99d0..06eeedd 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1,4 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
#include <linux/bitmap.h>
#include <linux/kernel.h>
#include <linux/module.h>
@@ -121,7 +124,7 @@ struct gpio_desc *gpio_to_desc(unsigned gpio)
spin_unlock_irqrestore(&gpio_lock, flags);
if (!gpio_is_valid(gpio))
- WARN(1, "invalid GPIO %d\n", gpio);
+ pr_warn("invalid GPIO %d\n", gpio);
return NULL;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: just plain warning when nonexisting gpio requested
2019-07-29 14:36 [PATCH] gpio: just plain warning when nonexisting gpio requested Enrico Weigelt, metux IT consult
@ 2019-07-30 8:19 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2019-07-30 8:19 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult; +Cc: LKML, Linus Walleij, linux-gpio
pon., 29 lip 2019 o 16:41 Enrico Weigelt, metux IT consult
<info@metux.net> napisał(a):
>
> From: Enrico Weigelt <info@metux.net>
>
> When trying to export an nonexisting gpio ID, the kernel prints
> outs a big warning w/ stacktrace, sounding like a huge problem.
> In fact it's a pretty normal situation, like file or device not
> found.
>
> So, just print a more relaxed warning instead.
>
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
> drivers/gpio/gpiolib.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 3ee99d0..06eeedd 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1,4 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
While adding pr_fmt would make sense for gpiolib in general, it
changes all the already existing pr_* log messages in gpiolib.c. This
has nothing to do with this patch. Please use a regular pr_warn() and
then we can think about simplifying the messages in general.
Bart
> #include <linux/bitmap.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> @@ -121,7 +124,7 @@ struct gpio_desc *gpio_to_desc(unsigned gpio)
> spin_unlock_irqrestore(&gpio_lock, flags);
>
> if (!gpio_is_valid(gpio))
> - WARN(1, "invalid GPIO %d\n", gpio);
> + pr_warn("invalid GPIO %d\n", gpio);
>
> return NULL;
> }
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-30 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29 14:36 [PATCH] gpio: just plain warning when nonexisting gpio requested Enrico Weigelt, metux IT consult
2019-07-30 8:19 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).