* [PATCH] myri10ge: remove unneeded variable
@ 2019-07-31 8:53 Ding Xiang
2019-07-31 15:44 ` David Miller
2019-08-08 5:31 ` Jesse Brandeburg
0 siblings, 2 replies; 3+ messages in thread
From: Ding Xiang @ 2019-07-31 8:53 UTC (permalink / raw)
To: christopher.lee, davem; +Cc: netdev, linux-kernel
"error" is unneeded,just return 0
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index d8b7fba..a4165e1 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -3037,7 +3037,6 @@ static int myri10ge_set_mac_address(struct net_device *dev, void *addr)
static int myri10ge_change_mtu(struct net_device *dev, int new_mtu)
{
struct myri10ge_priv *mgp = netdev_priv(dev);
- int error = 0;
netdev_info(dev, "changing mtu from %d to %d\n", dev->mtu, new_mtu);
if (mgp->running) {
@@ -3049,7 +3048,7 @@ static int myri10ge_change_mtu(struct net_device *dev, int new_mtu)
} else
dev->mtu = new_mtu;
- return error;
+ return 0;
}
/*
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] myri10ge: remove unneeded variable
2019-07-31 8:53 [PATCH] myri10ge: remove unneeded variable Ding Xiang
@ 2019-07-31 15:44 ` David Miller
2019-08-08 5:31 ` Jesse Brandeburg
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-07-31 15:44 UTC (permalink / raw)
To: dingxiang; +Cc: christopher.lee, netdev, linux-kernel
From: Ding Xiang <dingxiang@cmss.chinamobile.com>
Date: Wed, 31 Jul 2019 16:53:46 +0800
> "error" is unneeded,just return 0
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] myri10ge: remove unneeded variable
2019-07-31 8:53 [PATCH] myri10ge: remove unneeded variable Ding Xiang
2019-07-31 15:44 ` David Miller
@ 2019-08-08 5:31 ` Jesse Brandeburg
1 sibling, 0 replies; 3+ messages in thread
From: Jesse Brandeburg @ 2019-08-08 5:31 UTC (permalink / raw)
To: Ding Xiang; +Cc: christopher.lee, davem, netdev, linux-kernel, jesse.brandeburg
On Wed, 31 Jul 2019 16:53:46 +0800
Ding Xiang <dingxiang@cmss.chinamobile.com> wrote:
> "error" is unneeded,just return 0
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-08 5:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 8:53 [PATCH] myri10ge: remove unneeded variable Ding Xiang
2019-07-31 15:44 ` David Miller
2019-08-08 5:31 ` Jesse Brandeburg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).