From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932571AbcKGPoW (ORCPT ); Mon, 7 Nov 2016 10:44:22 -0500 Received: from mx144.netapp.com ([216.240.21.25]:36280 "EHLO mx144.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932181AbcKGPoT (ORCPT ); Mon, 7 Nov 2016 10:44:19 -0500 X-IronPort-AV: E=Sophos;i="5.31,606,1473145200"; d="scan'208";a="156294333" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anna.Schumaker@netapp.com; Subject: Re: [PATCH] net/netfiliter: Fix used uninitialized warn in ip_vs_proc_sync_conn() To: Shuah Khan , References: <20161107154114.26803-1-shuahkh@osg.samsung.com> <20161107154114.26803-3-shuahkh@osg.samsung.com> CC: , From: Anna Schumaker Message-ID: <15645b18-f0ec-81f5-61ed-da8c141e5110@Netapp.com> Date: Mon, 7 Nov 2016 10:44:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161107154114.26803-3-shuahkh@osg.samsung.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [99.9.112.69] X-ClientProxiedBy: CY1PR10CA0024.namprd10.prod.outlook.com (10.162.208.34) To BLUPR0601MB1635.namprd06.prod.outlook.com (10.163.212.141) X-MS-Office365-Filtering-Correlation-Id: fb33052f-39bd-450f-ef8f-08d40724ee8f X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;2:HyuZfTU0aMbpqUx7dmAECbOY0MVox+3mhUVTNif8wXXJv+JrJ8GUlZQoKjtObpxPbY9NjmEYeAqj6vloALlWUwNn7lqLDUjSv3ZB+5A/Xca/+eS5iXAwj7mONy1jqF3wfOB9xk0IU8uU12K8gLX9O8HUYG3G/gtfmLwo7gnAyIW+kYek+VPm9jX3GFUEzvM0Lhakwk2A0wGnhkSdljeP5w==;3:pDYSOghZ5JCyvYdKK7UfVaWlPHaA+pZFlgfX3dOhk+Odk+7+Qtq2Q105if/FtrCtgKo7PIIZ7o4xlKcLdCR0gdk35BruEJITgmx4ITf00cRHKvFmxaSzgOGjRuK5mHG744lqqM6jS2JhozDkcxbDFw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0601MB1635; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;25:HCi7O4NtNGLSRu8dce3NXFmlTXx1cIh/rZq+GZ2SLcxQ1FRQHzFZeePQrrr66oxWv9po1ilaQAhCxfMgxC8EaohKd18A6fIIl9sVzn5lVgASK9h+OV2q+lvugdtd06XS/b9OIDbJ/Ds2UdFnk4MqeD86D1sogQ/LrOT66969HYxVpzOn4YSREUhe54rAdGYBatkE/NCRyVHal1Ja1QzL/fVtAMspSwlqUDRDJ6iegXOvmFRKUIchcPpJwc/1Dszvodjpmdv1RQso+F3W005aJLS2WRjPKkxilzebDmn7t2y58l4I0np4ieosRbISHktnjOrIsMi8l2zZaD+zPqiesXtCwkEJd/rRXaodFKh+c+s1rPiIXHTLMMKbK/km85payFCQfg8TBUKz2wl8DDF4kOKcosBe5t/O4lui6NW8sLiJBbo2PrAK8np3N65ibyzNh80Koj6+t6YXft+g4n1GnlsnpRv5RcfDq8rkPwxYaBtK/8FjLoYgxneNYFfZiQNZxaNXgKBJDS3o/JzgDxu2PfAQofph3dD+8hGsyRSliga9JSufrSY2O9Aj3awL68Lm17Iahzkg0nD0xRErB7HYKEVfknMlfSIWwj8sGKyxpY4GQf080on/BlLD3h3lKkuvXmpCykLrF7caF9yj2XeZ31FDYOUVP76CysbfZwa10lGc46MUy8iwPdGTgS+74zj+y+LzrpSIn6+cNuQvn28gHAoj8BYa7bj9ScIV+GaWBgCHU1J3LhPIcokC2U0xq4kw32BU9FjN5081ErYJtJtOWg== X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;31:gZ1pQWv8DnZugVNRkQE7Q+y0Zl8i1Qg6iSLSoYVNbTB946/qcxo3L+f24ll9YWeyrZMn/p0m+jmCCQe78xX+qVUxoo3uxObCPtX3O4qBppdtz1+VqppvPJkYylFFtps+JvPqhmHTHTOSt/Ay7JmClPuuocNccEx1M5f7/GLx1cZFKUYTGr49h+JU3k4ddE5Af5SntMqqqIO+G6tQ7xRavHtmuaAi7GmL4EQOcuB64IY3WRT1lBDM4mEsUstlrj2e;20:pO0fyjJ7PXJ+a3Rj3N/MlNkNwJIv06b/YNPlF9ZCwYffTJUB98MHMAE5gdX0Hdq28kpF0ggFYG9QD6N5rhK3drFxFEi/HsBrtn4kqFPY6qrWgkg14Kt3E1p6H4v3/9y9eWOEoGRo7LXZKzRQyqmKWRLrE1Fd4CZoTTdK5ubkE5L6+nTNpKw+dpeOECtHYeI0eyGYQtW1G15hMJYqWB2hdLHW6yP9oZuc6ffX4CkCFY30dvYxJOHUvWZgLlv5Nc+g8IkYEsuBa3j5SB+kb6Nz4kHpGfnpafprXpZc3pVSUVfwbdcQx66EfrZsgdEIVS13ff7d0b5VnfkDgv30KKIVT6atcekDMlTbN521el7/Cd74zfyGd97F8qrKX2djXBjh5XasYAt4a4D8njfmwPdYj2dg1CdOq8N0oQA4dTsAlKycg/WYL5LBdPz1lHZetuI+LnsmPf8PUUUeuwbzwewd++UX4LpiEolSapnEmexeSEnXqLE9M0cDHYaJ01vvelGr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(7411616537696); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6042046)(6043046);SRVR:BLUPR0601MB1635;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0601MB1635; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;4:mZKzTpOoHWTJbDviDJZVKY7tNy7vIFTw+Sx707//IGQP8HB4rAqccoXUzMMDkZLimOWUxEek70ZsNNL1XmyHtTsFMqcdbDQm0ztIwEDf/TIjbluObkYzO9EUuVS5EJcEWQACm7QLqMIpZNqkf6ot8BDTMuV94QXL5Mq+jjXDhXuj18BO1hsWFZbeTq7b4BqiO6QZCh6gqeHbPgQihlEsmakC0XJKqRxVD5QSbXFDKGesaGyaRn5wjJbZglm0NSNaoTK5veUDjGe+H6mO75dzkSm9IILV+YhB2Iq2dTr2dhLAeSxjyYENGJOkkE6g6Z4s7rrBj8v07/CuzA//TK5ktsZnMTno9mU1ei3yte+Yw8j/Hj7/z6/0ASMFwBCqP8zkBBp8xB1VWvb9/PR8EG4W7II5qbsPcV/QPJ7kUHrQNb2qCYqInzn1EI6SiANAdFjPFlcAPKvHKnP/xIVeGrXwCCkd1y24lW6MIAP62pApIzs= X-Forefront-PRVS: 0119DC3B5E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(199003)(377454003)(189002)(2870700001)(66066001)(586003)(47776003)(6116002)(3846002)(2906002)(2950100002)(65826007)(4326007)(7846002)(83506001)(68736007)(81166006)(81156014)(189998001)(65806001)(65956001)(8676002)(36756003)(31696002)(50986999)(7736002)(101416001)(50466002)(305945005)(97736004)(33646002)(86362001)(69596002)(4001350100001)(23676002)(19580405001)(19580395003)(5001770100001)(92566002)(64126003)(77096005)(6666003)(5660300001)(105586002)(106356001)(76176999)(54356999)(42186005)(31686004)(53416004);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0601MB1635;H:gouda.nowheycreamery.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjA2MDFNQjE2MzU7MjM6RnNKMDdRZVZzZVpKQ094cGR3Si9GSGQ5?= =?utf-8?B?aWlhcHN4ZnBBaEVEK0ljNXptMng4aDBxTzRIQ25KaUZDczdSQXYzbG5taEhO?= =?utf-8?B?VkZrdGNvTUtWZ2JpbmVtSWVzMWdJZFBoV0thenhBNk9tZ1RhTDI2aGY1dnRa?= =?utf-8?B?L0RvVVRTMkpOVVBMTng1UTFCemdwcTBUbVNmNHlBdXlTVFRXZ2VVMmlsa29B?= =?utf-8?B?SW9HcnJxWUROZXpncmx2SVQwYjBGdGVKVE1qbkFXYWc4Q2F5ZjRJaWtlUis5?= =?utf-8?B?NzNMcXlnckZiVVp6TVZpbm90UWJqYWZDV1ZnZ3hhMktldDV0YnJCenYwdEVZ?= =?utf-8?B?YzVVNlRtcHF5N3MrNEwvUFk3VldaYlUrTCt6R0RDWkVVdjRZdTVKb2doK29t?= =?utf-8?B?L1o4eEplTWhBdFYyMFFWUUxhSy9QTmt6KzFtaW53cmNha01qb1FmQm9JNnVW?= =?utf-8?B?WWZJSU4wTzhKOGt6UjB0NzFpMldaTWFDaVVmM2FNU0ZSOTdtK3I4N3F4dDFF?= =?utf-8?B?TUlIL29yZ1ZWWVdGTTJ4dThyN1djMzh3SzJrYXRWVzc0Yk0xWFdGNitwR3dI?= =?utf-8?B?SWNmK1h0ZkFmYk5GdVRiYjFDVGdPNVoxR3FETm9Yd2tBb2szMUxLb1B2MG16?= =?utf-8?B?M1M0YnQyQ3hOZStScXI4dEE4RUtpSzVzT0ZkbmQrcHpocWF2bmM1emF2YVJE?= =?utf-8?B?OHZuSnUyOUNpZnA4d1pocVV6ZzdVRFNnMzkxQ2tsd3lvL29jNTR6OXNYbEhM?= =?utf-8?B?dWgwajJqdnhaOGYxU3Y3S01pbFIxN3gvZnAxd29vV09sMWxSV3BrdTZocHNU?= =?utf-8?B?eEp1OXEraDkyK3ZTVXE2c1J1R1J0L3JXc24xdEM0QkNLclI0WHViUDltbVlC?= =?utf-8?B?TXdtNWp1b0VzR0dySTFIYjhJa2NKMUhpcldZUnRjQUlHSEwxK21WZzgxaWdw?= =?utf-8?B?Znk2SDNFM3gzVW8weEZBRGN0Z0JTZnUrQTZrRDNVYzFCbkQzQUdDQlduSFNa?= =?utf-8?B?Snk1K0VVcXJVYUtld0FuU3Rod3JKNDk4bHNsY0NIMzJHcHo2c3V2S2h2ZExj?= =?utf-8?B?bTF2N1NEWE5DR0pMaGUxMmd2TVFyNGp6WFFPeGFmKytZTmw4RXFNQ0pxRm5O?= =?utf-8?B?ZGRwUkg0L3pIbUdubU0wL1d0bzloOVRLV2hHbEJscmYyUGtLT2NrTDA0TnV5?= =?utf-8?B?anB6clFydVdMZ0c0d0U1UkFZTEhEMzBYTkJJZGZxMWdVWWNGTytMenlPY0FG?= =?utf-8?B?bm52SS9vajZmU3ovY3VGdDY2U1ZKdDNRLzBsTmhNVGVqOTBzbExhYXdWTTZw?= =?utf-8?B?S2tTSFJpbWJDT3dHV0JrdnozOWZheHNaNG54V09oWXRaR0pFa2pybis1dmsv?= =?utf-8?B?WEduMmU1RHl4ZkNIczUxN01DNGpMcXhYb2tvZmJIOE5oOHBnWmZVZG5pd2Ew?= =?utf-8?B?dE9VV1JacHJUNGg2clBlUVo1aHJaT1hXZEJvODZyY3ZyK0ZJV2tLbzFHRFR4?= =?utf-8?B?dSttWnlEdVpDVjE0akR6YmlZemJCcE5UMHU2OWRIbGRPVERsZzYwaFcvUnFh?= =?utf-8?B?NmcxMlBSQXpFUkhyUysySytvOFRCVjdXSWZwNHZDYmcwamE5SVRhYWhxRHNR?= =?utf-8?B?YWEwTEZCNUxJcTFhZXR6WFg2QkR5RTNRTDFEd0doUXhCcXZSSDZ3aWZOQnVt?= =?utf-8?B?aUh3MW0yUjVqZlVhTVliMFdaVFY0amFGMlFjU3hHc1hVMVBxNzZyUUlOTzVu?= =?utf-8?Q?f7+b4TCUPGah7sZpCInbB08Ple5WLD2NQRtRRgY=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;6:uRjU8T59vmm7zvoEQtUC9aqNzaknhSNmqQsxPLoFDdqe/lNOC+Wqjh1hDtdnAVTtmbIq8GWioVvH8/LNCywSy3okaqjnZDmNQCZcmss/4LzMdVwE9eTf37k9DG4qTWkFhxKIVvTWGt0zTKU1GiTY/j10jmbuwfUKYk4C1BbvUjyabfa9SivS519899a0XwyRRpNo66EmC1RtMQEMHbMf1nXLptx9kvrZLm9tqaLgK+y+TP6wCxUN5APJ4XNd86On9Ta8IV/mkoPcprm3kMW/dnDRC2Xb7DUVgQ5cYxAAQabHZtFgFeyMJ8mrzo7U98/gcJIQtAMi0Wkfoa4x5hcEQA==;5:IBkaDW+QXwe0lRfX2UD4DLzxjW9zUKl8LiIWyByX/+i5Uzl4vgLy4ciwIsasm9MuFu83CIB5ubVyyabRMZKANsPajYsOjJjwEcwlyKadkdnWnZsBpQFr0fAY/bqjURQFiKysiTLHbM1CkgS3J8SPWQ==;24:nzeeW2Vml6QfU2w3o04uxbV+JBi/f01ukSiRhF0tZtKO4PwEgXL1t1qW7eR1H/KvdQJj+siRJDHq+UhmJHzB5P4vHkDga/mWNR0yJ4yJJho= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;7:JAXUuRoSCLc0GjfHNXeI7cJUh7xBmtWaoITd/HDwg/I4alLpecW1GT2xn3BH+AFCmF4N4eDJWdLBq3sGBqNKIqdSu258/DEor0rFyDy15m4jz7hB3bJQ6e+q+20uYO5qXjV/8G1KV/uHLBxFkaoesTdKyYdORD/ciAarNQGK91RY8ac/ZKbyakPAwhMCaoSydD2fOfrDqJoU3xGhu+TvXNGvQIEHkYS8dWMtol7iLnhlgiZsVP/SxKIqbD5hhJPYHYQAJmIVxcxKdU5Kr/xocdt388CZyfDpmSpFPYeLFBACZTehvhadVeZld3/42zwzf/h3+lqeo3LH92OeGwGYFzbUMyI3kQKUr5PkNcHtUio= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2016 15:44:16.0393 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0601MB1635 X-OriginatorOrg: netapp.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shuah, On 11/07/2016 10:41 AM, Shuah Khan wrote: > Fix the following warn: > > net/netfilter/ipvs/ip_vs_sync.c: In function ‘ip_vs_proc_sync_conn’: > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘opt.init_seq’ may be used uninitialized in this function [-Wmaybe-uninitialized] > struct ip_vs_sync_conn_options opt; > ^~~ > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘opt.delta’ may be used uninitialized in this function [-Wmaybe-uninitialized] > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘opt.previous_delta’ may be used uninitialized in this function [-Wmaybe-uninitialized] > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘*((void *)&opt+12).init_seq’ may be used uninitialized in this function [-Wmaybe-uninitialized] > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘*((void *)&opt+12).delta’ may be used uninitialized in this function [-Wmaybe-uninitialized] > net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘*((void *)&opt+12).previous_delta’ may be used uninitialized in this function [-Wmaybe-uninitialized] Are you sure you put the right commit message on this patch? The message describes a warning in ip_vs_sync.c, but the patch is for nfs4session.c. Thanks, Anna > > Signed-off-by: Shuah Khan > --- > fs/nfs/nfs4session.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nfs/nfs4session.c b/fs/nfs/nfs4session.c > index b629730..68e700e 100644 > --- a/fs/nfs/nfs4session.c > +++ b/fs/nfs/nfs4session.c > @@ -196,7 +196,7 @@ static int nfs4_slot_get_seqid(struct nfs4_slot_table *tbl, u32 slotid, > static bool nfs4_slot_seqid_in_use(struct nfs4_slot_table *tbl, > u32 slotid, u32 seq_nr) > { > - u32 cur_seq; > + u32 cur_seq = 0; > bool ret = false; > > spin_lock(&tbl->slot_tbl_lock); >