From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38660C31E40 for ; Sun, 4 Aug 2019 01:46:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0313A217D6 for ; Sun, 4 Aug 2019 01:46:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564883167; bh=LObcNmCTMYOwT0YqrzSQoS9DFz9YmJB/jsZ8jz9VWiw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=0rrQwBWupBTxTiNCy8VAvqoNjmNWJQHmYgmlgCN3tmxrpO54WA7N++Qag/NlJqJlF /YeyPA8j908UhGXGBRqWVoyNilfUKX3nFcyoDpZLllhj8l7SvSQjIoe90ah7wOynwO J2KpkBg+1n6efHKMs0SkpA6X+ywUKFoSZXu/jUt4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729435AbfHDBqE (ORCPT ); Sat, 3 Aug 2019 21:46:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:45392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbfHDBqE (ORCPT ); Sat, 3 Aug 2019 21:46:04 -0400 Received: from localhost.localdomain (ool-18bba523.dyn.optonline.net [24.187.165.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F253321726; Sun, 4 Aug 2019 01:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564883163; bh=LObcNmCTMYOwT0YqrzSQoS9DFz9YmJB/jsZ8jz9VWiw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=E2bL4sYF6FreUCYUd9IpAVztcpoyip+1mUP3FEP3RYjJ24xUpPslMV+cTd2qyJ4MA 0huAb7ZkdApN7WG1I353p1c7oZ/SscxOtvscfIx0Cy6Tq/ZhNMOZAkXjLtx+rt/mdd btu9sLWTJWfbk7cGLxkNJbr4dTwd0Ew0vA63dfM8= Message-ID: <1564883160.11223.103.camel@kernel.org> Subject: Re: [PATCH] KEYS: trusted: allow module init if TPM is inactive or deactivated From: Mimi Zohar To: Jarkko Sakkinen , Tyler Hicks Cc: Roberto Sassu , jejb@linux.ibm.com, jgg@ziepe.ca, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, crazyt2019+lml@gmail.com, nayna@linux.vnet.ibm.com, silviu.vlasceanu@huawei.com Date: Sat, 03 Aug 2019 21:46:00 -0400 In-Reply-To: References: <20190705163735.11539-1-roberto.sassu@huawei.com> <20190711194811.rfsohbfc3a7carpa@linux.intel.com> <20190801163215.mfkagoafkxscesne@linux.intel.com> <20190802142721.GA26616@elm> <20190802194226.oiztvme5klkmw6fh@linux.intel.com> <20190802202343.GE26616@elm> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2019-08-03 at 17:44 +0300, Jarkko Sakkinen wrote: > On Fri, 2019-08-02 at 15:23 -0500, Tyler Hicks wrote: > > That wasn't the conclusion that I came to. I prefer Robert's proposed > > change to trusted.ko. > > > > How do you propose that this be fixed in eCryptfs? > > > > Removing encrypted_key support from eCryptfs is the only way that I can > > see to fix the bug in eCryptfs. That support has been there since 2011. > > I'm not sure of the number of users that would be broken by removing > > encrypted_key support. I don't think the number is high but I can't say > > that confidently. > > Looking at the documentation [1] it is stated that > > "Encrypted keys do not depend on a TPM, and are faster, as they use AES > for encryption/decryption." > > Why would you need to remove support for encrypted keys? Isn't it a > regression in encrypted keys to hard depend on trusted keys given > what the documentation says? "Encrypted" key are symmetric keys, which are encrypted/decrypted either by a "trusted" key or, for development purposes only, a "user" key. Mimi