From: Oliver Neukum <oneukum@suse.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Andrey Konovalov <andreyknvl@google.com>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
syzbot <syzbot+1b2449b7b5dc240d107a@syzkaller.appspotmail.com>,
LKML <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: KASAN: use-after-free Read in device_release_driver_internal
Date: Tue, 06 Aug 2019 16:25:58 +0200 [thread overview]
Message-ID: <1565101558.8136.30.camel@suse.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1908061009450.1571-100000@iolanthe.rowland.org>
Am Dienstag, den 06.08.2019, 10:19 -0400 schrieb Alan Stern:
> On Tue, 6 Aug 2019, Oliver Neukum wrote:
>
> > Am Donnerstag, den 01.08.2019, 14:47 -0400 schrieb Alan Stern:
> > >
> > > I think this must be caused by an unbalanced refcount. That is,
> > > something must drop one more reference to the device than it takes.
> > > That would explain why the invalid access occurs inside a single
> > > bus_remove_device() call, between the klist_del() and
> > > device_release_driver().
> > >
> > > The kernel log indicates that the device was probed by rndis_wlan,
> > > rndis_host, and cdc_acm, all of which got errors because of the
> > > device's bogus descriptors. Probably one of them is messing up the
> > > refcount.
> >
> > Hi,
> >
> > you made me look at cdc-acm. I suspect
> >
> > cae2bc768d176bfbdad7035bbcc3cdc973eb7984 ("usb: cdc-acm: Decrement tty port's refcount if probe() fail")
> >
> > is buggy decrementing the refcount on the interface in destroy()
> > even before the refcount is increased.
> >
> > Unfortunately I cannot tell from the bug report how many and which
> > interfaces the emulated test device has. Hence it is unclear to me,
> > when exactly probe() would fail cdc-acm.
>
> Only one interface (numbered 234!).
Yes. cdc-acm went into the look_for_collapsed_interface code path.
But I cannot tell whether it proceeded to made_compressed_probe
(Yes, I know the code makes extensive use of "goto")
> > If you agree. I am attaching a putative fix.
>
> Your patch adds a line saying:
>
> > + usb_get_intf(acm->control); /* undone in destroy() */
>
> but I don't see any destroy() function in that source file. Did you
> mean acm_port_destruct()?
Yes, sorry
> In any case, I don't know if this missing "get" would cause the
> problem, but it might well.
Then let's wait for the result.
Regards
Oliver
next prev parent reply other threads:[~2019-08-06 14:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 14:28 KASAN: use-after-free Read in device_release_driver_internal syzbot
2019-08-01 16:01 ` Andrey Konovalov
2019-08-01 18:47 ` Alan Stern
2019-08-06 12:36 ` Oliver Neukum
2019-08-06 12:50 ` Andrey Konovalov
2019-08-07 13:38 ` Oliver Neukum
2019-08-07 13:44 ` Andrey Konovalov
2019-08-07 13:44 ` Andrey Konovalov
2019-08-07 13:45 ` Andrey Konovalov
2019-08-07 14:13 ` syzbot
2019-08-07 13:56 ` syzbot
2019-08-07 17:40 ` Alan Stern
2019-08-07 17:51 ` syzbot
2019-08-07 18:05 ` Alan Stern
2019-08-07 18:23 ` syzbot
2019-08-07 18:31 ` Alan Stern
2019-08-08 12:27 ` Andrey Konovalov
2019-08-08 12:43 ` Dmitry Vyukov
2019-08-08 13:03 ` Andrey Konovalov
2019-08-08 13:59 ` Alan Stern
2019-08-13 12:42 ` Andrey Konovalov
2019-08-13 13:22 ` Oliver Neukum
2019-08-13 13:24 ` Andrey Konovalov
2019-08-13 15:16 ` Greg KH
2019-08-13 13:59 ` Andrey Konovalov
2019-08-06 14:19 ` Alan Stern
2019-08-06 14:25 ` Oliver Neukum [this message]
2019-08-06 15:33 ` Oliver Neukum
2019-08-07 13:46 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565101558.8136.30.camel@suse.com \
--to=oneukum@suse.com \
--cc=andreyknvl@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+1b2449b7b5dc240d107a@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).