From: Paul Cercueil <paul@crapouillou.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
od@zcrc.me, linux-pwm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] pwm: jz4740: Drop dependency on MACH_INGENIC
Date: Fri, 09 Aug 2019 23:40:59 +0200 [thread overview]
Message-ID: <1565386860.2091.5@crapouillou.net> (raw)
In-Reply-To: <20190809164143.2p573g7wlx43hero@pengutronix.de>
Le ven. 9 août 2019 à 18:41, Uwe =?iso-8859-1?q?Kleine-K=F6nig?=
<u.kleine-koenig@pengutronix.de> a écrit :
> On Fri, Aug 09, 2019 at 02:30:27PM +0200, Paul Cercueil wrote:
>> Depending on MACH_INGENIC prevent us from creating a generic kernel
>> that
>> works on more than one MIPS board. Instead, we just depend on MIPS
>> being
>> set.
>>
>> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>> ---
>> drivers/pwm/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
>> index d2557c6fcf65..82a75e0b72e5 100644
>> --- a/drivers/pwm/Kconfig
>> +++ b/drivers/pwm/Kconfig
>> @@ -224,7 +224,7 @@ config PWM_IMX_TPM
>>
>> config PWM_JZ4740
>> tristate "Ingenic JZ47xx PWM support"
>> - depends on MACH_INGENIC
>> + depends on MIPS
>
> If this isn't actually useful on MIPS without MACH_INGENIC this is
> better expressed using:
>
> depends on MIPS
> depends on MACH_INGENIC || COMPILE_TEST
>
> This way some configuring a mips kernel without INGENIC isn't bothered
> by this question.
As said in the commit message, it is useful on MIPS without
MACH_INGENIC,
if you want to create a generic kernel that works on more than one MIPS
board.
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König
> |
> Industrial Linux Solutions |
> http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-08-09 21:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 12:30 [PATCH 0/7] pwm: jz4740: Driver update Paul Cercueil
2019-08-09 12:30 ` [PATCH 1/7] pwm: jz4740: Obtain regmap from parent node Paul Cercueil
2019-08-09 16:51 ` Uwe Kleine-König
2019-08-09 17:04 ` Paul Cercueil
2019-08-12 6:18 ` Uwe Kleine-König
2019-08-09 12:30 ` [PATCH 2/7] pwm: jz4740: Use clocks from TCU driver Paul Cercueil
2019-08-09 16:55 ` Uwe Kleine-König
2019-08-09 12:30 ` [PATCH 3/7] pwm: jz4740: Drop dependency on MACH_INGENIC Paul Cercueil
2019-08-09 16:41 ` Uwe Kleine-König
2019-08-09 21:40 ` Paul Cercueil [this message]
2019-08-12 6:09 ` Uwe Kleine-König
2019-08-09 12:30 ` [PATCH 4/7] pwm: jz4740: Improve algorithm of clock calculation Paul Cercueil
2019-08-09 17:05 ` Uwe Kleine-König
2019-08-09 17:14 ` Paul Cercueil
2019-08-12 6:15 ` Uwe Kleine-König
2019-08-12 20:43 ` Paul Cercueil
2019-08-12 21:48 ` Uwe Kleine-König
2019-08-12 22:25 ` Paul Cercueil
[not found] ` <1565648183.2007.3@crapouillou.net>
2019-08-13 5:27 ` Uwe Kleine-König
2019-08-13 11:01 ` Paul Cercueil
2019-08-13 12:33 ` Uwe Kleine-König
2019-08-13 12:47 ` Paul Cercueil
2019-08-13 14:09 ` Uwe Kleine-König
2019-08-14 16:10 ` Paul Cercueil
2019-08-14 17:32 ` Uwe Kleine-König
2019-10-21 12:47 ` Paul Cercueil
2020-02-12 7:29 ` About rounding in the clk framework [Was: Re: [PATCH 4/7] pwm: jz4740: Improve algorithm of clock calculation] Uwe Kleine-König
2020-04-14 9:24 ` Uwe Kleine-König
2020-12-21 13:57 ` Uwe Kleine-König
2019-08-09 12:30 ` [PATCH 5/7] pwm: jz4740: Allow selection of PWM channels 0 and 1 Paul Cercueil
2019-08-09 12:30 ` [PATCH 6/7] pwm: jz4740: Make PWM start with the active part Paul Cercueil
2019-08-09 17:10 ` Uwe Kleine-König
2019-08-09 17:33 ` Paul Cercueil
2019-08-12 5:55 ` Uwe Kleine-König
2019-08-12 20:50 ` Paul Cercueil
2019-08-12 21:58 ` Uwe Kleine-König
2019-09-20 22:52 ` Thierry Reding
2019-08-09 12:30 ` [PATCH 7/7] pwm: jz4740: document known limitations Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565386860.2091.5@crapouillou.net \
--to=paul@crapouillou.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=od@zcrc.me \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).